| Message ID | 1437482466-16126-2-git-send-email-vaibhav.hiremath@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jul 21, 2015 at 06:11:02PM +0530, Vaibhav Hiremath wrote: > Driver will now supports enable/disable across msg xfer, which user > can control it by new DT property - > > i2c-disable-after-xfer : If set, driver will disable I2C module after msg > xfer and enable it back before xfer. If this is a new property specific to this Marvell part, it needs the vendor prefix as in mrvl,i2c-disable-after-xfer Or, it couldn't hurt to start an i2c.txt for generic i2c bindings and store it there as this and others later in this series would reasonably apply to other controllers. -Matt > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> > --- > Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt b/Documentation/devicetree/bindings/i2c/i2c-pxa.txt > index 12b78ac..9657db5 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-pxa.txt > @@ -18,6 +18,11 @@ Recommended properties : > status register of i2c controller instead. > - mrvl,i2c-fast-mode : Enable fast mode of i2c controller. > > +Optional properties : > + > + - i2c-disable-after-xfer : If set, driver will disable I2C module > + after msg xfer and enable it again before xfer. > + > Examples: > twsi1: i2c@d4011000 { > compatible = "mrvl,mmp-twsi"; > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Monday 27 July 2015 07:39 PM, Matt Porter wrote: > On Tue, Jul 21, 2015 at 06:11:02PM +0530, Vaibhav Hiremath wrote: >> Driver will now supports enable/disable across msg xfer, which user >> can control it by new DT property - >> >> i2c-disable-after-xfer : If set, driver will disable I2C module after msg >> xfer and enable it back before xfer. > > If this is a new property specific to this Marvell part, it needs > the vendor prefix as in mrvl,i2c-disable-after-xfer > We discussed about this, I think in V1 or V2. Decided to use generic name, as feature (in turn property) could be used by other drivers as well. > Or, it couldn't hurt to start an i2c.txt for generic i2c bindings > and store it there as this and others later in this series would > reasonably apply to other controllers. > Yeah, we could start i2c.txt, probably better to have separate new patch all together. Thanks, Vaibhav
> Yeah, we could start i2c.txt, probably better to have separate new > patch all together. I will start such a file today as part of the i2c slave framework update which introduces flags to the reg property. Will post to the i2c list this week.
On Wednesday 05 August 2015 02:19 PM, Wolfram Sang wrote: > I will start such a file today as part of the i2c slave framework > update which introduces flags to the reg property. Will post to the i2c > list this week. Great and thanks for taking this. I believe, better to wait for your patch and then rebase my patch- series against it. right? Request to review the this patch-series, so that I can incorporate all comments in V6. Thanks, Vaibhav
On Wed, Aug 05, 2015 at 12:04:25PM +0530, Vaibhav Hiremath wrote: > > > On Monday 27 July 2015 07:39 PM, Matt Porter wrote: > >On Tue, Jul 21, 2015 at 06:11:02PM +0530, Vaibhav Hiremath wrote: > >>Driver will now supports enable/disable across msg xfer, which user > >>can control it by new DT property - > >> > >>i2c-disable-after-xfer : If set, driver will disable I2C module after msg > >> xfer and enable it back before xfer. > > > >If this is a new property specific to this Marvell part, it needs > >the vendor prefix as in mrvl,i2c-disable-after-xfer > > > > We discussed about this, I think in V1 or V2. Decided to use generic > name, as feature (in turn property) could be used by other drivers as > well. Ahh, ok, thanks...coming in too late on this one. :) > >Or, it couldn't hurt to start an i2c.txt for generic i2c bindings > >and store it there as this and others later in this series would > >reasonably apply to other controllers. > > > > Yeah, we could start i2c.txt, probably better to have separate new > patch all together. Great, yes, I've always found it hard to follow i2c generic bindings since they aren't defined in a clear place like other similar hardware (e.g. SPI). -Matt
On Wednesday 05 August 2015 07:50 PM, Matt Porter wrote: > On Wed, Aug 05, 2015 at 12:04:25PM +0530, Vaibhav Hiremath wrote: >> >> >> On Monday 27 July 2015 07:39 PM, Matt Porter wrote: >>> On Tue, Jul 21, 2015 at 06:11:02PM +0530, Vaibhav Hiremath wrote: >>>> Driver will now supports enable/disable across msg xfer, which user >>>> can control it by new DT property - >>>> >>>> i2c-disable-after-xfer : If set, driver will disable I2C module after msg >>>> xfer and enable it back before xfer. >>> >>> If this is a new property specific to this Marvell part, it needs >>> the vendor prefix as in mrvl,i2c-disable-after-xfer >>> >> >> We discussed about this, I think in V1 or V2. Decided to use generic >> name, as feature (in turn property) could be used by other drivers as >> well. > > Ahh, ok, thanks...coming in too late on this one. :) > >>> Or, it couldn't hurt to start an i2c.txt for generic i2c bindings >>> and store it there as this and others later in this series would >>> reasonably apply to other controllers. >>> >> >> Yeah, we could start i2c.txt, probably better to have separate new >> patch all together. > > Great, yes, I've always found it hard to follow i2c generic bindings > since they aren't defined in a clear place like other similar hardware > (e.g. SPI). > Wolfram has already owned up on creating i2c.txt for generic properties. So, we will be soon close to others. And thanks for your comments. Please let me know if you have any other comments on patch-series, so that I can incorporate it in next version. Thanks, Vaibhav
On Wed, Aug 05, 2015 at 10:49:18AM +0200, Wolfram Sang wrote: > > > Yeah, we could start i2c.txt, probably better to have separate new > > patch all together. > > I will start such a file today as part of the i2c slave framework > update which introduces flags to the reg property. Will post to the i2c > list this week. > That sounds great, Wolfram, that will be a nice improvement for the binding docs. Thanks, Matt
diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt b/Documentation/devicetree/bindings/i2c/i2c-pxa.txt index 12b78ac..9657db5 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-pxa.txt @@ -18,6 +18,11 @@ Recommended properties : status register of i2c controller instead. - mrvl,i2c-fast-mode : Enable fast mode of i2c controller. +Optional properties : + + - i2c-disable-after-xfer : If set, driver will disable I2C module + after msg xfer and enable it again before xfer. + Examples: twsi1: i2c@d4011000 { compatible = "mrvl,mmp-twsi";
Driver will now supports enable/disable across msg xfer, which user can control it by new DT property - i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer and enable it back before xfer. Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> --- Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 5 +++++ 1 file changed, 5 insertions(+)