| Message ID | 1437568344-18889-4-git-send-email-fcooper@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wednesday 22 July 2015 06:02 PM, Franklin S Cooper Jr wrote: > SPI Davinci driver has been updated to allow SOCs to specify their minimum > prescale value. Update the various SOCs board files that use this driver with > their proper prescaler limit. > > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> Acked-by: Sekhar Nori <nsekhar@ti.com> in case Mark is okay to take it through his tree. It does not clash with anything else I have for mach-davinci. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/24/2015 06:50 AM, Sekhar Nori wrote: > On Wednesday 22 July 2015 06:02 PM, Franklin S Cooper Jr wrote: >> SPI Davinci driver has been updated to allow SOCs to specify their minimum >> prescale value. Update the various SOCs board files that use this driver with >> their proper prescaler limit. >> >> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> > Acked-by: Sekhar Nori <nsekhar@ti.com> > > in case Mark is okay to take it through his tree. It does not clash with > anything else I have for mach-davinci. > > Thanks, > Sekhar > ping. Patches 1 and 2 have already been pulled into Mark's spi tree and are currently in in linux-next. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 11 August 2015 05:17 AM, Franklin S Cooper Jr. wrote: > > > On 07/24/2015 06:50 AM, Sekhar Nori wrote: >> On Wednesday 22 July 2015 06:02 PM, Franklin S Cooper Jr wrote: >>> SPI Davinci driver has been updated to allow SOCs to specify their minimum >>> prescale value. Update the various SOCs board files that use this driver with >>> their proper prescaler limit. >>> >>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> >> Acked-by: Sekhar Nori <nsekhar@ti.com> >> >> in case Mark is okay to take it through his tree. It does not clash with >> anything else I have for mach-davinci. >> >> Thanks, >> Sekhar >> > ping. Patches 1 and 2 have already been pulled into Mark's spi tree and are currently in in linux-next. Mark, can you apply this patch to your tree as well? Thats the preferred route for me. If thats not an option for you, can you confirm that the topic/davinci branch of your spi tree is an immutable commit I can base my pull request to ARM-SoC on? Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 11, 2015 at 12:28:21PM +0530, Sekhar Nori wrote: > On Tuesday 11 August 2015 05:17 AM, Franklin S Cooper Jr. wrote: > > ping. Patches 1 and 2 have already been pulled into Mark's spi tree and are currently in in linux-next. > Mark, can you apply this patch to your tree as well? Thats the preferred > route for me. > If thats not an option for you, can you confirm that the topic/davinci > branch of your spi tree is an immutable commit I can base my pull > request to ARM-SoC on? Why would there be any interdependency between the the two trees, that would be very unusual? Adding a new value to DT doesn't need the kernel to understand it and the driver should be compatible with existing DTs. If there *is* some dependency that suggests the driver update has problems... In any case I don't have a copy of the patch any more.
On Tuesday 11 August 2015 02:33 PM, Mark Brown wrote: > On Tue, Aug 11, 2015 at 12:28:21PM +0530, Sekhar Nori wrote: >> On Tuesday 11 August 2015 05:17 AM, Franklin S Cooper Jr. wrote: > >>> ping. Patches 1 and 2 have already been pulled into Mark's spi tree and are currently in in linux-next. > >> Mark, can you apply this patch to your tree as well? Thats the preferred >> route for me. > >> If thats not an option for you, can you confirm that the topic/davinci >> branch of your spi tree is an immutable commit I can base my pull >> request to ARM-SoC on? > > Why would there be any interdependency between the the two trees, that > would be very unusual? Adding a new value to DT doesn't need the kernel > to understand it and the driver should be compatible with existing DTs. > If there *is* some dependency that suggests the driver update has > problems... The dependency is because of platform data. Patch 2/4 adds a new platform data member 'prescaler_limit' which this patch populates for DaVinci devices using legacy booting. > In any case I don't have a copy of the patch any more. I can resend this patch to you with my ack included. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 11, 2015 at 02:54:33PM +0530, Sekhar Nori wrote: > On Tuesday 11 August 2015 02:33 PM, Mark Brown wrote: > > Why would there be any interdependency between the the two trees, that > > would be very unusual? Adding a new value to DT doesn't need the kernel > > to understand it and the driver should be compatible with existing DTs. > > If there *is* some dependency that suggests the driver update has > > problems... > The dependency is because of platform data. Patch 2/4 adds a new > platform data member 'prescaler_limit' which this patch populates for > DaVinci devices using legacy booting. Ugh, you still have legacy platforms :( > > In any case I don't have a copy of the patch any more. > I can resend this patch to you with my ack included. I guess.
diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c index ddfdd82..29e08aa 100644 --- a/arch/arm/mach-davinci/devices-da8xx.c +++ b/arch/arm/mach-davinci/devices-da8xx.c @@ -1010,11 +1010,13 @@ static struct davinci_spi_platform_data da8xx_spi_pdata[] = { .version = SPI_VERSION_2, .intr_line = 1, .dma_event_q = EVENTQ_0, + .prescaler_limit = 2, }, [1] = { .version = SPI_VERSION_2, .intr_line = 1, .dma_event_q = EVENTQ_0, + .prescaler_limit = 2, }, }; diff --git a/arch/arm/mach-davinci/dm355.c b/arch/arm/mach-davinci/dm355.c index 9cbeda7..567dc56 100644 --- a/arch/arm/mach-davinci/dm355.c +++ b/arch/arm/mach-davinci/dm355.c @@ -411,6 +411,7 @@ static struct davinci_spi_platform_data dm355_spi0_pdata = { .num_chipselect = 2, .cshold_bug = true, .dma_event_q = EVENTQ_1, + .prescaler_limit = 1, }; static struct platform_device dm355_spi0_device = { .name = "spi_davinci", diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c index e3a3c54..6a890a8 100644 --- a/arch/arm/mach-davinci/dm365.c +++ b/arch/arm/mach-davinci/dm365.c @@ -646,6 +646,7 @@ static struct davinci_spi_platform_data dm365_spi0_pdata = { .version = SPI_VERSION_1, .num_chipselect = 2, .dma_event_q = EVENTQ_3, + .prescaler_limit = 1, }; static struct resource dm365_spi0_resources[] = {
SPI Davinci driver has been updated to allow SOCs to specify their minimum prescale value. Update the various SOCs board files that use this driver with their proper prescaler limit. Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> --- arch/arm/mach-davinci/devices-da8xx.c | 2 ++ arch/arm/mach-davinci/dm355.c | 1 + arch/arm/mach-davinci/dm365.c | 1 + 3 files changed, 4 insertions(+)