diff mbox

PCI: iproc_bcma: allow build as module

Message ID 1437851724-10519-1-git-send-email-hauke@hauke-m.de (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Hauke Mehrtens July 25, 2015, 7:15 p.m. UTC
Changes this to tristate to make it possible to build this driver as a
module.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 drivers/pci/host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bjorn Helgaas Aug. 11, 2015, 8:12 p.m. UTC | #1
[+cc Scott, bcm-kernel-feedback-list]

On Sat, Jul 25, 2015 at 09:15:24PM +0200, Hauke Mehrtens wrote:
> Changes this to tristate to make it possible to build this driver as a
> module.
> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

Waiting for an ack from Ray or Scott.

> ---
>  drivers/pci/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index c132bdd..e339a8c 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -135,7 +135,7 @@ config PCIE_IPROC_PLATFORM
>  	  through the generic platform bus interface
>  
>  config PCIE_IPROC_BCMA
> -	bool "Broadcom iProc PCIe BCMA bus driver"
> +	tristate "Broadcom iProc PCIe BCMA bus driver"
>  	depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
>  	select PCIE_IPROC
>  	select BCMA
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ray Jui Aug. 11, 2015, 8:22 p.m. UTC | #2
On 8/11/2015 1:12 PM, Bjorn Helgaas wrote:
> [+cc Scott, bcm-kernel-feedback-list]
> 
> On Sat, Jul 25, 2015 at 09:15:24PM +0200, Hauke Mehrtens wrote:
>> Changes this to tristate to make it possible to build this driver as a
>> module.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> 
> Waiting for an ack from Ray or Scott.
> 
>> ---
>>  drivers/pci/host/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
>> index c132bdd..e339a8c 100644
>> --- a/drivers/pci/host/Kconfig
>> +++ b/drivers/pci/host/Kconfig
>> @@ -135,7 +135,7 @@ config PCIE_IPROC_PLATFORM
>>  	  through the generic platform bus interface
>>  
>>  config PCIE_IPROC_BCMA
>> -	bool "Broadcom iProc PCIe BCMA bus driver"
>> +	tristate "Broadcom iProc PCIe BCMA bus driver"

This looks fine. I also build test it to make sure there's no export
symbol related issues.

Acked-by: Ray Jui <rjui@broadcom.com>

Thanks,

Ray

>>  	depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
>>  	select PCIE_IPROC
>>  	select BCMA
>> -- 
>> 2.1.4
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bjorn Helgaas Aug. 11, 2015, 8:36 p.m. UTC | #3
On Sat, Jul 25, 2015 at 09:15:24PM +0200, Hauke Mehrtens wrote:
> Changes this to tristate to make it possible to build this driver as a
> module.
> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

Applied with Ray's ack to pci/host-iproc for v4.3, thanks!

> ---
>  drivers/pci/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index c132bdd..e339a8c 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -135,7 +135,7 @@ config PCIE_IPROC_PLATFORM
>  	  through the generic platform bus interface
>  
>  config PCIE_IPROC_BCMA
> -	bool "Broadcom iProc PCIe BCMA bus driver"
> +	tristate "Broadcom iProc PCIe BCMA bus driver"
>  	depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
>  	select PCIE_IPROC
>  	select BCMA
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index c132bdd..e339a8c 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -135,7 +135,7 @@  config PCIE_IPROC_PLATFORM
 	  through the generic platform bus interface
 
 config PCIE_IPROC_BCMA
-	bool "Broadcom iProc PCIe BCMA bus driver"
+	tristate "Broadcom iProc PCIe BCMA bus driver"
 	depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
 	select PCIE_IPROC
 	select BCMA