| Message ID | 1439358807-9024-1-git-send-email-dongsheng.wang@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Aug 12, 2015 at 01:53:26PM +0800, Dongsheng Wang wrote: > diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig > new file mode 100644 > index 0000000..863d1ef > --- /dev/null > +++ b/drivers/soc/fsl/Kconfig > @@ -0,0 +1,18 @@ > +# > +# Freescale SOC drivers > +# > +menuconfig FSL_SOC_DRIVERS > + bool "Freescale Soc Drivers" > + default n No need for default n. > diff --git a/drivers/soc/fsl/Kconfig.arm b/drivers/soc/fsl/Kconfig.arm > new file mode 100644 > index 0000000..8c90b82 > --- /dev/null > +++ b/drivers/soc/fsl/Kconfig.arm > @@ -0,0 +1,16 @@ > +# > +# Freescale ARM SOC Drivers > +# > + > +config LS1_SOC_DRIVERS > + bool "LS1021A Soc Drivers" > + depends on SOC_LS1021A > + default n Ditto. > + help > + Say y here to enable Freescale LS1021A Soc Device Drivers support. > + The Soc Drivers provides the device driver that is a specific block > + or feature on LS1021A platform. Help text should be indented by two spaces as per almost every other help text. > + > +if LS1_SOC_DRIVERS > + source "drivers/soc/fsl/ls1/Kconfig" > +endif > diff --git a/drivers/soc/fsl/Makefile b/drivers/soc/fsl/Makefile > new file mode 100644 > index 0000000..b4215dd > --- /dev/null > +++ b/drivers/soc/fsl/Makefile > @@ -0,0 +1,6 @@ > +# > +# Makefile for Freescale Soc specific device drivers. > +# > + > +obj-$(CONFIG_LS1_SOC_DRIVERS) += ls1/ > + > diff --git a/drivers/soc/fsl/ls1/Kconfig b/drivers/soc/fsl/ls1/Kconfig > new file mode 100644 > index 0000000..7556f44 > --- /dev/null > +++ b/drivers/soc/fsl/ls1/Kconfig > @@ -0,0 +1,3 @@ > +# > +# LS-1 Soc drivers > +# Doesn't this directory need a Makefile as well?
Hi Russell, Thanks for your review. :) > -----Original Message----- > From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk] > Sent: Wednesday, August 12, 2015 3:45 PM > To: Wang Dongsheng-B40534 > Cc: shawn.guo@linaro.org; Wang Huan-B18965; linus.walleij@linaro.org; linux- > kernel@vger.kernel.org; sandeep_n@ti.com; hdegoede@redhat.com; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v2 1/2] soc/fsl: add freescale dir for SOC specific drivers > > On Wed, Aug 12, 2015 at 01:53:26PM +0800, Dongsheng Wang wrote: > > diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig new > > file mode 100644 index 0000000..863d1ef > > --- /dev/null > > +++ b/drivers/soc/fsl/Kconfig > > @@ -0,0 +1,18 @@ > > +# > > +# Freescale SOC drivers > > +# > > +menuconfig FSL_SOC_DRIVERS > > + bool "Freescale Soc Drivers" > > + default n > > No need for default n. Thanks. Fix it in next version. > > + help > > + Say y here to enable Freescale LS1021A Soc Device Drivers support. > > + The Soc Drivers provides the device driver that is a specific block > > + or feature on LS1021A platform. > > Help text should be indented by two spaces as per almost every other help text. > Thanks. My mistake... > > + > > +if LS1_SOC_DRIVERS > > + source "drivers/soc/fsl/ls1/Kconfig" > > +endif > > diff --git a/drivers/soc/fsl/Makefile b/drivers/soc/fsl/Makefile new > > file mode 100644 index 0000000..b4215dd > > --- /dev/null > > +++ b/drivers/soc/fsl/Makefile > > @@ -0,0 +1,6 @@ > > +# > > +# Makefile for Freescale Soc specific device drivers. > > +# > > + > > +obj-$(CONFIG_LS1_SOC_DRIVERS) += ls1/ > > + > > diff --git a/drivers/soc/fsl/ls1/Kconfig b/drivers/soc/fsl/ls1/Kconfig > > new file mode 100644 index 0000000..7556f44 > > --- /dev/null > > +++ b/drivers/soc/fsl/ls1/Kconfig > > @@ -0,0 +1,3 @@ > > +# > > +# LS-1 Soc drivers > > +# > > Doesn't this directory need a Makefile as well? > 2/2 patch add a config option and Makefile for this. Regards, -Dongsheng
On Wed, Aug 12, 2015 at 08:01:32AM +0000, Wang Dongsheng wrote: > Hi Russell, > > Thanks for your review. :) > > > -----Original Message----- > > From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk] > > Sent: Wednesday, August 12, 2015 3:45 PM > > To: Wang Dongsheng-B40534 > > Cc: shawn.guo@linaro.org; Wang Huan-B18965; linus.walleij@linaro.org; linux- > > kernel@vger.kernel.org; sandeep_n@ti.com; hdegoede@redhat.com; linux-arm- > > kernel@lists.infradead.org > > Subject: Re: [PATCH v2 1/2] soc/fsl: add freescale dir for SOC specific drivers > > > > On Wed, Aug 12, 2015 at 01:53:26PM +0800, Dongsheng Wang wrote: > > > diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig new > > > file mode 100644 index 0000000..863d1ef > > > --- /dev/null > > > +++ b/drivers/soc/fsl/Kconfig > > > @@ -0,0 +1,18 @@ > > > +# > > > +# Freescale SOC drivers > > > +# > > > +menuconfig FSL_SOC_DRIVERS > > > + bool "Freescale Soc Drivers" > > > + default n > > > > No need for default n. > > Thanks. Fix it in next version. > > > > + help > > > + Say y here to enable Freescale LS1021A Soc Device Drivers support. > > > + The Soc Drivers provides the device driver that is a specific block > > > + or feature on LS1021A platform. > > > > Help text should be indented by two spaces as per almost every other help text. > > > > Thanks. My mistake... > > > > + > > > +if LS1_SOC_DRIVERS > > > + source "drivers/soc/fsl/ls1/Kconfig" > > > +endif > > > diff --git a/drivers/soc/fsl/Makefile b/drivers/soc/fsl/Makefile new > > > file mode 100644 index 0000000..b4215dd > > > --- /dev/null > > > +++ b/drivers/soc/fsl/Makefile > > > @@ -0,0 +1,6 @@ > > > +# > > > +# Makefile for Freescale Soc specific device drivers. > > > +# > > > + > > > +obj-$(CONFIG_LS1_SOC_DRIVERS) += ls1/ > > > + > > > diff --git a/drivers/soc/fsl/ls1/Kconfig b/drivers/soc/fsl/ls1/Kconfig > > > new file mode 100644 index 0000000..7556f44 > > > --- /dev/null > > > +++ b/drivers/soc/fsl/ls1/Kconfig > > > @@ -0,0 +1,3 @@ > > > +# > > > +# LS-1 Soc drivers > > > +# > > > > Doesn't this directory need a Makefile as well? > > > > 2/2 patch add a config option and Makefile for this. If _just_ this patch is merged, it creates a build problem as CONFIG_LS1_SOC_DRIVERS can be enabled, which will cause the kbuild to decend into drivers/soc/fsl/ls1, where it will stop due to the missing build error. Please fix this by adding at least an empty Makefile to this directory. Do not rely on patch 2 being merged to "fix" this.
> -----Original Message----- > From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk] > Sent: Wednesday, August 12, 2015 4:04 PM > To: Wang Dongsheng-B40534 > Cc: shawn.guo@linaro.org; Wang Huan-B18965; linus.walleij@linaro.org; linux- > kernel@vger.kernel.org; sandeep_n@ti.com; hdegoede@redhat.com; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v2 1/2] soc/fsl: add freescale dir for SOC specific drivers > > On Wed, Aug 12, 2015 at 08:01:32AM +0000, Wang Dongsheng wrote: > > Hi Russell, > > > > Thanks for your review. :) > > > > > -----Original Message----- > > > From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk] > > > Sent: Wednesday, August 12, 2015 3:45 PM > > > To: Wang Dongsheng-B40534 > > > Cc: shawn.guo@linaro.org; Wang Huan-B18965; > > > linus.walleij@linaro.org; linux- kernel@vger.kernel.org; > > > sandeep_n@ti.com; hdegoede@redhat.com; linux-arm- > > > kernel@lists.infradead.org > > > Subject: Re: [PATCH v2 1/2] soc/fsl: add freescale dir for SOC > > > specific drivers > > > > > > On Wed, Aug 12, 2015 at 01:53:26PM +0800, Dongsheng Wang wrote: > > > > diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig new > > > > file mode 100644 index 0000000..863d1ef > > > > --- /dev/null > > > > +++ b/drivers/soc/fsl/Kconfig > > > > @@ -0,0 +1,18 @@ > > > > +# > > > > +# Freescale SOC drivers > > > > +# > > > > +menuconfig FSL_SOC_DRIVERS > > > > + bool "Freescale Soc Drivers" > > > > + default n > > > > > > No need for default n. > > > > Thanks. Fix it in next version. > > > > > > + help > > > > + Say y here to enable Freescale LS1021A Soc Device Drivers support. > > > > + The Soc Drivers provides the device driver that is a specific block > > > > + or feature on LS1021A platform. > > > > > > Help text should be indented by two spaces as per almost every other help > text. > > > > > > > Thanks. My mistake... > > > > > > + > > > > +if LS1_SOC_DRIVERS > > > > + source "drivers/soc/fsl/ls1/Kconfig" > > > > +endif > > > > diff --git a/drivers/soc/fsl/Makefile b/drivers/soc/fsl/Makefile > > > > new file mode 100644 index 0000000..b4215dd > > > > --- /dev/null > > > > +++ b/drivers/soc/fsl/Makefile > > > > @@ -0,0 +1,6 @@ > > > > +# > > > > +# Makefile for Freescale Soc specific device drivers. > > > > +# > > > > + > > > > +obj-$(CONFIG_LS1_SOC_DRIVERS) += ls1/ > > > > + > > > > diff --git a/drivers/soc/fsl/ls1/Kconfig > > > > b/drivers/soc/fsl/ls1/Kconfig new file mode 100644 index > > > > 0000000..7556f44 > > > > --- /dev/null > > > > +++ b/drivers/soc/fsl/ls1/Kconfig > > > > @@ -0,0 +1,3 @@ > > > > +# > > > > +# LS-1 Soc drivers > > > > +# > > > > > > Doesn't this directory need a Makefile as well? > > > > > > > 2/2 patch add a config option and Makefile for this. > > If _just_ this patch is merged, it creates a build problem as > CONFIG_LS1_SOC_DRIVERS can be enabled, which will cause the kbuild to decend > into drivers/soc/fsl/ls1, where it will stop due to the missing build error. > > Please fix this by adding at least an empty Makefile to this directory. > Do not rely on patch 2 being merged to "fix" this. > Um..Yes, miss it. Fix it in next version. :) Regards, -Dongsheng
diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig index 96ddecb..b5c5179 100644 --- a/drivers/soc/Kconfig +++ b/drivers/soc/Kconfig @@ -5,5 +5,6 @@ source "drivers/soc/qcom/Kconfig" source "drivers/soc/sunxi/Kconfig" source "drivers/soc/ti/Kconfig" source "drivers/soc/versatile/Kconfig" +source "drivers/soc/fsl/Kconfig" endmenu diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile index 7dc7c0d..1caf1d6 100644 --- a/drivers/soc/Makefile +++ b/drivers/soc/Makefile @@ -8,3 +8,4 @@ obj-$(CONFIG_ARCH_SUNXI) += sunxi/ obj-$(CONFIG_ARCH_TEGRA) += tegra/ obj-$(CONFIG_SOC_TI) += ti/ obj-$(CONFIG_PLAT_VERSATILE) += versatile/ +obj-$(CONFIG_FSL_SOC_DRIVERS) += fsl/ diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig new file mode 100644 index 0000000..863d1ef --- /dev/null +++ b/drivers/soc/fsl/Kconfig @@ -0,0 +1,18 @@ +# +# Freescale SOC drivers +# +menuconfig FSL_SOC_DRIVERS + bool "Freescale Soc Drivers" + default n + help + Say y here to enable Freescale Soc Device Drivers support. + The Soc Drivers provides the device driver that is a specific + block or feature on Freescale platform. + +if FSL_SOC_DRIVERS + +if ARM +source "drivers/soc/fsl/Kconfig.arm" +endif + +endif diff --git a/drivers/soc/fsl/Kconfig.arm b/drivers/soc/fsl/Kconfig.arm new file mode 100644 index 0000000..8c90b82 --- /dev/null +++ b/drivers/soc/fsl/Kconfig.arm @@ -0,0 +1,16 @@ +# +# Freescale ARM SOC Drivers +# + +config LS1_SOC_DRIVERS + bool "LS1021A Soc Drivers" + depends on SOC_LS1021A + default n + help + Say y here to enable Freescale LS1021A Soc Device Drivers support. + The Soc Drivers provides the device driver that is a specific block + or feature on LS1021A platform. + +if LS1_SOC_DRIVERS + source "drivers/soc/fsl/ls1/Kconfig" +endif diff --git a/drivers/soc/fsl/Makefile b/drivers/soc/fsl/Makefile new file mode 100644 index 0000000..b4215dd --- /dev/null +++ b/drivers/soc/fsl/Makefile @@ -0,0 +1,6 @@ +# +# Makefile for Freescale Soc specific device drivers. +# + +obj-$(CONFIG_LS1_SOC_DRIVERS) += ls1/ + diff --git a/drivers/soc/fsl/ls1/Kconfig b/drivers/soc/fsl/ls1/Kconfig new file mode 100644 index 0000000..7556f44 --- /dev/null +++ b/drivers/soc/fsl/ls1/Kconfig @@ -0,0 +1,3 @@ +# +# LS-1 Soc drivers +#