diff mbox

[v2] DT: mmc: sh_mmcif: document R8A779[34] support

Message ID 28226759.dUa3lFkaxJ@wasted.cogentembedded.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sergei Shtylyov Aug. 11, 2015, 10:57 p.m. UTC
Renesas R8A7794 SoC also has the MMCIF controller...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against Ulf Hansson's 'mmc.git'  repo's 'next' branch plus the
patch I posted earlier today...

Changes in version 2:
- deferred R8A7793 support to the patch posted earlier by Ulrich Hecht;
- fixed typo in the changelog.

 Documentation/devicetree/bindings/mmc/renesas,mmcif.txt |    1 +
 1 file changed, 1 insertion(+)


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Simon Horman Aug. 12, 2015, 12:59 a.m. UTC | #1
On Wed, Aug 12, 2015 at 01:57:45AM +0300, Sergei Shtylyov wrote:
> Renesas R8A7794 SoC also has the MMCIF controller...
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

This new compat string looks good to me.

Acked-by: Simon Horman <horms+renesas@verge.net.au>

> 
> ---
> The patch is against Ulf Hansson's 'mmc.git'  repo's 'next' branch plus the
> patch I posted earlier today...
> 
> Changes in version 2:
> - deferred R8A7793 support to the patch posted earlier by Ulrich Hecht;

Perhaps it would be best to co-ordinate the R8A7793 and R8A7794
changes to avoid tedious conflicts.

> - fixed typo in the changelog.
> 
>  Documentation/devicetree/bindings/mmc/renesas,mmcif.txt |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> ===================================================================
> --- mmc.orig/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> +++ mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> @@ -10,6 +10,7 @@ Required properties:
>  	- "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
>  	- "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
>  	- "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
> +	- "renesas,mmcif-r8a7794" for the MMCIF found in r8a7794 SoCs
>    followed by "renesas,sh-mmcif".
>  
>  - clocks: reference to the functional clock
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov Aug. 12, 2015, 10:38 a.m. UTC | #2
Hello.

On 8/12/2015 3:59 AM, Simon Horman wrote:

>> Renesas R8A7794 SoC also has the MMCIF controller...

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> This new compat string looks good to me.

> Acked-by: Simon Horman <horms+renesas@verge.net.au>

    Thank you. I've messed up the subject, so need to re-post.

>> ---
>> The patch is against Ulf Hansson's 'mmc.git'  repo's 'next' branch plus the
>> patch I posted earlier today...
>>
>> Changes in version 2:
>> - deferred R8A7793 support to the patch posted earlier by Ulrich Hecht;

> Perhaps it would be best to co-ordinate the R8A7793 and R8A7794
> changes to avoid tedious conflicts.

    I thought about taking out Ulrich's binding patch and re-posting it along 
with this one but finally decided not to ruin his series. Do you mean that I 
should have posted his patch along with mine?

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Aug. 12, 2015, 11:59 p.m. UTC | #3
[CC: Ulrich, Geert]

On Wed, Aug 12, 2015 at 01:38:02PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 8/12/2015 3:59 AM, Simon Horman wrote:
> 
> >>Renesas R8A7794 SoC also has the MMCIF controller...
> 
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >This new compat string looks good to me.
> 
> >Acked-by: Simon Horman <horms+renesas@verge.net.au>
> 
>    Thank you. I've messed up the subject, so need to re-post.
> 
> >>---
> >>The patch is against Ulf Hansson's 'mmc.git'  repo's 'next' branch plus the
> >>patch I posted earlier today...
> >>
> >>Changes in version 2:
> >>- deferred R8A7793 support to the patch posted earlier by Ulrich Hecht;
> 
> >Perhaps it would be best to co-ordinate the R8A7793 and R8A7794
> >changes to avoid tedious conflicts.
> 
>    I thought about taking out Ulrich's binding patch and re-posting it
>    along with this one but finally decided not to ruin his series. Do you
>    mean that I should have posted his patch along with mine?

I mean we sould talk about this to come up with a plan that makes things
easy for the maintainer to pick up the compat strings for the R8A7793 and
R8A7794.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ulrich Hecht Aug. 13, 2015, 9:27 a.m. UTC | #4
On Wed, Aug 12, 2015 at 12:38 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>    I thought about taking out Ulrich's binding patch and re-posting it along
> with this one but finally decided not to ruin his series. Do you mean that I
> should have posted his patch along with mine?

I wouldn't mind that; anything that gets stuff picked up is a win.

CU
Uli
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

Index: mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
===================================================================
--- mmc.orig/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
+++ mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
@@ -10,6 +10,7 @@  Required properties:
 	- "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
 	- "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
 	- "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
+	- "renesas,mmcif-r8a7794" for the MMCIF found in r8a7794 SoCs
   followed by "renesas,sh-mmcif".
 
 - clocks: reference to the functional clock