diff mbox

[1/2] ARM: shmobile: r8a7778: enable IRLM setup via DT

Message ID 1439560388-5061-2-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive)
State Superseded
Delegated to: Simon Horman
Headers show

Commit Message

Ulrich Hecht Aug. 14, 2015, 1:53 p.m. UTC
Works the same as on r8a7779.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm/boot/dts/r8a7778.dtsi            | 3 ++-
 drivers/irqchip/irq-renesas-intc-irqpin.c | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

Comments

Geert Uytterhoeven Aug. 17, 2015, 9:44 a.m. UTC | #1
On Fri, Aug 14, 2015 at 3:53 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Works the same as on r8a7779.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  arch/arm/boot/dts/r8a7778.dtsi            | 3 ++-
>  drivers/irqchip/irq-renesas-intc-irqpin.c | 6 ++++--

I think this should be split in two separate patches.

For both, you can add my
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Aug. 17, 2015, 3 p.m. UTC | #2
On Mon, Aug 17, 2015 at 11:44:24AM +0200, Geert Uytterhoeven wrote:
> On Fri, Aug 14, 2015 at 3:53 PM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
> > Works the same as on r8a7779.
> >
> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Thanks Ulrich,

I'm very happy to see this series.

> > ---
> >  arch/arm/boot/dts/r8a7778.dtsi            | 3 ++-
> >  drivers/irqchip/irq-renesas-intc-irqpin.c | 6 ++++--
> 
> I think this should be split in two separate patches.

Agreed.

The .dtsi portion is a DT patch that should go through the ARM SoC tree
via my tree.

The .c portion is a driver change that should probably
be handled by Jason Cooper.

Ulrich, please let me know if you need any help moving this forwards.

> For both, you can add my
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
index 4b1fa9f..4b0acae23 100644
--- a/arch/arm/boot/dts/r8a7778.dtsi
+++ b/arch/arm/boot/dts/r8a7778.dtsi
@@ -78,7 +78,8 @@ 
 			<0xfe780010 4>,
 			<0xfe780024 4>,
 			<0xfe780044 4>,
-			<0xfe780064 4>;
+			<0xfe780064 4>,
+			<0xfe780000 4>;
 		interrupts =   <0 27 IRQ_TYPE_LEVEL_HIGH
 				0 28 IRQ_TYPE_LEVEL_HIGH
 				0 29 IRQ_TYPE_LEVEL_HIGH
diff --git a/drivers/irqchip/irq-renesas-intc-irqpin.c b/drivers/irqchip/irq-renesas-intc-irqpin.c
index 0670ab4..7f172a0 100644
--- a/drivers/irqchip/irq-renesas-intc-irqpin.c
+++ b/drivers/irqchip/irq-renesas-intc-irqpin.c
@@ -352,14 +352,16 @@  static const struct irq_domain_ops intc_irqpin_irq_domain_ops = {
 	.xlate  = irq_domain_xlate_twocell,
 };
 
-static const struct intc_irqpin_irlm_config intc_irqpin_irlm_r8a7779 = {
+static const struct intc_irqpin_irlm_config intc_irqpin_irlm_r8a777x = {
 	.irlm_bit = 23, /* ICR0.IRLM0 */
 };
 
 static const struct of_device_id intc_irqpin_dt_ids[] = {
 	{ .compatible = "renesas,intc-irqpin", },
+	{ .compatible = "renesas,intc-irqpin-r8a7778",
+	  .data = &intc_irqpin_irlm_r8a777x },
 	{ .compatible = "renesas,intc-irqpin-r8a7779",
-	  .data = &intc_irqpin_irlm_r8a7779 },
+	  .data = &intc_irqpin_irlm_r8a777x },
 	{},
 };
 MODULE_DEVICE_TABLE(of, intc_irqpin_dt_ids);