| Message ID | 55D25A4A.4070409@tul.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Petr Cvek <petr.cvek@tul.cz> writes:
> Fix PWM backlight regulator. It is requested from pwm_backlight_probe().
Even if I know why you have to fix it, somebody else reading your commit message
should understand why this fix is need. You need to explain why it is needed,
ie. what happens without it, and therefore what justifies this patch.
Cheers.
--
Robert
PS: For inspiration, look at Thierry's commit 902e6a0c7eba.
diff --git a/arch/arm/mach-pxa/magician.c b/arch/arm/mach-pxa/magician.c index d17125e..2ec630e 100644 --- a/arch/arm/mach-pxa/magician.c +++ b/arch/arm/mach-pxa/magician.c @@ -542,6 +542,14 @@ static struct platform_device pwm_backlight = { }; /* + * fixed regulator for pwm_backlight + */ + +static struct regulator_consumer_supply pwm_backlight_supply[] = { + REGULATOR_SUPPLY("power", "pwm_backlight"), +}; + +/* * LEDs */ @@ -1352,6 +1360,9 @@ static void __init magician_init(void) spi_register_board_info(ARRAY_AND_SIZE(ads7846_spi_board_info)); pxa_set_camera_info(&magician_pxacamera_pdata); + + regulator_register_always_on(0, "power", pwm_backlight_supply, + ARRAY_SIZE(pwm_backlight_supply), 5000000); } MACHINE_START(MAGICIAN, "HTC Magician")
Fix PWM backlight regulator. It is requested from pwm_backlight_probe(). Signed-off-by: Petr Cvek <petr.cvek@tul.cz> --- arch/arm/mach-pxa/magician.c | 11 +++++++++++ 1 file changed, 11 insertions(+)