diff mbox

ARM: shmobile: r8a7778: tidyup SSI resource region

Message ID 87oahx5c3a.wl%kuninori.morimoto.gx@renesas.com (mailing list archive)
State Superseded
Delegated to: Simon Horman
Headers show

Commit Message

Kuninori Morimoto Aug. 24, 2015, 8:27 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm/boot/dts/r8a7778.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Geert Uytterhoeven Aug. 24, 2015, 9:50 a.m. UTC | #1 
On Mon, Aug 24, 2015 at 10:27 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> --- a/arch/arm/boot/dts/r8a7778.dtsi
> +++ b/arch/arm/boot/dts/r8a7778.dtsi
> @@ -239,7 +239,7 @@
>                 #sound-dai-cells = <1>;
>                 compatible = "renesas,rcar_sound-r8a7778", "renesas,rcar_sound-gen1";
>                 reg =   <0xffd90000 0x1000>,    /* SRU */
> -                       <0xffd91000 0x1240>,    /* SSI */
> +                       <0xffd91000 0x270>,     /* SSI */

Why not 0x240?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto Aug. 24, 2015, 11:35 p.m. UTC | #2 
Hi Geert

> > --- a/arch/arm/boot/dts/r8a7778.dtsi
> > +++ b/arch/arm/boot/dts/r8a7778.dtsi
> > @@ -239,7 +239,7 @@
> >                 #sound-dai-cells = <1>;
> >                 compatible = "renesas,rcar_sound-r8a7778", "renesas,rcar_sound-gen1";
> >                 reg =   <0xffd90000 0x1000>,    /* SRU */
> > -                       <0xffd91000 0x1240>,    /* SSI */
> > +                       <0xffd91000 0x270>,     /* SSI */
> 
> Why not 0x240?

0x240 can't care channel 9
I forgot why it used 0x1240, not 0x1270

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Geert Uytterhoeven Aug. 25, 2015, 6:36 a.m. UTC | #3 
Hi Morimoto-san,

On Tue, Aug 25, 2015 at 1:35 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> > --- a/arch/arm/boot/dts/r8a7778.dtsi
>> > +++ b/arch/arm/boot/dts/r8a7778.dtsi
>> > @@ -239,7 +239,7 @@
>> >                 #sound-dai-cells = <1>;
>> >                 compatible = "renesas,rcar_sound-r8a7778", "renesas,rcar_sound-gen1";
>> >                 reg =   <0xffd90000 0x1000>,    /* SRU */
>> > -                       <0xffd91000 0x1240>,    /* SSI */
>> > +                       <0xffd91000 0x270>,     /* SSI */
>>
>> Why not 0x240?
>
> 0x240 can't care channel 9
> I forgot why it used 0x1240, not 0x1270

According to my documentation, r8a7778 has channels 0-8, r8a7779 has 0-9.
So I'd expect 0x240 on r8a7778, and 0x280 on r8a7779.

Still, 10 * 0x40 = 0x280, not 0x270.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto Aug. 25, 2015, 6:58 a.m. UTC | #4 
Hi Geert

> >> > --- a/arch/arm/boot/dts/r8a7778.dtsi
> >> > +++ b/arch/arm/boot/dts/r8a7778.dtsi
> >> > @@ -239,7 +239,7 @@
> >> >                 #sound-dai-cells = <1>;
> >> >                 compatible = "renesas,rcar_sound-r8a7778", "renesas,rcar_sound-gen1";
> >> >                 reg =   <0xffd90000 0x1000>,    /* SRU */
> >> > -                       <0xffd91000 0x1240>,    /* SSI */
> >> > +                       <0xffd91000 0x270>,     /* SSI */
> >>
> >> Why not 0x240?
> >
> > 0x240 can't care channel 9
> > I forgot why it used 0x1240, not 0x1270
> 
> According to my documentation, r8a7778 has channels 0-8, r8a7779 has 0-9.
> So I'd expect 0x240 on r8a7778, and 0x280 on r8a7779.
> 
> Still, 10 * 0x40 = 0x280, not 0x270.

Grr... my bad.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
index 4b1fa9f..b317ec8 100644
--- a/arch/arm/boot/dts/r8a7778.dtsi
+++ b/arch/arm/boot/dts/r8a7778.dtsi
@@ -239,7 +239,7 @@ 
 		#sound-dai-cells = <1>;
 		compatible = "renesas,rcar_sound-r8a7778", "renesas,rcar_sound-gen1";
 		reg =	<0xffd90000 0x1000>,	/* SRU */
-			<0xffd91000 0x1240>,	/* SSI */
+			<0xffd91000 0x270>,	/* SSI */
 			<0xfffe0000 0x24>;	/* ADG */
 		clocks = <&mstp3_clks R8A7778_CLK_SSI8>,
 			<&mstp3_clks R8A7778_CLK_SSI7>,