| Message ID | 1440690994-5978-1-git-send-email-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 27, 2015 at 8:56 AM, Rob Herring <robh@kernel.org> wrote: > Enable building all dtb files when COMPILE_TEST is enabled. The dtbs are > not really dependent on a platform being enabled or any other kernel > config, so for testing coverage it is convenient to build all of the > dtbs. > > This builds all dts files in the tree, not just targets listed. This > is simpler for arm64 which has a bunch of sub-dirs. > > Signed-off-by: Rob Herring <robh@kernel.org> > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > --- > I've had this on my todo list for a while. RFC for now as I want to do > the rest of the arches as well. I was originally thinking a new target > for this, but thanks to Olof for the COMPILE_TEST suggestion. > > Rob > > arch/arm/boot/dts/Makefile | 4 ++++ > arch/arm64/boot/dts/Makefile | 6 ++++++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 246473a..4968442a 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -712,5 +712,9 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \ > dtb-$(CONFIG_ARCH_ZX) += zx296702-ad1.dtb > endif > > +dtstree := $(srctree)/$(src) > + > +dtb-$(CONFIG_COMPILE_TEST) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts)) > + > always := $(dtb-y) > clean-files := *.dtb > diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile > index 38913be..9f19390 100644 > --- a/arch/arm64/boot/dts/Makefile > +++ b/arch/arm64/boot/dts/Makefile > @@ -11,3 +11,9 @@ dts-dirs += sprd > dts-dirs += xilinx > > subdir-y := $(dts-dirs) > + > +dtstree := $(srctree)/$(src) > + > +dtb-$(CONFIG_COMPILE_TEST) := $(patsubst $(dtstree)/%.dts,%.dtb, $(foreach d,$(dts-dirs), $(wildcard $(dtstree)/$(d)/*.dts))) I think it would be more appropriate to build dtb-n here instead of _any_ file ending in dts. It would be useful to build all files, but it's not the behavior that COMPILE_TEST usually has. -Olof
On Thu, Aug 27, 2015 at 11:08 AM, Olof Johansson <olof@lixom.net> wrote: > On Thu, Aug 27, 2015 at 8:56 AM, Rob Herring <robh@kernel.org> wrote: >> Enable building all dtb files when COMPILE_TEST is enabled. The dtbs are >> not really dependent on a platform being enabled or any other kernel >> config, so for testing coverage it is convenient to build all of the >> dtbs. >> >> This builds all dts files in the tree, not just targets listed. This >> is simpler for arm64 which has a bunch of sub-dirs. >> >> Signed-off-by: Rob Herring <robh@kernel.org> >> Cc: Russell King <linux@arm.linux.org.uk> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> Cc: Will Deacon <will.deacon@arm.com> >> --- >> I've had this on my todo list for a while. RFC for now as I want to do >> the rest of the arches as well. I was originally thinking a new target >> for this, but thanks to Olof for the COMPILE_TEST suggestion. >> >> Rob >> >> arch/arm/boot/dts/Makefile | 4 ++++ >> arch/arm64/boot/dts/Makefile | 6 ++++++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 246473a..4968442a 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -712,5 +712,9 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \ >> dtb-$(CONFIG_ARCH_ZX) += zx296702-ad1.dtb >> endif >> >> +dtstree := $(srctree)/$(src) >> + >> +dtb-$(CONFIG_COMPILE_TEST) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts)) >> + >> always := $(dtb-y) >> clean-files := *.dtb >> diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile >> index 38913be..9f19390 100644 >> --- a/arch/arm64/boot/dts/Makefile >> +++ b/arch/arm64/boot/dts/Makefile >> @@ -11,3 +11,9 @@ dts-dirs += sprd >> dts-dirs += xilinx >> >> subdir-y := $(dts-dirs) >> + >> +dtstree := $(srctree)/$(src) >> + >> +dtb-$(CONFIG_COMPILE_TEST) := $(patsubst $(dtstree)/%.dts,%.dtb, $(foreach d,$(dts-dirs), $(wildcard $(dtstree)/$(d)/*.dts))) > > I think it would be more appropriate to build dtb-n here instead of > _any_ file ending in dts. The problem is here dtb-n is NULL. We have to add this into every sub-dir. Not a big deal to do, but my concern was remembering to it for new ones. Then again, most people are good at mindlessly copy-pasting so maybe that won't be a problem. :) > It would be useful to build all files, but it's not the behavior that > COMPILE_TEST usually has. Just changing to dtb-n would be equivalent because there is no other dependency to enable building. Code has other dependencies typically. What dtb do we not want to built in an allyesconfig build? If dtb's have any dependencies, that would be a bug. To really make this equivalent to a driver using COMPILE_TEST, we would need kconfig symbols specifically for each platform's dtbs. Then we would have the 2 stage unhide (setting COMPILE_TEST) then enable the option. I was also thinking that perhaps we don't want to require a kconfig symbol for every platform family. Adding a kconfig entry is the only way to enable building a dtb ATM. I know there are 2 camps to this policy though. Rob
Hi Rob, On Thu, Aug 27, 2015 at 9:07 PM, Rob Herring <robh@kernel.org> wrote: >> It would be useful to build all files, but it's not the behavior that >> COMPILE_TEST usually has. > > Just changing to dtb-n would be equivalent because there is no other > dependency to enable building. Code has other dependencies typically. > What dtb do we not want to built in an allyesconfig build? If dtb's > have any dependencies, that would be a bug. To really make this > equivalent to a driver using COMPILE_TEST, we would need kconfig > symbols specifically for each platform's dtbs. Then we would have the > 2 stage unhide (setting COMPILE_TEST) then enable the option. > > I was also thinking that perhaps we don't want to require a kconfig > symbol for every platform family. Adding a kconfig entry is the only > way to enable building a dtb ATM. I know there are 2 camps to this > policy though. I think it would be good to have a single Kconfig option (depending on COMPILE_TEST) to build all dtbs. For drivers, COMPILE_TEST doesn't enable anything by itself, it just relaxes dependencies. Hence if any driver is broken, I can still disable that driver in the .config. If any dtb is broken, I cannot disable it, except by disabling COMPILE_TEST, which I may not want to do for other reasons (e.g. I'm compile testing my driver). If there would be an extra Kconfig symbol for building all dtbs, I can still disable it. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 246473a..4968442a 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -712,5 +712,9 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \ dtb-$(CONFIG_ARCH_ZX) += zx296702-ad1.dtb endif +dtstree := $(srctree)/$(src) + +dtb-$(CONFIG_COMPILE_TEST) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts)) + always := $(dtb-y) clean-files := *.dtb diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile index 38913be..9f19390 100644 --- a/arch/arm64/boot/dts/Makefile +++ b/arch/arm64/boot/dts/Makefile @@ -11,3 +11,9 @@ dts-dirs += sprd dts-dirs += xilinx subdir-y := $(dts-dirs) + +dtstree := $(srctree)/$(src) + +dtb-$(CONFIG_COMPILE_TEST) := $(patsubst $(dtstree)/%.dts,%.dtb, $(foreach d,$(dts-dirs), $(wildcard $(dtstree)/$(d)/*.dts))) + +always := $(dtb-y)
Enable building all dtb files when COMPILE_TEST is enabled. The dtbs are not really dependent on a platform being enabled or any other kernel config, so for testing coverage it is convenient to build all of the dtbs. This builds all dts files in the tree, not just targets listed. This is simpler for arm64 which has a bunch of sub-dirs. Signed-off-by: Rob Herring <robh@kernel.org> Cc: Russell King <linux@arm.linux.org.uk> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> --- I've had this on my todo list for a while. RFC for now as I want to do the rest of the arches as well. I was originally thinking a new target for this, but thanks to Olof for the COMPILE_TEST suggestion. Rob arch/arm/boot/dts/Makefile | 4 ++++ arch/arm64/boot/dts/Makefile | 6 ++++++ 2 files changed, 10 insertions(+)