| Message ID | 1440667450-3513-6-git-send-email-horms+renesas@verge.net.au (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
On 8/27/2015 12:24 PM, Simon Horman wrote: > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > [horms: updated p_clk to s3d4_clk; moved to clock node; updated changelog; > use R8A7795 as prefix for clock defines] > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 11 +++++++++++ > include/dt-bindings/clock/r8a7795-clock.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > index a608eb92a172..0b435d8274e4 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > @@ -227,6 +227,16 @@ > clock-output-names = "hsusb", "ehci0", "ehci1", "ehci2"; > }; > > + mstp8_clks: mstp8_clks@e6150990 { > + compatible = "renesas,r8a7795-mstp-clocks", > + "renesas,cpg-mstp-clocks"; > + reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>; > + clocks = <&s3d4_clk>; > + #clock-cells = <1>; > + renesas,clock-indices = <R8A7795_CLK_AVB>; I thought there is standard generic property for that now, no? > + clock-output-names = "avb"; > + }; > + > mstp9_clks: mstp9_clks@e6150994 { > compatible = "renesas,r8a7795-mstp-clocks", > "renesas,cpg-mstp-clocks"; > @@ -352,4 +362,5 @@ > status = "disabled"; > }; > }; > + > }; Stray newline? [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon, Mizuguchi-san, On Thu, Aug 27, 2015 at 11:24 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > [horms: updated p_clk to s3d4_clk; moved to clock node; updated changelog; > use R8A7795 as prefix for clock defines] > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 11 +++++++++++ > include/dt-bindings/clock/r8a7795-clock.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > index a608eb92a172..0b435d8274e4 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > @@ -227,6 +227,16 @@ > clock-output-names = "hsusb", "ehci0", "ehci1", "ehci2"; > }; > > + mstp8_clks: mstp8_clks@e6150990 { > + compatible = "renesas,r8a7795-mstp-clocks", > + "renesas,cpg-mstp-clocks"; > + reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>; > + clocks = <&s3d4_clk>; According to the datasheet, this should be s3d2 on H3. > + #clock-cells = <1>; > + renesas,clock-indices = <R8A7795_CLK_AVB>; The datasheet calls this "EAVB-IF", so I'd go for "R8A7795_CLK_EAVB". > + clock-output-names = "avb"; > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > [horms: updated p_clk to s3d4_clk; moved to clock node; updated changelog; > use R8A7795 as prefix for clock defines] > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 11 +++++++++++ > include/dt-bindings/clock/r8a7795-clock.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > index a608eb92a172..0b435d8274e4 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > @@ -227,6 +227,16 @@ > clock-output-names = "hsusb", "ehci0", "ehci1", "ehci2"; > }; > > + mstp8_clks: mstp8_clks@e6150990 { > + compatible = "renesas,r8a7795-mstp-clocks", > + "renesas,cpg-mstp-clocks"; > + reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>; > + clocks = <&s3d4_clk>; > + #clock-cells = <1>; > + renesas,clock-indices = <R8A7795_CLK_AVB>; Maybe this is my v7 fault, but we need to use "clock-indices" instead of "renesas,clock-indices". I will fix these in next v8 -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Aug 27, 2015 at 01:44:54PM +0300, Sergei Shtylyov wrote: > On 8/27/2015 12:24 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > > >Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > >[horms: updated p_clk to s3d4_clk; moved to clock node; updated changelog; > > use R8A7795 as prefix for clock defines] > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >--- > > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 11 +++++++++++ > > include/dt-bindings/clock/r8a7795-clock.h | 1 + > > 2 files changed, 12 insertions(+) > > > >diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > >index a608eb92a172..0b435d8274e4 100644 > >--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > >+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > >@@ -227,6 +227,16 @@ > > clock-output-names = "hsusb", "ehci0", "ehci1", "ehci2"; > > }; > > > >+ mstp8_clks: mstp8_clks@e6150990 { > >+ compatible = "renesas,r8a7795-mstp-clocks", > >+ "renesas,cpg-mstp-clocks"; > >+ reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>; > >+ clocks = <&s3d4_clk>; > >+ #clock-cells = <1>; > >+ renesas,clock-indices = <R8A7795_CLK_AVB>; > > I thought there is standard generic property for that now, no? Thanks, I will update the patch to use clock-indices. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Aug 27, 2015 at 11:47:33PM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > [horms: updated p_clk to s3d4_clk; moved to clock node; updated changelog; > > use R8A7795 as prefix for clock defines] > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 11 +++++++++++ > > include/dt-bindings/clock/r8a7795-clock.h | 1 + > > 2 files changed, 12 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > index a608eb92a172..0b435d8274e4 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > @@ -227,6 +227,16 @@ > > clock-output-names = "hsusb", "ehci0", "ehci1", "ehci2"; > > }; > > > > + mstp8_clks: mstp8_clks@e6150990 { > > + compatible = "renesas,r8a7795-mstp-clocks", > > + "renesas,cpg-mstp-clocks"; > > + reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>; > > + clocks = <&s3d4_clk>; > > + #clock-cells = <1>; > > + renesas,clock-indices = <R8A7795_CLK_AVB>; > > Maybe this is my v7 fault, but we need to use "clock-indices" instead of "renesas,clock-indices". > I will fix these in next v8 Thanks, it looks like we both have some updates to make. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 28, 2015 at 1:47 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > Maybe this is my v7 fault, but we need to use "clock-indices" instead of "renesas,clock-indices". > I will fix these in next v8 Woops, and we kept on copying that ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Aug 27, 2015 at 01:11:02PM +0200, Geert Uytterhoeven wrote: > Hi Simon, Mizuguchi-san, > > On Thu, Aug 27, 2015 at 11:24 AM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > [horms: updated p_clk to s3d4_clk; moved to clock node; updated changelog; > > use R8A7795 as prefix for clock defines] > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 11 +++++++++++ > > include/dt-bindings/clock/r8a7795-clock.h | 1 + > > 2 files changed, 12 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > index a608eb92a172..0b435d8274e4 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > @@ -227,6 +227,16 @@ > > clock-output-names = "hsusb", "ehci0", "ehci1", "ehci2"; > > }; > > > > + mstp8_clks: mstp8_clks@e6150990 { > > + compatible = "renesas,r8a7795-mstp-clocks", > > + "renesas,cpg-mstp-clocks"; > > + reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>; > > + clocks = <&s3d4_clk>; > > According to the datasheet, this should be s3d2 on H3. Thanks. > > + #clock-cells = <1>; > > + renesas,clock-indices = <R8A7795_CLK_AVB>; > > The datasheet calls this "EAVB-IF", so I'd go for "R8A7795_CLK_EAVB". I plan to go with with R8A7795_CLK_ETHERAVB for consistency with the r8a7790. > > > + clock-output-names = "avb"; > > + }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index a608eb92a172..0b435d8274e4 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi @@ -227,6 +227,16 @@ clock-output-names = "hsusb", "ehci0", "ehci1", "ehci2"; }; + mstp8_clks: mstp8_clks@e6150990 { + compatible = "renesas,r8a7795-mstp-clocks", + "renesas,cpg-mstp-clocks"; + reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>; + clocks = <&s3d4_clk>; + #clock-cells = <1>; + renesas,clock-indices = <R8A7795_CLK_AVB>; + clock-output-names = "avb"; + }; + mstp9_clks: mstp9_clks@e6150994 { compatible = "renesas,r8a7795-mstp-clocks", "renesas,cpg-mstp-clocks"; @@ -352,4 +362,5 @@ status = "disabled"; }; }; + }; diff --git a/include/dt-bindings/clock/r8a7795-clock.h b/include/dt-bindings/clock/r8a7795-clock.h index 5ca06876902f..8c00b635de2d 100644 --- a/include/dt-bindings/clock/r8a7795-clock.h +++ b/include/dt-bindings/clock/r8a7795-clock.h @@ -35,6 +35,7 @@ #define R8A7795_CLK_EHCI2 1 /* MSTP8 */ +#define R8A7795_CLK_AVB 12 /* MSTP9 */ #define R8A7795_CLK_GPIO0 12