| Message ID | 20150831063003.24004.42127.sendpatchset@little-apple (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Magnus and Morimoto-san, Thank you for the patch. On Monday 31 August 2015 15:30:03 Magnus Damm wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Add a PFC node for the on-chip r8a7795 pin controller. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > Signed-off-by: Magnus Damm <damm+renesas@opensource.se> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > > Based on: > [PATCH 10/25 v7][RFC] arm64: renesas: r8a7795: enable PFC > > Changes: (Magnus Damm <damm+renesas@opensource.se>) > - Added changelog > > TODO: > - Add Kconfig select bits Do they belong to this patch ? > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > --- 0012/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ work/arch/arm64/boot/dts/renesas/r8a7795.dtsi 2015-08-29 > 15:38:44.152366518 +0900 @@ -278,6 +278,11 @@ > }; > }; > > + pfc: pfc@e6060000 { > + compatible = "renesas,pfc-r8a7795"; > + reg = <0 0xe6060000 0 0x50c>; > + }; > + > dmac0: dma-controller@e6700000 { > /* Empty node for now */ > };
Hi Laurent, On Mon, Aug 31, 2015 at 7:41 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi Magnus and Morimoto-san, > > Thank you for the patch. > > On Monday 31 August 2015 15:30:03 Magnus Damm wrote: >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> >> Add a PFC node for the on-chip r8a7795 pin controller. >> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> >> Signed-off-by: Magnus Damm <damm+renesas@opensource.se> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks! >> --- >> >> Based on: >> [PATCH 10/25 v7][RFC] arm64: renesas: r8a7795: enable PFC >> >> Changes: (Magnus Damm <damm+renesas@opensource.se>) >> - Added changelog >> >> TODO: >> - Add Kconfig select bits > > Do they belong to this patch ? I think they are A) related (DTS patch and Kconfig needed for runtime functionality) B) enabled in the same subsystem (under arch/arm64) So because of that I feel it makes sense to keep them together. At the same time, Geert asked me to split the following patch: [PATCH v8 01/07] arm64: renesas: r8a7795: Add Renesas R8A7795 SoC support So based on that both you and Geert prefer to separate the Kconfig bits then I'll go with that way. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- 0012/arch/arm64/boot/dts/renesas/r8a7795.dtsi +++ work/arch/arm64/boot/dts/renesas/r8a7795.dtsi 2015-08-29 15:38:44.152366518 +0900 @@ -278,6 +278,11 @@ }; }; + pfc: pfc@e6060000 { + compatible = "renesas,pfc-r8a7795"; + reg = <0 0xe6060000 0 0x50c>; + }; + dmac0: dma-controller@e6700000 { /* Empty node for now */ };