| Message ID | 1441231834-12873-1-git-send-email-drake@endlessm.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
On Wed, Sep 02, 2015 at 04:10:34PM -0600, Daniel Drake wrote: > These laptops boot with wifi as hard-blocked, with no obvious way to > enable it. Using a quirk to set wapf=4 solves the problem. > > Signed-off-by: Daniel Drake <drake@endlessm.com> Looks good. Corentin, any concerns? > --- > drivers/platform/x86/asus-nb-wmi.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c > index abdaed3..131fee2 100644 > --- a/drivers/platform/x86/asus-nb-wmi.c > +++ b/drivers/platform/x86/asus-nb-wmi.c > @@ -128,6 +128,24 @@ static const struct dmi_system_id asus_quirks[] = { > }, > { > .callback = dmi_matched, > + .ident = "ASUSTeK COMPUTER INC. X456UA", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > + DMI_MATCH(DMI_PRODUCT_NAME, "X456UA"), > + }, > + .driver_data = &quirk_asus_wapf4, > + }, > + { > + .callback = dmi_matched, > + .ident = "ASUSTeK COMPUTER INC. X456UF", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > + DMI_MATCH(DMI_PRODUCT_NAME, "X456UF"), > + }, > + .driver_data = &quirk_asus_wapf4, > + }, > + { > + .callback = dmi_matched, > .ident = "ASUSTeK COMPUTER INC. X501U", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > -- > 2.1.4 > >
Looks good. Acked-by: Corentin Chary <corentin.chary@gmail.com> I'd like to get somebody from Asus help us guess these values instead of just hard-coding them.. Unfortunately I have no contact with them anymore. On Fri, Sep 4, 2015 at 12:54 AM, Darren Hart <dvhart@infradead.org> wrote: > On Wed, Sep 02, 2015 at 04:10:34PM -0600, Daniel Drake wrote: >> These laptops boot with wifi as hard-blocked, with no obvious way to >> enable it. Using a quirk to set wapf=4 solves the problem. >> >> Signed-off-by: Daniel Drake <drake@endlessm.com> > > Looks good. > > Corentin, any concerns? > >> --- >> drivers/platform/x86/asus-nb-wmi.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c >> index abdaed3..131fee2 100644 >> --- a/drivers/platform/x86/asus-nb-wmi.c >> +++ b/drivers/platform/x86/asus-nb-wmi.c >> @@ -128,6 +128,24 @@ static const struct dmi_system_id asus_quirks[] = { >> }, >> { >> .callback = dmi_matched, >> + .ident = "ASUSTeK COMPUTER INC. X456UA", >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), >> + DMI_MATCH(DMI_PRODUCT_NAME, "X456UA"), >> + }, >> + .driver_data = &quirk_asus_wapf4, >> + }, >> + { >> + .callback = dmi_matched, >> + .ident = "ASUSTeK COMPUTER INC. X456UF", >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), >> + DMI_MATCH(DMI_PRODUCT_NAME, "X456UF"), >> + }, >> + .driver_data = &quirk_asus_wapf4, >> + }, >> + { >> + .callback = dmi_matched, >> .ident = "ASUSTeK COMPUTER INC. X501U", >> .matches = { >> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), >> -- >> 2.1.4 >> >> > > -- > Darren Hart > Intel Open Source Technology Center
On Sun, Sep 06, 2015 at 10:40:05AM +0200, Corentin Chary wrote: > Looks good. > > Acked-by: Corentin Chary <corentin.chary@gmail.com> Thanks, queued for testing. Should make 4.3.
On Sun, Sep 6, 2015 at 2:40 AM, Corentin Chary <corentin.chary@gmail.com> wrote: > Looks good. > > Acked-by: Corentin Chary <corentin.chary@gmail.com> > > I'd like to get somebody from Asus help us guess these values instead > of just hard-coding them.. Unfortunately I have no contact with them > anymore. I'll see if I can get a conversation going. I don't fully grasp this WAPF situation though. Are you hoping that they would provide us with a complete list of laptops to quirk, or do you think there is instead some way we could improve the code to work with all models without a specific whitelist/blacklist? Thanks Daniel -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Sep 7, 2015 at 3:55 PM, Daniel Drake <drake@endlessm.com> wrote: > On Sun, Sep 6, 2015 at 2:40 AM, Corentin Chary <corentin.chary@gmail.com> wrote: >> Looks good. >> >> Acked-by: Corentin Chary <corentin.chary@gmail.com> >> >> I'd like to get somebody from Asus help us guess these values instead >> of just hard-coding them.. Unfortunately I have no contact with them >> anymore. > > I'll see if I can get a conversation going. I don't fully grasp this > WAPF situation though. Are you hoping that they would provide us with > a complete list of laptops to quirk, or do you think there is instead > some way we could improve the code to work with all models without a > specific whitelist/blacklist? I think at least having proper documentation of the intended behavior of WAPF and how they themselves set the value for windows would be great. > Thanks > Daniel
diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index abdaed3..131fee2 100644 --- a/drivers/platform/x86/asus-nb-wmi.c +++ b/drivers/platform/x86/asus-nb-wmi.c @@ -128,6 +128,24 @@ static const struct dmi_system_id asus_quirks[] = { }, { .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. X456UA", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "X456UA"), + }, + .driver_data = &quirk_asus_wapf4, + }, + { + .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. X456UF", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "X456UF"), + }, + .driver_data = &quirk_asus_wapf4, + }, + { + .callback = dmi_matched, .ident = "ASUSTeK COMPUTER INC. X501U", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
These laptops boot with wifi as hard-blocked, with no obvious way to enable it. Using a quirk to set wapf=4 solves the problem. Signed-off-by: Daniel Drake <drake@endlessm.com> --- drivers/platform/x86/asus-nb-wmi.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)