| Message ID | 1441624721-15612-3-git-send-email-vaibhav.hiremath@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/07/2015 06:18 AM, Vaibhav Hiremath wrote: > With support for pxa1928 family of devices , this patch > updates the binding document with compatible property > of "marvell,pxav3-1928-sdhci". > > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> > --- > Documentation/devicetree/bindings/mmc/sdhci-pxa.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt b/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt > index 3d1b449..29edcf5 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt > +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt > @@ -5,7 +5,7 @@ and the properties used by the sdhci-pxav2 and sdhci-pxav3 drivers. > > Required properties: > - compatible: Should be "mrvl,pxav2-mmc", "mrvl,pxav3-mmc" or > - "marvell,armada-380-sdhci". > + "marvell,armada-380-sdhci" or "marvell,pxav3-1928-sdhci". v3 is implied by pxa1928. So I'd just do "marvell,pxa1928-sdhci" to better match the chip name. Rob > - reg: > * for "mrvl,pxav2-mmc" and "mrvl,pxav3-mmc", one register area for > the SDHCI registers. >
On Wednesday 09 September 2015 05:19 AM, Rob Herring wrote: > On 09/07/2015 06:18 AM, Vaibhav Hiremath wrote: >> With support for pxa1928 family of devices , this patch >> updates the binding document with compatible property >> of "marvell,pxav3-1928-sdhci". >> >> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> >> --- >> Documentation/devicetree/bindings/mmc/sdhci-pxa.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt b/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt >> index 3d1b449..29edcf5 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt >> @@ -5,7 +5,7 @@ and the properties used by the sdhci-pxav2 and sdhci-pxav3 drivers. >> >> Required properties: >> - compatible: Should be "mrvl,pxav2-mmc", "mrvl,pxav3-mmc" or >> - "marvell,armada-380-sdhci". >> + "marvell,armada-380-sdhci" or "marvell,pxav3-1928-sdhci". > > v3 is implied by pxa1928. So I'd just do "marvell,pxa1928-sdhci" to > better match the chip name. > Ok, No issues. I followed the existing "armada-380-sdhci" naming style. Will correct it in next version. Thanks, Vaibhav
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt b/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt index 3d1b449..29edcf5 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt @@ -5,7 +5,7 @@ and the properties used by the sdhci-pxav2 and sdhci-pxav3 drivers. Required properties: - compatible: Should be "mrvl,pxav2-mmc", "mrvl,pxav3-mmc" or - "marvell,armada-380-sdhci". + "marvell,armada-380-sdhci" or "marvell,pxav3-1928-sdhci". - reg: * for "mrvl,pxav2-mmc" and "mrvl,pxav3-mmc", one register area for the SDHCI registers.
With support for pxa1928 family of devices , this patch updates the binding document with compatible property of "marvell,pxav3-1928-sdhci". Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> --- Documentation/devicetree/bindings/mmc/sdhci-pxa.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)