| Message ID | fca26d7ecb73e9691da4ee85e7e5bd8462638752.1441897573.git.nicolas.ferre@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote : > From: Josh Wu <josh.wu@atmel.com> > > Correct the led labels in at91sam9n12ek. > > Signed-off-by: Josh Wu <josh.wu@atmel.com> > --- > arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts > index efa75064d38a..186a1705f8d3 100644 > --- a/arch/arm/boot/dts/at91sam9n12ek.dts > +++ b/arch/arm/boot/dts/at91sam9n12ek.dts > @@ -204,13 +204,13 @@ > }; > > d9 { > - label = "d6"; > + label = "d9"; > gpios = <&pioB 5 GPIO_ACTIVE_LOW>; > linux,default-trigger = "nand-disk"; > }; > > d10 { > - label = "d7"; > + label = "d10"; > gpios = <&pioB 6 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > }; The only concern being that this renaming will break userspace software assuming the LEDs are wrongly named. Is there anything that has been released by atmel that uses the wrong names (and my guess is yess and that is why there are named as such) and do you care about it?
Le 10/09/2015 17:24, Alexandre Belloni a écrit : > Hi, > > On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote : >> From: Josh Wu <josh.wu@atmel.com> >> >> Correct the led labels in at91sam9n12ek. >> >> Signed-off-by: Josh Wu <josh.wu@atmel.com> >> --- >> arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts >> index efa75064d38a..186a1705f8d3 100644 >> --- a/arch/arm/boot/dts/at91sam9n12ek.dts >> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts >> @@ -204,13 +204,13 @@ >> }; >> >> d9 { >> - label = "d6"; >> + label = "d9"; >> gpios = <&pioB 5 GPIO_ACTIVE_LOW>; >> linux,default-trigger = "nand-disk"; >> }; >> >> d10 { >> - label = "d7"; >> + label = "d10"; >> gpios = <&pioB 6 GPIO_ACTIVE_HIGH>; >> linux,default-trigger = "heartbeat"; >> }; > > The only concern being that this renaming will break userspace software > assuming the LEDs are wrongly named. Is there anything that has been > released by atmel that uses the wrong names (and my guess is yess and > that is why there are named as such) and do you care about it? My guess is that the label was wrongly named from the beginning and no board revision had the "d6" nor "d7" names. It makes sense to rename them for the evaluation kit... Bye,
Hi, On 18/09/2015 at 15:46:33 +0200, Nicolas Ferre wrote : > > The only concern being that this renaming will break userspace software > > assuming the LEDs are wrongly named. Is there anything that has been > > released by atmel that uses the wrong names (and my guess is yess and > > that is why there are named as such) and do you care about it? > > My guess is that the label was wrongly named from the beginning and no > board revision had the "d6" nor "d7" names. > It makes sense to rename them for the evaluation kit... > Yeah, I'm fine with the change. I was simply warning that it may break some demos Atmel distributed before (but I didn't ever seen or used those anyway so I may be wrong).
diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts index efa75064d38a..186a1705f8d3 100644 --- a/arch/arm/boot/dts/at91sam9n12ek.dts +++ b/arch/arm/boot/dts/at91sam9n12ek.dts @@ -204,13 +204,13 @@ }; d9 { - label = "d6"; + label = "d9"; gpios = <&pioB 5 GPIO_ACTIVE_LOW>; linux,default-trigger = "nand-disk"; }; d10 { - label = "d7"; + label = "d10"; gpios = <&pioB 6 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };