diff mbox

[v2,1/2] staging: wilc1000: remove unused enum

Message ID 1441940660-5925-2-git-send-email-tony.cho@atmel.com (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show

Commit Message

Tony Cho Sept. 11, 2015, 3:04 a.m. UTC
From: Glen Lee <glen.lee@atmel.com>

This patch removes a unused enum tenuFrameClass.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
---
 drivers/staging/wilc1000/coreconfigurator.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Greg KH Sept. 12, 2015, 2:35 a.m. UTC | #1
On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote:
> From: Glen Lee <glen.lee@atmel.com>
> 
> This patch removes a unused enum tenuFrameClass.
> 
> Signed-off-by: Glen Lee <glen.lee@atmel.com>
> Signed-off-by: Tony Cho <tony.cho@atmel.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 8 --------
>  1 file changed, 8 deletions(-)

I already applied this, why resend it?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Cho Sept. 14, 2015, 1:29 a.m. UTC | #2
On 2015? 09? 12? 11:35, Greg KH wrote:
> On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote:
>> From: Glen Lee <glen.lee@atmel.com>
>>
>> This patch removes a unused enum tenuFrameClass.
>>
>> Signed-off-by: Glen Lee <glen.lee@atmel.com>
>> Signed-off-by: Tony Cho <tony.cho@atmel.com>
>> ---
>>   drivers/staging/wilc1000/coreconfigurator.c | 8 --------
>>   1 file changed, 8 deletions(-)
> I already applied this, why resend it?
>
> greg k-h

This is one of series for the "[PATCH v2 2/2] staging: wilc1000: coreconfigurator.c: remove unused function".
That's why it was sent to you.

Thanks,
Tony.



--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg KH Sept. 14, 2015, 4:25 a.m. UTC | #3
On Mon, Sep 14, 2015 at 10:29:26AM +0900, Tony Cho wrote:
> 
> 
> On 2015? 09? 12? 11:35, Greg KH wrote:
> >On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote:
> >>From: Glen Lee <glen.lee@atmel.com>
> >>
> >>This patch removes a unused enum tenuFrameClass.
> >>
> >>Signed-off-by: Glen Lee <glen.lee@atmel.com>
> >>Signed-off-by: Tony Cho <tony.cho@atmel.com>
> >>---
> >>  drivers/staging/wilc1000/coreconfigurator.c | 8 --------
> >>  1 file changed, 8 deletions(-)
> >I already applied this, why resend it?
> >
> >greg k-h
> 
> This is one of series for the "[PATCH v2 2/2] staging: wilc1000: coreconfigurator.c: remove unused function".
> That's why it was sent to you.

But you sent it as a part of a different series, why do that?

When you do a v2 patch, please be specific, resend the whole series.
Otherwise how am I supposed to know what to do?  Remember, I get
hundreds of patches to review and handle every day, you need to be very
obvious as to what I need to do otherwise I will get it wrong :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Cho Sept. 14, 2015, 4:37 a.m. UTC | #4
On 2015? 09? 14? 13:25, Greg KH wrote:
> On Mon, Sep 14, 2015 at 10:29:26AM +0900, Tony Cho wrote:
>>
>> On 2015? 09? 12? 11:35, Greg KH wrote:
>>> On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote:
>>>> From: Glen Lee <glen.lee@atmel.com>
>>>>
>>>> This patch removes a unused enum tenuFrameClass.
>>>>
>>>> Signed-off-by: Glen Lee <glen.lee@atmel.com>
>>>> Signed-off-by: Tony Cho <tony.cho@atmel.com>
>>>> ---
>>>>   drivers/staging/wilc1000/coreconfigurator.c | 8 --------
>>>>   1 file changed, 8 deletions(-)
>>> I already applied this, why resend it?
>>>
>>> greg k-h
>> This is one of series for the "[PATCH v2 2/2] staging: wilc1000: coreconfigurator.c: remove unused function".
>> That's why it was sent to you.
> But you sent it as a part of a different series, why do that?
>
> When you do a v2 patch, please be specific, resend the whole series.
> Otherwise how am I supposed to know what to do?  Remember, I get
> hundreds of patches to review and handle every day, you need to be very
> obvious as to what I need to do otherwise I will get it wrong :)
>
> greg k-h

Understood. I will keep it in my mind to be more obvious.

Thanks,

Tony.


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 58e6108..450c3ff 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -88,14 +88,6 @@  typedef enum {
 	FRAME_SUBTYPE_FORCE_32BIT  = 0xFFFFFFFF
 } tenuFrmSubtype;
 
-/* Basic Frame Classes */
-typedef enum {
-	CLASS1_FRAME_TYPE      = 0x00,
-	CLASS2_FRAME_TYPE      = 0x01,
-	CLASS3_FRAME_TYPE      = 0x02,
-	FRAME_CLASS_FORCE_32BIT  = 0xFFFFFFFF
-} tenuFrameClass;
-
 /* Element ID  of various Information Elements */
 typedef enum {
 	ISSID               = 0,   /* Service Set Identifier         */