| Message ID | 1441858273-4017-16-git-send-email-edubezval@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Eduardo Valentin |
| Headers | show |
On Wed, 09 Sep 2015, Eduardo Valentin wrote: > Adding COMPILE_TEST flag to st driver to facilitate > maintenance. > > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Nicolas Boichat <drinkcat@chromium.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Fabian Frederick <fabf@skynet.be> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin <edubezval@gmail.com> > --- > drivers/thermal/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Sounds reasonable. So long as it's been tested and nothing breaks: Acked-by: Lee Jones <lee.jones@linaro.org> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 9069cc7..d94b4e9 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -350,7 +350,7 @@ source "drivers/thermal/samsung/Kconfig" > endmenu > > menu "STMicroelectronics thermal drivers" > -depends on ARCH_STI && OF > +depends on (ARCH_STI || COMPILE_TEST) && OF > source "drivers/thermal/st/Kconfig" > endmenu >
On Fri, Sep 11, 2015 at 10:23:35AM +0100, Lee Jones wrote: > On Wed, 09 Sep 2015, Eduardo Valentin wrote: > > > Adding COMPILE_TEST flag to st driver to facilitate > > maintenance. > > > > Cc: Zhang Rui <rui.zhang@intel.com> > > Cc: Nicolas Boichat <drinkcat@chromium.org> > > Cc: Mark Brown <broonie@kernel.org> > > Cc: Fabian Frederick <fabf@skynet.be> > > Cc: Wolfram Sang <wsa@the-dreams.de> > > Cc: Lee Jones <lee.jones@linaro.org> > > Cc: linux-pm@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Eduardo Valentin <edubezval@gmail.com> > > --- > > drivers/thermal/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Sounds reasonable. > > So long as it's been tested and nothing breaks: > > Acked-by: Lee Jones <lee.jones@linaro.org> Thanks for the review. But now checking the compilation test using bfin as target, I see several compilation issues. So, I am leaving this one out for now. It requires further changes. BR, > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index 9069cc7..d94b4e9 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -350,7 +350,7 @@ source "drivers/thermal/samsung/Kconfig" > > endmenu > > > > menu "STMicroelectronics thermal drivers" > > -depends on ARCH_STI && OF > > +depends on (ARCH_STI || COMPILE_TEST) && OF > > source "drivers/thermal/st/Kconfig" > > endmenu > > > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org ? Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 9069cc7..d94b4e9 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -350,7 +350,7 @@ source "drivers/thermal/samsung/Kconfig" endmenu menu "STMicroelectronics thermal drivers" -depends on ARCH_STI && OF +depends on (ARCH_STI || COMPILE_TEST) && OF source "drivers/thermal/st/Kconfig" endmenu
Adding COMPILE_TEST flag to st driver to facilitate maintenance. Cc: Zhang Rui <rui.zhang@intel.com> Cc: Nicolas Boichat <drinkcat@chromium.org> Cc: Mark Brown <broonie@kernel.org> Cc: Fabian Frederick <fabf@skynet.be> Cc: Wolfram Sang <wsa@the-dreams.de> Cc: Lee Jones <lee.jones@linaro.org> Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin <edubezval@gmail.com> --- drivers/thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)