| Message ID | 1442260369-6575-2-git-send-email-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/14/2015 02:52 PM, Florian Fainelli wrote: > Document the hif-cpubiuctrl node a bit more, and add a documentation > entry for the optional "brcm,write-pairing" property. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > .../devicetree/bindings/arm/bcm/brcm,brcmstb.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt > index 430608ec09f0..602fa5f308bb 100644 > --- a/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt > +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt > @@ -20,6 +20,20 @@ system control is required: > - compatible: "brcm,bcm<chip_id>-hif-cpubiuctrl", "syscon" This has multiple chips allowed, but... > - compatible: "brcm,bcm<chip_id>-hif-continuation", "syscon" > > +hif-cpubiuctrl node > +------------------- Perhaps it is outside this context, but a description of the block would be nice. > + > +Required properties: > + > + - compatible > + The string should be "brcm.bcm7445-hif-cpubiuctrl", "syscon" This is just one. > + > +Optional properties: > + > + - brcm,write-pairing: > + Boolean property, which when present indicatse that the chip s/indicatse/indicates/ > + supports write-pairing. What is write pairing? Please give brief description. > + > example: > rdb { > #address-cells = <1>; > @@ -35,6 +49,7 @@ example: > hif_cpubiuctrl: syscon@3e2400 { > compatible = "brcm,bcm7445-hif-cpubiuctrl", "syscon"; > reg = <0x3e2400 0x5b4>; > + brcm,write-pairing; > }; > > hif_continuation: syscon@452000 { >
On 14/09/15 13:36, Rob Herring wrote: > On 09/14/2015 02:52 PM, Florian Fainelli wrote: >> Document the hif-cpubiuctrl node a bit more, and add a documentation >> entry for the optional "brcm,write-pairing" property. >> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> >> --- >> .../devicetree/bindings/arm/bcm/brcm,brcmstb.txt | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt >> index 430608ec09f0..602fa5f308bb 100644 >> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt >> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt >> @@ -20,6 +20,20 @@ system control is required: >> - compatible: "brcm,bcm<chip_id>-hif-cpubiuctrl", "syscon" > > This has multiple chips allowed, but... > >> - compatible: "brcm,bcm<chip_id>-hif-continuation", "syscon" >> >> +hif-cpubiuctrl node >> +------------------- > > Perhaps it is outside this context, but a description of the block would > be nice. Sure. > >> + >> +Required properties: >> + >> + - compatible >> + The string should be "brcm.bcm7445-hif-cpubiuctrl", "syscon" > > This is just one. Right, will fix that. > >> + >> +Optional properties: >> + >> + - brcm,write-pairing: >> + Boolean property, which when present indicatse that the chip > > s/indicatse/indicates/ > >> + supports write-pairing. > > What is write pairing? Please give brief description. I will provide an explanation in v2 for what that is.
diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt index 430608ec09f0..602fa5f308bb 100644 --- a/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt @@ -20,6 +20,20 @@ system control is required: - compatible: "brcm,bcm<chip_id>-hif-cpubiuctrl", "syscon" - compatible: "brcm,bcm<chip_id>-hif-continuation", "syscon" +hif-cpubiuctrl node +------------------- + +Required properties: + + - compatible + The string should be "brcm.bcm7445-hif-cpubiuctrl", "syscon" + +Optional properties: + + - brcm,write-pairing: + Boolean property, which when present indicatse that the chip + supports write-pairing. + example: rdb { #address-cells = <1>; @@ -35,6 +49,7 @@ example: hif_cpubiuctrl: syscon@3e2400 { compatible = "brcm,bcm7445-hif-cpubiuctrl", "syscon"; reg = <0x3e2400 0x5b4>; + brcm,write-pairing; }; hif_continuation: syscon@452000 {
Document the hif-cpubiuctrl node a bit more, and add a documentation entry for the optional "brcm,write-pairing" property. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- .../devicetree/bindings/arm/bcm/brcm,brcmstb.txt | 15 +++++++++++++++ 1 file changed, 15 insertions(+)