[1/4] staging: wilc1000: remove unused variable g_num_total_switches

Commit Message

Tony Cho Sept. 15, 2015, 5:33 a.m. UTC

From: Glen Lee <[e-mail]>

g_num_total_switches is never used so just delete it.

Signed-off-by: Glen Lee <[e-mail]>
Signed-off-by: Tony Cho <[e-mail]>
---
 drivers/staging/wilc1000/coreconfigurator.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Sudip Mukherjee Sept. 15, 2015, 7:13 a.m. UTC | #1

On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
> From: Glen Lee <[e-mail]>
> 
> g_num_total_switches is never used so just delete it.
> 
> Signed-off-by: Glen Lee <[e-mail]>
> Signed-off-by: Tony Cho <[e-mail]>
> ---
you only deleted from the .h file but it still remains in
coreconfigurator.c

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Tony Cho Sept. 15, 2015, 8:26 a.m. UTC | #2

On 2015? 09? 15? 16:13, Sudip Mukherjee wrote:
> On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
>> From: Glen Lee <[e-mail]>
>>
>> g_num_total_switches is never used so just delete it.
>>
>> Signed-off-by: Glen Lee <[e-mail]>
>> Signed-off-by: Tony Cho <[e-mail]>
>> ---
> you only deleted from the .h file but it still remains in
> coreconfigurator.c
>
> regards
> sudip

The variable was removed in previous patch (staging: wilc1000: remove unused variables) and the patch was sent
but it's not accepted yet. So, you can find the variable still in c file.

Thanks for your advice,
Tony.


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Greg KH Sept. 15, 2015, 1:46 p.m. UTC | #3

On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote:
> 
> 
> On 2015? 09? 15? 16:13, Sudip Mukherjee wrote:
> >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
> >>From: Glen Lee <[e-mail]>
> >>
> >>g_num_total_switches is never used so just delete it.
> >>
> >>Signed-off-by: Glen Lee <[e-mail]>
> >>Signed-off-by: Tony Cho <[e-mail]>
> >>---
> >you only deleted from the .h file but it still remains in
> >coreconfigurator.c
> >
> >regards
> >sudip
> 
> The variable was removed in previous patch (staging: wilc1000: remove unused variables) and the patch was sent
> but it's not accepted yet. So, you can find the variable still in c file.

I don't see that patch here in my queue :(

Please resend all of your outstanding patches, I think we are out of
sync somehow.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Sudip Mukherjee Sept. 15, 2015, 2:06 p.m. UTC | #4

On Tue, Sep 15, 2015 at 06:46:25AM -0700, Greg KH wrote:
> On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote:
> > 
> > 
> > On 2015? 09? 15? 16:13, Sudip Mukherjee wrote:
> > >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
> > >>From: Glen Lee <[e-mail]>
> > >>
> > >>g_num_total_switches is never used so just delete it.
> > >>
> > >>Signed-off-by: Glen Lee <[e-mail]>
> > >>Signed-off-by: Tony Cho <[e-mail]>
> > >>---
> > >you only deleted from the .h file but it still remains in
> > >coreconfigurator.c
> > >
> > >regards
> > >sudip
> > 
> > The variable was removed in previous patch (staging: wilc1000: remove unused variables) and the patch was sent
> > but it's not accepted yet. So, you can find the variable still in c file.
> 
> I don't see that patch here in my queue :(
> 
> Please resend all of your outstanding patches, I think we are out of
> sync somehow.
This was the series of 7 patches and the first patch was
"remove PANDA_BOARD".
And the series is indeed not applied.

patch 7/7 was removing g_num_total_switches from the .c file, while
resending please modify and remove it from the .h file also.

And when your patch depends on some previous unapplied patch it will be
better if you can mention that in the comments.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Tony Cho Sept. 16, 2015, 1:21 a.m. UTC | #5

On 2015? 09? 15? 22:46, Greg KH wrote:
> On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote:
>>
>> On 2015? 09? 15? 16:13, Sudip Mukherjee wrote:
>>> On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
>>>> From: Glen Lee <[e-mail]>
>>>>
>>>> g_num_total_switches is never used so just delete it.
>>>>
>>>> Signed-off-by: Glen Lee <[e-mail]>
>>>> Signed-off-by: Tony Cho <[e-mail]>
>>>> ---
>>> you only deleted from the .h file but it still remains in
>>> coreconfigurator.c
>>>
>>> regards
>>> sudip
>> The variable was removed in previous patch (staging: wilc1000: remove unused variables) and the patch was sent
>> but it's not accepted yet. So, you can find the variable still in c file.
> I don't see that patch here in my queue :(
>
> Please resend all of your outstanding patches, I think we are out of
> sync somehow.

OK, I will resend all of remaining patches by marking with "v2".

>
> thanks,
>
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
index 3af1935..d2a0a0b 100644
--- a/drivers/staging/wilc1000/coreconfigurator.h
+++ b/drivers/staging/wilc1000/coreconfigurator.h
@@ -29,8 +29,6 @@ 
 #define NUM_11N_HUT_SWITCHES    0
 #endif /* MAC_802_11N */
 
-extern u16 g_num_total_switches;
-
 #define MAC_HDR_LEN             24          /* No Address4 - non-ESS         */
 #define MAX_SSID_LEN            33
 #define FCS_LEN                 4