Message ID | 4D963442.1020106@tomtom.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Fri, Apr 01, 2011 at 10:23:30PM +0200, Matthias Kaehlcke wrote: > Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129 > > Signed-off-by: Matthias Kaehlcke <matthias@tomtom.com> > --- > arch/arm/mach-omap2/mux34xx.h | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/mux34xx.h b/arch/arm/mach-omap2/mux34xx.h > index 6543ebf..70d2b8d 100644 > --- a/arch/arm/mach-omap2/mux34xx.h > +++ b/arch/arm/mach-omap2/mux34xx.h > @@ -393,6 +393,10 @@ > #define OMAP3_CONTROL_PADCONF_SAD2D_SWAKEUP_OFFSET 0xa1c > #define OMAP3_CONTROL_PADCONF_JTAG_RTCK_OFFSET 0xa1e > #define OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET 0xa20 > +#define OMAP3_CONTROL_PADCONF_GPIO127_OFFSET 0xa24 > +#define OMAP3_CONTROL_PADCONF_GPIO126_OFFSET 0xa26 > +#define OMAP3_CONTROL_PADCONF_GPIO128_OFFSET 0xa28 > +#define OMAP3_CONTROL_PADCONF_GPIO129_OFFSET 0xa2a no users for these ?
Hi Felipe, El Sun, Apr 03, 2011 at 02:06:31PM +0300 Felipe Balbi ha dit: > On Fri, Apr 01, 2011 at 10:23:30PM +0200, Matthias Kaehlcke wrote: > > Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129 > > > > Signed-off-by: Matthias Kaehlcke <matthias@tomtom.com> > > --- > > arch/arm/mach-omap2/mux34xx.h | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/mux34xx.h b/arch/arm/mach-omap2/mux34xx.h > > index 6543ebf..70d2b8d 100644 > > --- a/arch/arm/mach-omap2/mux34xx.h > > +++ b/arch/arm/mach-omap2/mux34xx.h > > @@ -393,6 +393,10 @@ > > #define OMAP3_CONTROL_PADCONF_SAD2D_SWAKEUP_OFFSET 0xa1c > > #define OMAP3_CONTROL_PADCONF_JTAG_RTCK_OFFSET 0xa1e > > #define OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET 0xa20 > > +#define OMAP3_CONTROL_PADCONF_GPIO127_OFFSET 0xa24 > > +#define OMAP3_CONTROL_PADCONF_GPIO126_OFFSET 0xa26 > > +#define OMAP3_CONTROL_PADCONF_GPIO128_OFFSET 0xa28 > > +#define OMAP3_CONTROL_PADCONF_GPIO129_OFFSET 0xa2a > > no users for these ? we use these on a custom board whose board specific code won't be mainlined. i think it still makes sense to have the constants in mainline for the sake of completeness kind regards
On Sun, Apr 03, 2011 at 01:33:28PM +0200, Matthias Kaehlcke wrote: > Hi Felipe, > > El Sun, Apr 03, 2011 at 02:06:31PM +0300 Felipe Balbi ha dit: > > > On Fri, Apr 01, 2011 at 10:23:30PM +0200, Matthias Kaehlcke wrote: > > > Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129 > > > > > > Signed-off-by: Matthias Kaehlcke <matthias@tomtom.com> > > > --- > > > arch/arm/mach-omap2/mux34xx.h | 4 ++++ > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > > diff --git a/arch/arm/mach-omap2/mux34xx.h b/arch/arm/mach-omap2/mux34xx.h > > > index 6543ebf..70d2b8d 100644 > > > --- a/arch/arm/mach-omap2/mux34xx.h > > > +++ b/arch/arm/mach-omap2/mux34xx.h > > > @@ -393,6 +393,10 @@ > > > #define OMAP3_CONTROL_PADCONF_SAD2D_SWAKEUP_OFFSET 0xa1c > > > #define OMAP3_CONTROL_PADCONF_JTAG_RTCK_OFFSET 0xa1e > > > #define OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET 0xa20 > > > +#define OMAP3_CONTROL_PADCONF_GPIO127_OFFSET 0xa24 > > > +#define OMAP3_CONTROL_PADCONF_GPIO126_OFFSET 0xa26 > > > +#define OMAP3_CONTROL_PADCONF_GPIO128_OFFSET 0xa28 > > > +#define OMAP3_CONTROL_PADCONF_GPIO129_OFFSET 0xa2a > > > > no users for these ? > > we use these on a custom board whose board specific code won't be > mainlined. i think it still makes sense to have the constants in > mainline for the sake of completeness I'll leave that decision to Tony. I agree that, for the sake of completeness, we should have those. But OTOH, not having any in tree users is kinda of a bummer. It would be nice to see TomTom's devices in tree. Maybe after the kernel sources is released to the public we could that in tree "for the sake of completeness" :-)
diff --git a/arch/arm/mach-omap2/mux34xx.h b/arch/arm/mach-omap2/mux34xx.h index 6543ebf..70d2b8d 100644 --- a/arch/arm/mach-omap2/mux34xx.h +++ b/arch/arm/mach-omap2/mux34xx.h @@ -393,6 +393,10 @@ #define OMAP3_CONTROL_PADCONF_SAD2D_SWAKEUP_OFFSET 0xa1c #define OMAP3_CONTROL_PADCONF_JTAG_RTCK_OFFSET 0xa1e #define OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET 0xa20 +#define OMAP3_CONTROL_PADCONF_GPIO127_OFFSET 0xa24 +#define OMAP3_CONTROL_PADCONF_GPIO126_OFFSET 0xa26 +#define OMAP3_CONTROL_PADCONF_GPIO128_OFFSET 0xa28 +#define OMAP3_CONTROL_PADCONF_GPIO129_OFFSET 0xa2a #define OMAP3_CONTROL_PADCONF_MUX_SIZE \ (OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET + 0x2)