| Message ID | 1442323816-4712-1-git-send-email-michal.winiarski@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 15, 2015 at 03:30:15PM +0200, Micha? Winiarski wrote: > It will be initialized just moments later by i915_init_vm. Global and > aliasing tables are going through different path anyways. > > Cc: Michel Thierry <michel.thierry@intel.com> > Cc: Mika Kuoppala <mika.kuoppala@intel.com> > Signed-off-by: Micha? Winiarski <michal.winiarski@intel.com> > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > index 8786281..7ff7239 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -2129,8 +2129,6 @@ int i915_ppgtt_init(struct drm_device *dev, struct i915_hw_ppgtt *ppgtt) > ret = __hw_ppgtt_init(dev, ppgtt); > if (ret == 0) { > kref_init(&ppgtt->ref); > - drm_mm_init(&ppgtt->base.mm, ppgtt->base.start, > - ppgtt->base.total); > i915_init_vm(dev_priv, &ppgtt->base); And please move i915_init_vm() to i915_gem_gtt.c and rename it correctly. -Chris
On 9/15/2015 2:30 PM, Micha? Winiarski wrote: > It will be initialized just moments later by i915_init_vm. Global and > aliasing tables are going through different path anyways. > > Cc: Michel Thierry <michel.thierry@intel.com> > Cc: Mika Kuoppala <mika.kuoppala@intel.com> > Signed-off-by: Micha? Winiarski <michal.winiarski@intel.com> > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > index 8786281..7ff7239 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -2129,8 +2129,6 @@ int i915_ppgtt_init(struct drm_device *dev, struct i915_hw_ppgtt *ppgtt) > ret = __hw_ppgtt_init(dev, ppgtt); > if (ret == 0) { > kref_init(&ppgtt->ref); > - drm_mm_init(&ppgtt->base.mm, ppgtt->base.start, > - ppgtt->base.total); > i915_init_vm(dev_priv, &ppgtt->base); > } > > Indeed, Reviewed-by: Michel Thierry <michel.thierry@intel.com>
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 8786281..7ff7239 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -2129,8 +2129,6 @@ int i915_ppgtt_init(struct drm_device *dev, struct i915_hw_ppgtt *ppgtt) ret = __hw_ppgtt_init(dev, ppgtt); if (ret == 0) { kref_init(&ppgtt->ref); - drm_mm_init(&ppgtt->base.mm, ppgtt->base.start, - ppgtt->base.total); i915_init_vm(dev_priv, &ppgtt->base); }
It will be initialized just moments later by i915_init_vm. Global and aliasing tables are going through different path anyways. Cc: Michel Thierry <michel.thierry@intel.com> Cc: Mika Kuoppala <mika.kuoppala@intel.com> Signed-off-by: Micha? Winiarski <michal.winiarski@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 -- 1 file changed, 2 deletions(-)