| Message ID | BLU436-SMTP21C260BE68BB2AC6FA1F35DF5C0@phx.gbl (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Tue, 2015-09-15 at 12:44 -0400, Donavan Lance wrote: > Adds support for Microsoft Type Cover 3 with 0x07e2 product ID. > > Signed-off-by: Donavan Lance <shvr@fedoraproject.org> > --- > drivers/hid/hid-core.c | 2 ++ > drivers/hid/hid-ids.h | 1 + > drivers/hid/hid-microsoft.c | 2 ++ > drivers/hid/usbhid/hid-quirks.c | 1 + > 4 files changed, 6 insertions(+) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index 70a11ac..31ce45d 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -725,6 +725,7 @@ static void hid_scan_collection(struct hid_parser > *parser, unsigned type) > > if (hid->vendor == USB_VENDOR_ID_MICROSOFT && > (hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 || > + hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 || > hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP || > hid->product == USB_DEVICE_ID_MS_TYPE_COVER_3 || > hid->product == USB_DEVICE_ID_MS_POWER_COVER) && > @@ -1928,6 +1929,7 @@ static const struct hid_device_id > hid_have_special_driver[] = { > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0) }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_OFFICE_KB) }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3) }, > + { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2) }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_3) }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_POWER_COVER) }, > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index f769208..01bb2fa 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -679,6 +679,7 @@ > #define USB_DEVICE_ID_MS_TOUCH_COVER_2 0x07a7 > #define USB_DEVICE_ID_MS_TYPE_COVER_2 0x07a9 > #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 0x07dc > +#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 0x07e2 > #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP 0x07dd > #define USB_DEVICE_ID_MS_TYPE_COVER_3 0x07de > #define USB_DEVICE_ID_MS_POWER_COVER 0x07da > diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid > -microsoft.c > index 9aa3515..77a2cf3 100644 > --- a/drivers/hid/hid-microsoft.c > +++ b/drivers/hid/hid-microsoft.c > @@ -278,6 +278,8 @@ static const struct hid_device_id ms_devices[] = > { > .driver_data = MS_DUPLICATE_USAGES }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3), > .driver_data = MS_HIDINPUT }, > + { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2), > + .driver_data = MS_HIDINPUT }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP), > .driver_data = MS_HIDINPUT }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_3), > diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid > -quirks.c > index 1dff8f0..5ef80c8 100644 > --- a/drivers/hid/usbhid/hid-quirks.c > +++ b/drivers/hid/usbhid/hid-quirks.c > @@ -91,6 +91,7 @@ static const struct hid_blacklist { > { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_2, > HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TOUCH_COVER_2, > HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3, HID_QUIRK_NO_INIT_REPORTS }, > + { USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2, HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, > HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER, > HID_QUIRK_NO_INIT_REPORTS }, Patch resent again since it got mangled again. I've tested emailing this one multiple times and so should be fine, but I'll refrain from sending out this patch again. Apologies for spamming the list with this patch. Donavan Lance -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2015-09-15 at 12:48 -0400, Donavan Lance wrote: <snip> > Patch resent again since it got mangled again. I've tested emailing > this one multiple times and so should be fine, but I'll refrain from > sending out this patch again. Apologies for spamming the list with > this > patch. Are you using Evolution to send the patches? If so, once you've opened the draft mail with your patch, select the whole body of the mail, and select "Preformatted" from the style drop -down (the one left of the "left justify" formatting button in the toolbar). I've mangled a few patches with the new version of Evolution as well... -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2015-09-15 at 12:44 -0400, Donavan Lance wrote: > Adds support for Microsoft Type Cover 3 with 0x07e2 product ID. > > Signed-off-by: Donavan Lance <shvr@fedoraproject.org> > --- > drivers/hid/hid-core.c | 2 ++ > drivers/hid/hid-ids.h | 1 + > drivers/hid/hid-microsoft.c | 2 ++ > drivers/hid/usbhid/hid-quirks.c | 1 + > 4 files changed, 6 insertions(+) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index 70a11ac..31ce45d 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -725,6 +725,7 @@ static void hid_scan_collection(struct hid_parser > *parser, unsigned type) > > if (hid->vendor == USB_VENDOR_ID_MICROSOFT && > (hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 || > + hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 || > hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP || > hid->product == USB_DEVICE_ID_MS_TYPE_COVER_3 || > hid->product == USB_DEVICE_ID_MS_POWER_COVER) && > @@ -1928,6 +1929,7 @@ static const struct hid_device_id > hid_have_special_driver[] = { > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0) }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_OFFICE_KB) }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3) }, > + { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2) }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_3) }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_POWER_COVER) }, > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index f769208..01bb2fa 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -679,6 +679,7 @@ > #define USB_DEVICE_ID_MS_TOUCH_COVER_2 0x07a7 > #define USB_DEVICE_ID_MS_TYPE_COVER_2 0x07a9 > #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 0x07dc > +#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 0x07e2 > #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP 0x07dd > #define USB_DEVICE_ID_MS_TYPE_COVER_3 0x07de > #define USB_DEVICE_ID_MS_POWER_COVER 0x07da > diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid > -microsoft.c > index 9aa3515..77a2cf3 100644 > --- a/drivers/hid/hid-microsoft.c > +++ b/drivers/hid/hid-microsoft.c > @@ -278,6 +278,8 @@ static const struct hid_device_id ms_devices[] = > { > .driver_data = MS_DUPLICATE_USAGES }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3), > .driver_data = MS_HIDINPUT }, > + { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2), > + .driver_data = MS_HIDINPUT }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP), > .driver_data = MS_HIDINPUT }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_3), > diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid > -quirks.c > index 1dff8f0..5ef80c8 100644 > --- a/drivers/hid/usbhid/hid-quirks.c > +++ b/drivers/hid/usbhid/hid-quirks.c > @@ -91,6 +91,7 @@ static const struct hid_blacklist { > { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_2, > HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TOUCH_COVER_2, > HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3, HID_QUIRK_NO_INIT_REPORTS }, > + { USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2, HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, > HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER, > HID_QUIRK_NO_INIT_REPORTS }, CC'ing Jiri Kosina -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 15 Sep 2015, Donavan Lance wrote: > Adds support for Microsoft Type Cover 3 with 0x07e2 product ID. > > Signed-off-by: Donavan Lance <shvr@fedoraproject.org> Queued in hid.git#for-4.4/microsoft. Thanks,
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 70a11ac..31ce45d 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -725,6 +725,7 @@ static void hid_scan_collection(struct hid_parser *parser, unsigned type) if (hid->vendor == USB_VENDOR_ID_MICROSOFT && (hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 || + hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 || hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP || hid->product == USB_DEVICE_ID_MS_TYPE_COVER_3 || hid->product == USB_DEVICE_ID_MS_POWER_COVER) && @@ -1928,6 +1929,7 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0) }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_OFFICE_KB) }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3) }, + { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2) }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3) }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER) }, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index f769208..01bb2fa 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -679,6 +679,7 @@ #define USB_DEVICE_ID_MS_TOUCH_COVER_2 0x07a7 #define USB_DEVICE_ID_MS_TYPE_COVER_2 0x07a9 #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 0x07dc +#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 0x07e2 #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP 0x07dd #define USB_DEVICE_ID_MS_TYPE_COVER_3 0x07de #define USB_DEVICE_ID_MS_POWER_COVER 0x07da diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c index 9aa3515..77a2cf3 100644 --- a/drivers/hid/hid-microsoft.c +++ b/drivers/hid/hid-microsoft.c @@ -278,6 +278,8 @@ static const struct hid_device_id ms_devices[] = { .driver_data = MS_DUPLICATE_USAGES }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3), .driver_data = MS_HIDINPUT }, + { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2), + .driver_data = MS_HIDINPUT }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP), .driver_data = MS_HIDINPUT }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3), diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c index 1dff8f0..5ef80c8 100644 --- a/drivers/hid/usbhid/hid-quirks.c +++ b/drivers/hid/usbhid/hid-quirks.c @@ -91,6 +91,7 @@ static const struct hid_blacklist { { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_2, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TOUCH_COVER_2, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3, HID_QUIRK_NO_INIT_REPORTS }, + { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER, HID_QUIRK_NO_INIT_REPORTS },
Adds support for Microsoft Type Cover 3 with 0x07e2 product ID. Signed-off-by: Donavan Lance <shvr@fedoraproject.org> --- drivers/hid/hid-core.c | 2 ++ drivers/hid/hid-ids.h | 1 + drivers/hid/hid-microsoft.c | 2 ++ drivers/hid/usbhid/hid-quirks.c | 1 + 4 files changed, 6 insertions(+)