| Message ID | 55FFA8DD.5020109@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 2015-09-21 at 14:51 +0800, Fu, Zhonghui wrote: > Now, PM core supports asynchronous suspend/resume mode for devices > during system suspend/resume, and the power state transition of one > device may be completed in separate kernel thread. PM core ensures > all power state transition timing dependency between devices. This > patch enables sdhci-acpi device to suspend/resume asynchronously. > This will take advantage of multicore and improve system > suspend/resume speed. > It would be nice I think to put here statistics you collected as well. > Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com> > --- > Changes in v2: > - Amend commit message. > > drivers/mmc/host/sdhci-acpi.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci > -acpi.c > index 22d929f..67e6263 100644 > --- a/drivers/mmc/host/sdhci-acpi.c > +++ b/drivers/mmc/host/sdhci-acpi.c > @@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct > platform_device *pdev) > pm_runtime_enable(dev); > } > > + device_enable_async_suspend(dev); > + > return 0; > > err_free: > -- 1.7.1 >
Please review the latest version: "[PATCH v3] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously" Thanks, Zhonghui On 9/21/2015 2:51 PM, Fu, Zhonghui wrote: > Now, PM core supports asynchronous suspend/resume mode for devices > during system suspend/resume, and the power state transition of one > device may be completed in separate kernel thread. PM core ensures > all power state transition timing dependency between devices. This > patch enables sdhci-acpi device to suspend/resume asynchronously. > This will take advantage of multicore and improve system > suspend/resume speed. > > Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com> > --- > Changes in v2: > - Amend commit message. > > drivers/mmc/host/sdhci-acpi.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c > index 22d929f..67e6263 100644 > --- a/drivers/mmc/host/sdhci-acpi.c > +++ b/drivers/mmc/host/sdhci-acpi.c > @@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct platform_device *pdev) > pm_runtime_enable(dev); > } > > + device_enable_async_suspend(dev); > + > return 0; > > err_free: > -- 1.7.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 9/21/2015 5:32 PM, Andy Shevchenko wrote: > On Mon, 2015-09-21 at 14:51 +0800, Fu, Zhonghui wrote: >> Now, PM core supports asynchronous suspend/resume mode for devices >> during system suspend/resume, and the power state transition of one >> device may be completed in separate kernel thread. PM core ensures >> all power state transition timing dependency between devices. This >> patch enables sdhci-acpi device to suspend/resume asynchronously. >> This will take advantage of multicore and improve system >> suspend/resume speed. >> > It would be nice I think to put here statistics you collected as well. Sorry for replying this mail after long leave. I have added the test result into commit message and sent the latest version of this patch:"[PATCH v3] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously". Thanks, Zhonghui > >> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com> >> --- >> Changes in v2: >> - Amend commit message. >> >> drivers/mmc/host/sdhci-acpi.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci >> -acpi.c >> index 22d929f..67e6263 100644 >> --- a/drivers/mmc/host/sdhci-acpi.c >> +++ b/drivers/mmc/host/sdhci-acpi.c >> @@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct >> platform_device *pdev) >> pm_runtime_enable(dev); >> } >> >> + device_enable_async_suspend(dev); >> + >> return 0; >> >> err_free: >> -- 1.7.1 >> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c index 22d929f..67e6263 100644 --- a/drivers/mmc/host/sdhci-acpi.c +++ b/drivers/mmc/host/sdhci-acpi.c @@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct platform_device *pdev) pm_runtime_enable(dev); } + device_enable_async_suspend(dev); + return 0; err_free:
Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables sdhci-acpi device to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed. Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com> --- Changes in v2: - Amend commit message. drivers/mmc/host/sdhci-acpi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html