| Message ID | 1443579437-845-2-git-send-email-peter.chen@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen: > It can improve the USB performance when choosing larger > burst size at some systems (bus size is larger), there is > no side effect if this burst size is larger than bus size. > Just for the record, as it seems too late to stop the train now: I am _NOT_ happy that the extended binding has been accepted into the USB tree despite outstanding review comments from me not being addressed or even answered. > Signed-off-by: Peter Chen <peter.chen@freescale.com> > --- > > Changes for v2: > - Applies changes for imx6ul > > arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++++++ > arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++ > arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++ > arch/arm/boot/dts/imx6ul.dtsi | 4 ++++ > 4 files changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index 3d04a17..92c5cc0 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -907,6 +907,8 @@ > fsl,usbphy = <&usbphy1>; > fsl,usbmisc = <&usbmisc 0>; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; > > @@ -919,6 +921,8 @@ > fsl,usbmisc = <&usbmisc 1>; > dr_mode = "host"; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; > > @@ -930,6 +934,8 @@ > fsl,usbmisc = <&usbmisc 2>; > dr_mode = "host"; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; > > @@ -941,6 +947,8 @@ > fsl,usbmisc = <&usbmisc 3>; > dr_mode = "host"; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; > > diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi > index 057b1d4..2c0faeb 100644 > --- a/arch/arm/boot/dts/imx6sl.dtsi > +++ b/arch/arm/boot/dts/imx6sl.dtsi > @@ -690,6 +690,8 @@ > fsl,usbphy = <&usbphy1>; > fsl,usbmisc = <&usbmisc 0>; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; > > @@ -701,6 +703,8 @@ > fsl,usbphy = <&usbphy2>; > fsl,usbmisc = <&usbmisc 1>; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; > > @@ -712,6 +716,8 @@ > fsl,usbmisc = <&usbmisc 2>; > dr_mode = "host"; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; > > diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi > index 70a7c4f..01191c0 100644 > --- a/arch/arm/boot/dts/imx6sx.dtsi > +++ b/arch/arm/boot/dts/imx6sx.dtsi > @@ -784,6 +784,8 @@ > fsl,usbmisc = <&usbmisc 0>; > fsl,anatop = <&anatop>; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; > > @@ -795,6 +797,8 @@ > fsl,usbphy = <&usbphy2>; > fsl,usbmisc = <&usbmisc 1>; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; > > @@ -808,6 +812,8 @@ > fsl,anatop = <&anatop>; > dr_mode = "host"; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; > > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi > index 654009f..28dcd68 100644 > --- a/arch/arm/boot/dts/imx6ul.dtsi > +++ b/arch/arm/boot/dts/imx6ul.dtsi > @@ -536,6 +536,8 @@ > fsl,usbmisc = <&usbmisc 0>; > fsl,anatop = <&anatop>; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; > > @@ -547,6 +549,8 @@ > fsl,usbphy = <&usbphy2>; > fsl,usbmisc = <&usbmisc 1>; > ahb-burst-config = <0x0>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > status = "disabled"; > }; >
On Wed, Sep 30, 2015 at 10:52:39AM +0200, Lucas Stach wrote: > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen: > > It can improve the USB performance when choosing larger > > burst size at some systems (bus size is larger), there is > > no side effect if this burst size is larger than bus size. > > > Just for the record, as it seems too late to stop the train now: > > I am _NOT_ happy that the extended binding has been accepted into the > USB tree despite outstanding review comments from me not being addressed > or even answered. Okay. I'm not aware of this. I'm dropping the patches until everyone agrees with it. Shawn
On Wed, Sep 30, 2015 at 4:52 PM, Lucas Stach <l.stach@pengutronix.de> wrote: > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen: >> It can improve the USB performance when choosing larger >> burst size at some systems (bus size is larger), there is >> no side effect if this burst size is larger than bus size. >> > Just for the record, as it seems too late to stop the train now: > > I am _NOT_ happy that the extended binding has been accepted into the > USB tree despite outstanding review comments from me not being addressed > or even answered. > I sent patch for review at Aug 7th, queued this patches at Aug 13th [1], and sent pull request at Aug 14th, I am curious why you did not give comments between this period utill I complained one ethernet patch breaks i.mx ethernet function for v4.2 tree [2] at Aug 14th. I will consider your comments, and send patch for improving it if possible. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364352.html [2] http://marc.info/?l=linux-netdev&m=143954500409636&w=2 >> Signed-off-by: Peter Chen <peter.chen@freescale.com> >> --- >> >> Changes for v2: >> - Applies changes for imx6ul >> >> arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++++++ >> arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++ >> arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++ >> arch/arm/boot/dts/imx6ul.dtsi | 4 ++++ >> 4 files changed, 24 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi >> index 3d04a17..92c5cc0 100644 >> --- a/arch/arm/boot/dts/imx6qdl.dtsi >> +++ b/arch/arm/boot/dts/imx6qdl.dtsi >> @@ -907,6 +907,8 @@ >> fsl,usbphy = <&usbphy1>; >> fsl,usbmisc = <&usbmisc 0>; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> >> @@ -919,6 +921,8 @@ >> fsl,usbmisc = <&usbmisc 1>; >> dr_mode = "host"; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> >> @@ -930,6 +934,8 @@ >> fsl,usbmisc = <&usbmisc 2>; >> dr_mode = "host"; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> >> @@ -941,6 +947,8 @@ >> fsl,usbmisc = <&usbmisc 3>; >> dr_mode = "host"; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> >> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi >> index 057b1d4..2c0faeb 100644 >> --- a/arch/arm/boot/dts/imx6sl.dtsi >> +++ b/arch/arm/boot/dts/imx6sl.dtsi >> @@ -690,6 +690,8 @@ >> fsl,usbphy = <&usbphy1>; >> fsl,usbmisc = <&usbmisc 0>; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> >> @@ -701,6 +703,8 @@ >> fsl,usbphy = <&usbphy2>; >> fsl,usbmisc = <&usbmisc 1>; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> >> @@ -712,6 +716,8 @@ >> fsl,usbmisc = <&usbmisc 2>; >> dr_mode = "host"; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> >> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi >> index 70a7c4f..01191c0 100644 >> --- a/arch/arm/boot/dts/imx6sx.dtsi >> +++ b/arch/arm/boot/dts/imx6sx.dtsi >> @@ -784,6 +784,8 @@ >> fsl,usbmisc = <&usbmisc 0>; >> fsl,anatop = <&anatop>; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> >> @@ -795,6 +797,8 @@ >> fsl,usbphy = <&usbphy2>; >> fsl,usbmisc = <&usbmisc 1>; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> >> @@ -808,6 +812,8 @@ >> fsl,anatop = <&anatop>; >> dr_mode = "host"; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> >> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi >> index 654009f..28dcd68 100644 >> --- a/arch/arm/boot/dts/imx6ul.dtsi >> +++ b/arch/arm/boot/dts/imx6ul.dtsi >> @@ -536,6 +536,8 @@ >> fsl,usbmisc = <&usbmisc 0>; >> fsl,anatop = <&anatop>; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> >> @@ -547,6 +549,8 @@ >> fsl,usbphy = <&usbphy2>; >> fsl,usbmisc = <&usbmisc 1>; >> ahb-burst-config = <0x0>; >> + tx-burst-size-dword = <0x10>; >> + rx-burst-size-dword = <0x10>; >> status = "disabled"; >> }; >> > > -- > Pengutronix e.K. | Lucas Stach | > Industrial Linux Solutions | http://www.pengutronix.de/ | > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Am Donnerstag, den 01.10.2015, 16:13 +0800 schrieb Peter Chen: > On Wed, Sep 30, 2015 at 4:52 PM, Lucas Stach <l.stach@pengutronix.de> wrote: > > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen: > >> It can improve the USB performance when choosing larger > >> burst size at some systems (bus size is larger), there is > >> no side effect if this burst size is larger than bus size. > >> > > Just for the record, as it seems too late to stop the train now: > > > > I am _NOT_ happy that the extended binding has been accepted into the > > USB tree despite outstanding review comments from me not being addressed > > or even answered. > > > > I sent patch for review at Aug 7th, queued this patches at Aug 13th > [1], and sent pull > request at Aug 14th, I am curious why you did not give comments > between this period utill > I complained one ethernet patch breaks i.mx ethernet function for v4.2 > tree [2] at Aug 14th. > What do the USB changes have to do with any ethernet changes? The comments I'm referring to are from Aug 14th http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364396.html So you are telling me that giving reviewers not even a week before sending the pull request is appropriate? And that sending the pull despite there being open review comments is ok? Think again. > I will consider your comments, and send patch for improving it if possible. > As I said it may be too late now. By sending the pull request including the binding change you forced everyone to now either accept the (in my opinion not really perfect) binding, or hurry to change it in the current RC phase, something which I'm not comfortable with. The damage has been done. > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364352.html > [2] http://marc.info/?l=linux-netdev&m=143954500409636&w=2 >
On Thu, Oct 1, 2015 at 4:42 PM, Lucas Stach <l.stach@pengutronix.de> wrote: > Am Donnerstag, den 01.10.2015, 16:13 +0800 schrieb Peter Chen: >> On Wed, Sep 30, 2015 at 4:52 PM, Lucas Stach <l.stach@pengutronix.de> wrote: >> > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen: >> >> It can improve the USB performance when choosing larger >> >> burst size at some systems (bus size is larger), there is >> >> no side effect if this burst size is larger than bus size. >> >> >> > Just for the record, as it seems too late to stop the train now: >> > >> > I am _NOT_ happy that the extended binding has been accepted into the >> > USB tree despite outstanding review comments from me not being addressed >> > or even answered. >> > >> >> I sent patch for review at Aug 7th, queued this patches at Aug 13th >> [1], and sent pull >> request at Aug 14th, I am curious why you did not give comments >> between this period utill >> I complained one ethernet patch breaks i.mx ethernet function for v4.2 >> tree [2] at Aug 14th. >> > What do the USB changes have to do with any ethernet changes? > > The comments I'm referring to are from Aug 14th > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364396.html > > So you are telling me that giving reviewers not even a week before > sending the pull request is appropriate? And that sending the pull > despite there being open review comments is ok? Think again. > Comments are welcome at anytime, but why you are __NOT__ happy it was accepted and your comments were delayed. If you think this binding description is not ok, patch is welcome. >> I will consider your comments, and send patch for improving it if possible. >> > As I said it may be too late now. By sending the pull request including > the binding change you forced everyone to now either accept the (in my > opinion not really perfect) binding, or hurry to change it in the > current RC phase, something which I'm not comfortable with. The damage > has been done. > Again, I waited one week, and your comments were late. I do not want to dispute more at our holidays. Let's stop here.
On Wed, Sep 30, 2015 at 09:37:12PM +0800, Shawn Guo wrote: > On Wed, Sep 30, 2015 at 10:52:39AM +0200, Lucas Stach wrote: > > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen: > > > It can improve the USB performance when choosing larger > > > burst size at some systems (bus size is larger), there is > > > no side effect if this burst size is larger than bus size. > > > > > Just for the record, as it seems too late to stop the train now: > > > > I am _NOT_ happy that the extended binding has been accepted into the > > USB tree despite outstanding review comments from me not being addressed > > or even answered. > > Okay. I'm not aware of this. I'm dropping the patches until everyone > agrees with it. > Hi Shawn & Lucas, I sent the improvement patch for dt description following Lucas's comment one week ago at below: https://www.spinics.net/lists/linux-usb/msg131150.html If no more comments, queue my dts patches please.
Hi Shawn, Am Dienstag, den 20.10.2015, 15:07 +0800 schrieb Peter Chen: > On Wed, Sep 30, 2015 at 09:37:12PM +0800, Shawn Guo wrote: > > On Wed, Sep 30, 2015 at 10:52:39AM +0200, Lucas Stach wrote: > > > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen: > > > > It can improve the USB performance when choosing larger > > > > burst size at some systems (bus size is larger), there is > > > > no side effect if this burst size is larger than bus size. > > > > > > > Just for the record, as it seems too late to stop the train now: > > > > > > I am _NOT_ happy that the extended binding has been accepted into the > > > USB tree despite outstanding review comments from me not being addressed > > > or even answered. > > > > Okay. I'm not aware of this. I'm dropping the patches until everyone > > agrees with it. > > > > Hi Shawn & Lucas, I sent the improvement patch for dt description following > Lucas's comment one week ago at below: > > https://www.spinics.net/lists/linux-usb/msg131150.html > > If no more comments, queue my dts patches please. > While the binding hasn't received a good review in time it is already in a released kernel and I'm not going to argue to change it now after the fact (violating the DT stability rules) just to satisfy my rather minor comments. I want to make clear that I was not happy by how this stuff has been handled with the USB tree and it is my hope that this can be improved for future binding changes. But please don't hold those DTS patches any longer. The binding is in, there is no point in not applying the corresponding patches. Regards, Lucas
On Tue, Oct 20, 2015 at 10:41:49AM +0200, Lucas Stach wrote: > Hi Shawn, > > Am Dienstag, den 20.10.2015, 15:07 +0800 schrieb Peter Chen: > > On Wed, Sep 30, 2015 at 09:37:12PM +0800, Shawn Guo wrote: > > > On Wed, Sep 30, 2015 at 10:52:39AM +0200, Lucas Stach wrote: > > > > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen: > > > > > It can improve the USB performance when choosing larger > > > > > burst size at some systems (bus size is larger), there is > > > > > no side effect if this burst size is larger than bus size. > > > > > > > > > Just for the record, as it seems too late to stop the train now: > > > > > > > > I am _NOT_ happy that the extended binding has been accepted into the > > > > USB tree despite outstanding review comments from me not being addressed > > > > or even answered. > > > > > > Okay. I'm not aware of this. I'm dropping the patches until everyone > > > agrees with it. > > > > > > > Hi Shawn & Lucas, I sent the improvement patch for dt description following > > Lucas's comment one week ago at below: > > > > https://www.spinics.net/lists/linux-usb/msg131150.html > > > > If no more comments, queue my dts patches please. > > > While the binding hasn't received a good review in time it is already in > a released kernel and I'm not going to argue to change it now after the > fact (violating the DT stability rules) just to satisfy my rather minor > comments. I want to make clear that I was not happy by how this stuff > has been handled with the USB tree and it is my hope that this can be > improved for future binding changes. > > But please don't hold those DTS patches any longer. The binding is in, > there is no point in not applying the corresponding patches. > > Regards, > Lucas > Ping... Shawn, I still not see these dt changes in your tree
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 3d04a17..92c5cc0 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -907,6 +907,8 @@ fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; }; @@ -919,6 +921,8 @@ fsl,usbmisc = <&usbmisc 1>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; }; @@ -930,6 +934,8 @@ fsl,usbmisc = <&usbmisc 2>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; }; @@ -941,6 +947,8 @@ fsl,usbmisc = <&usbmisc 3>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; }; diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index 057b1d4..2c0faeb 100644 --- a/arch/arm/boot/dts/imx6sl.dtsi +++ b/arch/arm/boot/dts/imx6sl.dtsi @@ -690,6 +690,8 @@ fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; }; @@ -701,6 +703,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; }; @@ -712,6 +716,8 @@ fsl,usbmisc = <&usbmisc 2>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; }; diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index 70a7c4f..01191c0 100644 --- a/arch/arm/boot/dts/imx6sx.dtsi +++ b/arch/arm/boot/dts/imx6sx.dtsi @@ -784,6 +784,8 @@ fsl,usbmisc = <&usbmisc 0>; fsl,anatop = <&anatop>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; }; @@ -795,6 +797,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; }; @@ -808,6 +812,8 @@ fsl,anatop = <&anatop>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; }; diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index 654009f..28dcd68 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot/dts/imx6ul.dtsi @@ -536,6 +536,8 @@ fsl,usbmisc = <&usbmisc 0>; fsl,anatop = <&anatop>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; }; @@ -547,6 +549,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
It can improve the USB performance when choosing larger burst size at some systems (bus size is larger), there is no side effect if this burst size is larger than bus size. Signed-off-by: Peter Chen <peter.chen@freescale.com> --- Changes for v2: - Applies changes for imx6ul arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++++++ arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++ arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++ arch/arm/boot/dts/imx6ul.dtsi | 4 ++++ 4 files changed, 24 insertions(+)