diff mbox

[16/18] Input: elan_i2c - simplify function return logic

Message ID 1443793229-22363-17-git-send-email-javier@osg.samsung.com (mailing list archive)
State Rejected
Headers show

Commit Message

Javier Martinez Canillas Oct. 2, 2015, 1:40 p.m. UTC 
The invoked function already returns zero on success or a negative
errno code so there is no need to open code the logic in the caller.

This also fixes the following make coccicheck warning:

drivers/input/mouse/elan_i2c_smbus.c:402:1-6: WARNING: end returns can be simplified

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/input/mouse/elan_i2c_smbus.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Benson Leung Oct. 2, 2015, 4:46 p.m. UTC | #1 
On Fri, Oct 2, 2015 at 6:40 AM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> The invoked function already returns zero on success or a negative
> errno code so there is no need to open code the logic in the caller.
>
> This also fixes the following make coccicheck warning:
>
> drivers/input/mouse/elan_i2c_smbus.c:402:1-6: WARNING: end returns can be simplified
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Reviewed-by: Benson Leung <bleung@chromium.org>
diff mbox

Patch

diff --git a/drivers/input/mouse/elan_i2c_smbus.c b/drivers/input/mouse/elan_i2c_smbus.c
index cb6aecbc1dc2..e5b0adfac3d0 100644
--- a/drivers/input/mouse/elan_i2c_smbus.c
+++ b/drivers/input/mouse/elan_i2c_smbus.c
@@ -399,11 +399,7 @@  static int elan_smbus_prepare_fw_update(struct i2c_client *client)
 		return error;
 
 	/* Reset IC */
-	error = elan_smbus_iap_reset(client);
-	if (error)
-		return error;
-
-	return 0;
+	return elan_smbus_iap_reset(client);
 }