| Message ID | 1443797278-9052-1-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Oct 02, 2015 at 04:47:58PM +0200, Javier Martinez Canillas wrote: > The driver depends on GOLDFISH but there isn't a build dependency > so it's a good idea to allow the driver to be built even if that > option is disabled, if the COMPILE_TEST option is enabled. > > That way, the driver can be built with a config generated by make > allyesconfig and can be checked if a patch would break the build. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > Applied, thank you. > --- > > drivers/input/keyboard/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig > index 2e80107ff630..ddd8148d51d7 100644 > --- a/drivers/input/keyboard/Kconfig > +++ b/drivers/input/keyboard/Kconfig > @@ -516,7 +516,7 @@ config KEYBOARD_SAMSUNG > module will be called samsung-keypad. > > config KEYBOARD_GOLDFISH_EVENTS > - depends on GOLDFISH > + depends on GOLDFISH || COMPILE_TEST > tristate "Generic Input Event device for Goldfish" > help > Say Y here to get an input event device for the Goldfish virtual > -- > 2.4.3 >
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 2e80107ff630..ddd8148d51d7 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -516,7 +516,7 @@ config KEYBOARD_SAMSUNG module will be called samsung-keypad. config KEYBOARD_GOLDFISH_EVENTS - depends on GOLDFISH + depends on GOLDFISH || COMPILE_TEST tristate "Generic Input Event device for Goldfish" help Say Y here to get an input event device for the Goldfish virtual
The driver depends on GOLDFISH but there isn't a build dependency so it's a good idea to allow the driver to be built even if that option is disabled, if the COMPILE_TEST option is enabled. That way, the driver can be built with a config generated by make allyesconfig and can be checked if a patch would break the build. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/input/keyboard/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)