| Message ID | 560F8DB0.8030704@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Jiang Liu wrote on 03/10/15 17:41: > Hi Arthur, > The above results suggest that we need to shutdown eata > controller for kexec. So could you please try to apply the attached > patch upon the previous two patches? > Thanks! > Gerry > Hi, I still get kexec shutdown errors like this with the 3rd patch applied: http://www.users.on.net/~arthur.marsh/20151003566.jpg I can still unmount filesystems, modprobe -r eata and modprobe eata to get things into a state where a kexec reboot works. Regards, Arthur. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jiang Liu wrote on 03/10/15 17:41: >> If I do a normal boot which includes eata being loaded, the disk >> attached to the DPT2044W controller having its filesystems checked and >> mounted, then attempt a kexec reboot, I get the reboot pausing after the >> "synchronizing SCSI cache" messages as before. >> >> If I un-mount the filesystems on the disk attached to the DPT2044W >> controller after start-up and try a reboot I get the same problem. >> >> If I do modprobe -r eata after un-mounting the filesystems on the disk >> attached to the DPT2044W controller after a start-up kexec *works fine*. > Hi Arthur, > The above results suggest that we need to shutdown eata > controller for kexec. So could you please try to apply the attached > patch upon the previous two patches? > Thanks! > Gerry > To clarify, if the eata driver gets loaded once and stays loaded, at a kexec reboot attempt the "Synchronising SCSI cache" message is missing for the SCSI disk attached to the controller using the eata driver and eventually other error messages appear as seen in screen images that I have previously posted. If the eata driver is loaded, unloaded via modprobe -r, then reloaded, a kexec reboot shows 2 "Synchronising SCSI cache" messages for the SCSI disk attached to the controller using the eata driver and the kexec reboot is successful. Arthur. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From 44a7ee9008951684a6ee1482a4445a64da61f54a Mon Sep 17 00:00:00 2001 From: Jiang Liu <jiang.liu@linux.intel.com> Date: Sat, 3 Oct 2015 15:57:39 +0800 Subject: [PATCH] eata: Implement shutdown callback for eata driver Implement shutdown callback for eata driver, so eata controllers will be put into ready state for kexec. Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> --- drivers/scsi/eata.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/scsi/eata.c b/drivers/scsi/eata.c index ceeba4d7b4ff..f3ef9ac97646 100644 --- a/drivers/scsi/eata.c +++ b/drivers/scsi/eata.c @@ -1517,6 +1517,11 @@ static void eata2x_pci_remove(struct pci_dev *pdev) pci_disable_device(pdev); } +static void eata2x_pci_shutdown(struct pci_dev *pdev) +{ + port_remove(&pdev->dev); +} + static struct pci_device_id eata2x_tbl[] = { { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_SCSI << 8, PCI_ANY_ID) }, { }, @@ -1528,6 +1533,7 @@ static struct pci_driver eata2x_pci_driver = { .id_table = eata2x_tbl, .probe = eata2x_pci_probe, .remove = eata2x_pci_remove, + .shutdown = eata2x_pci_shutdown, }; static int eata2x_register_pci_driver(void) @@ -1569,8 +1575,14 @@ static int __exit eata2x_platform_remove(struct platform_device *pdev) return 0; } +static void eata2x_platform_shutdown(struct platform_device *pdev) +{ + port_remove(&pdev->dev); +} + static struct platform_driver eata2x_platform_driver = { .remove = __exit_p(eata2x_platform_remove), + .shutdown = eata2x_platform_shutdown, .driver = { .name = "eata_plat", .owner = THIS_MODULE, -- 1.7.10.4