| Message ID | 1442850433-5903-4-git-send-email-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Sep 21, 2015 at 04:46:59PM +0100, Sudeep Holla wrote: > The driver handles wakeup irq correctly using device_init_wakeup and > enable_irq_wake. There's no need to use IRQF_NO_SUSPEND while registering > the interrupt. > > This patch removes the use of IRQF_NO_SUSPEND flag. > > Cc: Laxman Dewangan <ldewangan@nvidia.com> > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: linux-input@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/input/keyboard/tegra-kbc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding <treding@nvidia.com>
On Monday 21 September 2015 09:16 PM, Sudeep Holla wrote: > > diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c > index f97c73bd14f8..5f5dbbd51991 100644 > --- a/drivers/input/keyboard/tegra-kbc.c > +++ b/drivers/input/keyboard/tegra-kbc.c > @@ -705,7 +705,7 @@ static int tegra_kbc_probe(struct platform_device *pdev) > input_set_drvdata(kbc->idev, kbc); > > err = devm_request_irq(&pdev->dev, kbc->irq, tegra_kbc_isr, > - IRQF_NO_SUSPEND | IRQF_TRIGGER_HIGH, pdev->name, kbc); > + IRQF_TRIGGER_HIGH, pdev->name, kbc); > Acked-by: Laxman Dewangan <ldewangan@nvidia.com> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dmitry, On 05/10/15 11:24, Laxman Dewangan wrote: > > On Monday 21 September 2015 09:16 PM, Sudeep Holla wrote: >> >> diff --git a/drivers/input/keyboard/tegra-kbc.c >> b/drivers/input/keyboard/tegra-kbc.c >> index f97c73bd14f8..5f5dbbd51991 100644 >> --- a/drivers/input/keyboard/tegra-kbc.c >> +++ b/drivers/input/keyboard/tegra-kbc.c >> @@ -705,7 +705,7 @@ static int tegra_kbc_probe(struct platform_device >> *pdev) >> input_set_drvdata(kbc->idev, kbc); >> err = devm_request_irq(&pdev->dev, kbc->irq, tegra_kbc_isr, >> - IRQF_NO_SUSPEND | IRQF_TRIGGER_HIGH, pdev->name, kbc); >> + IRQF_TRIGGER_HIGH, pdev->name, kbc); >> > > Acked-by: Laxman Dewangan <ldewangan@nvidia.com> > Can you pick this up with all the Acks ?
On Mon, Oct 19, 2015 at 06:34:02PM +0100, Sudeep Holla wrote: > Hi Dmitry, > > On 05/10/15 11:24, Laxman Dewangan wrote: > > > >On Monday 21 September 2015 09:16 PM, Sudeep Holla wrote: > >> > >>diff --git a/drivers/input/keyboard/tegra-kbc.c > >>b/drivers/input/keyboard/tegra-kbc.c > >>index f97c73bd14f8..5f5dbbd51991 100644 > >>--- a/drivers/input/keyboard/tegra-kbc.c > >>+++ b/drivers/input/keyboard/tegra-kbc.c > >>@@ -705,7 +705,7 @@ static int tegra_kbc_probe(struct platform_device > >>*pdev) > >> input_set_drvdata(kbc->idev, kbc); > >> err = devm_request_irq(&pdev->dev, kbc->irq, tegra_kbc_isr, > >>- IRQF_NO_SUSPEND | IRQF_TRIGGER_HIGH, pdev->name, kbc); > >>+ IRQF_TRIGGER_HIGH, pdev->name, kbc); > >> > > > >Acked-by: Laxman Dewangan <ldewangan@nvidia.com> > > > > Can you pick this up with all the Acks ? Applied, thank you.
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c index f97c73bd14f8..5f5dbbd51991 100644 --- a/drivers/input/keyboard/tegra-kbc.c +++ b/drivers/input/keyboard/tegra-kbc.c @@ -705,7 +705,7 @@ static int tegra_kbc_probe(struct platform_device *pdev) input_set_drvdata(kbc->idev, kbc); err = devm_request_irq(&pdev->dev, kbc->irq, tegra_kbc_isr, - IRQF_NO_SUSPEND | IRQF_TRIGGER_HIGH, pdev->name, kbc); + IRQF_TRIGGER_HIGH, pdev->name, kbc); if (err) { dev_err(&pdev->dev, "failed to request keyboard IRQ\n"); return err;
The driver handles wakeup irq correctly using device_init_wakeup and enable_irq_wake. There's no need to use IRQF_NO_SUSPEND while registering the interrupt. This patch removes the use of IRQF_NO_SUSPEND flag. Cc: Laxman Dewangan <ldewangan@nvidia.com> Cc: Stephen Warren <swarren@wwwdotorg.org> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: linux-input@vger.kernel.org Cc: linux-tegra@vger.kernel.org Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/input/keyboard/tegra-kbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)