diff mbox

INPUT:Change a more clearly name for the input handlers' table

Message ID 1302265424-4434-1-git-send-email-wanlong.gao@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wanlong Gao April 8, 2011, 12:23 p.m. UTC 
From: Wanlong Gao <wanlong.gao@gmail.com>

Change the input handlers' table name to input_handler_table for
making more clearly sense .

Signed-off-by: Wanlong Gao <wanlong.gao@gmail.com>
---
 drivers/input/input.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

Comments

Dmitry Torokhov April 12, 2011, 6:24 a.m. UTC | #1 
On Fri, Apr 08, 2011 at 08:23:44PM +0800, wanlong.gao@gmail.com wrote:
> From: Wanlong Gao <wanlong.gao@gmail.com>
> 
> Change the input handlers' table name to input_handler_table for
> making more clearly sense .
> 

Sorry but I think the old name is fine. I'd rather see this table
removed altogether and character devices pushed down into input handlers
themselves.

Thanks.
Wanlong Gao April 12, 2011, 12:01 p.m. UTC | #2 
On 4/12/11, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On Fri, Apr 08, 2011 at 08:23:44PM +0800, wanlong.gao@gmail.com wrote:
>> From: Wanlong Gao <wanlong.gao@gmail.com>
>>
>> Change the input handlers' table name to input_handler_table for
>> making more clearly sense .
>>
>
> Sorry but I think the old name is fine. I'd rather see this table
> removed altogether and character devices pushed down into input handlers
> themselves.
If so , it will be a really hard work .
Thanks a lot.
>
> Thanks.
>
> --
> Dmitry
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/input/input.c b/drivers/input/input.c
index d6e8bd8..00511dc 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -45,7 +45,7 @@  static LIST_HEAD(input_handler_list);
  */
 static DEFINE_MUTEX(input_mutex);
 
-static struct input_handler *input_table[8];
+static struct input_handler *input_handler_table[8];
 
 static inline int is_event_supported(unsigned int code,
 				     unsigned long *bm, unsigned int max)
@@ -1893,11 +1893,11 @@  int input_register_handler(struct input_handler *handler)
 	INIT_LIST_HEAD(&handler->h_list);
 
 	if (handler->fops != NULL) {
-		if (input_table[handler->minor >> 5]) {
+		if (input_handler_table[handler->minor >> 5]) {
 			retval = -EBUSY;
 			goto out;
 		}
-		input_table[handler->minor >> 5] = handler;
+		input_handler_table[handler->minor >> 5] = handler;
 	}
 
 	list_add_tail(&handler->node, &input_handler_list);
@@ -1933,7 +1933,7 @@  void input_unregister_handler(struct input_handler *handler)
 	list_del_init(&handler->node);
 
 	if (handler->fops != NULL)
-		input_table[handler->minor >> 5] = NULL;
+		input_handler_table[handler->minor >> 5] = NULL;
 
 	input_wakeup_procfs_readers();
 
@@ -2062,7 +2062,7 @@  static int input_open_file(struct inode *inode, struct file *file)
 		return err;
 
 	/* No load-on-demand here? */
-	handler = input_table[iminor(inode) >> 5];
+	handler = input_handler_table[iminor(inode) >> 5];
 	if (handler)
 		new_fops = fops_get(handler->fops);