[1/3] drm/i915/tv: Remember the detected TV type

Commit Message

Chris Wilson April 12, 2011, 5:51 a.m. UTC

From: Mathew McKernan <[e-mail]>

During detect() we would probe the connection bits to determine if
there was a TV attached, and what video input type (Component, S-Video,
Composite, etc) to use. However, we promptly discarded this vital bit of
information and never propagated it to where it was used to determine
the correct modes and setup the control registers. Fix it!

This fixes a regression from 7b334fcb45b757ffb093696ca3de1b0c8b4a33f1.

Reported-and-tested-by: Mathew McKernan <[e-mail]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=35977
Signed-off-by: Mathew McKernan <[e-mail]>
Signed-off-by: Chris Wilson <[e-mail]>
Cc: [e-mail]
---
 drivers/gpu/drm/i915/intel_tv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Paul Menzel April 12, 2011, 8:34 a.m. UTC | #1

Am Dienstag, den 12.04.2011, 06:51 +0100 schrieb Chris Wilson:
> From: Mathew McKernan <[e-mail]>
> 
> During detect() we would probe the connection bits to determine if
> there was a TV attached, and what video input type (Component, S-Video,
> Composite, etc) to use. However, we promptly discarded this vital bit of
> information and never propagated it to where it was used to determine
> the correct modes and setup the control registers. Fix it!
> 
> This fixes a regression from 7b334fcb45b757ffb093696ca3de1b0c8b4a33f1.

To quote Mark Brown [1].

        Always include the subject line of the commit in patches -
        readers are unlikely to have memorised commit IDs.

> Reported-and-tested-by: Mathew McKernan <[e-mail]>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=35977
> Signed-off-by: Mathew McKernan <[e-mail]>
> Signed-off-by: Chris Wilson <[e-mail]>
> Cc: [e-mail]

Acked-by: Paul Menzel <[e-mail]>

[…]


Thanks,

Paul


[1] http://mailman.alsa-project.org/pipermail/alsa-devel/2011-February/037200.html

Chris Wilson April 12, 2011, 8:43 a.m. UTC | #2

On Tue, 12 Apr 2011 10:34:41 +0200, Paul Menzel <[e-mail]> wrote:
> Am Dienstag, den 12.04.2011, 06:51 +0100 schrieb Chris Wilson:
> > This fixes a regression from 7b334fcb45b757ffb093696ca3de1b0c8b4a33f1.
> 
> To quote Mark Brown [1].
> 
>         Always include the subject line of the commit in patches -
>         readers are unlikely to have memorised commit IDs.

Does it really help to include the subject as well? I suppose it will help
in the case where the patch has been cherry-picked into other trees,
stable for instance. However, I truly didn't expect anyone to remember the
original commit as the first thing I do is to read through the identified
commit to try and understand the subsequent patch in context.
-Chris

Paul Menzel April 12, 2011, 9:21 a.m. UTC | #3

Am Dienstag, den 12.04.2011, 09:43 +0100 schrieb Chris Wilson:
> On Tue, 12 Apr 2011 10:34:41 +0200, Paul Menzel <[e-mail]> wrote:
> > Am Dienstag, den 12.04.2011, 06:51 +0100 schrieb Chris Wilson:
> > > This fixes a regression from 7b334fcb45b757ffb093696ca3de1b0c8b4a33f1.
> > 
> > To quote Mark Brown [1].
> > 
> >         Always include the subject line of the commit in patches -
> >         readers are unlikely to have memorised commit IDs.
> 
> Does it really help to include the subject as well? I suppose it will help
> in the case where the patch has been cherry-picked into other trees,
> stable for instance. However, I truly didn't expect anyone to remember the
> original commit as the first thing I do is to read through the identified
> commit to try and understand the subsequent patch in context.

In my opinion the reason is especially the first one you mentioned.


Thanks,

Paul

Patch

diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
index c27887f..84a733b 100644
--- a/drivers/gpu/drm/i915/intel_tv.c
+++ b/drivers/gpu/drm/i915/intel_tv.c
@@ -1356,7 +1356,9 @@  intel_tv_detect(struct drm_connector *connector, bool force)
 	if (type < 0)
 		return connector_status_disconnected;
 
+	intel_tv->type = type;
 	intel_tv_find_better_format(connector);
+
 	return connector_status_connected;
 }