| Message ID | 1444326827-3565-6-git-send-email-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Oct 8, 2015 at 7:53 PM, Rob Herring <robh@kernel.org> wrote: > Enable building all dtb files when CONFIG_OF_ALL_DTBS is enabled. The dtbs > are not really dependent on a platform being enabled or any other kernel > config, so for testing coverage it is convenient to build all of the dtbs. > This builds all dts files in the tree, not just targets listed. This > is simpler for arm64 which has a bunch of sub-dirs. This doesn't look simpler than the arm(32) version? > Signed-off-by: Rob Herring <robh@kernel.org> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm64/boot/dts/Makefile | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile > index d9f8833..b01ec43 100644 > --- a/arch/arm64/boot/dts/Makefile > +++ b/arch/arm64/boot/dts/Makefile > @@ -14,3 +14,9 @@ dts-dirs += sprd > dts-dirs += xilinx > > subdir-y := $(dts-dirs) > + > +dtstree := $(srctree)/$(src) > + > +dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(foreach d,$(dts-dirs), $(wildcard $(dtstree)/$(d)/*.dts))) > +
On Thu, Oct 8, 2015 at 1:15 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Thu, Oct 8, 2015 at 7:53 PM, Rob Herring <robh@kernel.org> wrote: >> Enable building all dtb files when CONFIG_OF_ALL_DTBS is enabled. The dtbs >> are not really dependent on a platform being enabled or any other kernel >> config, so for testing coverage it is convenient to build all of the dtbs. >> This builds all dts files in the tree, not just targets listed. This >> is simpler for arm64 which has a bunch of sub-dirs. > > This doesn't look simpler than the arm(32) version? I discussed this with Olof in the last version. In the ARM version, I could have done just one line "dtb-$(CONFIG_OF_ALL_DTBS) += $(dtb-)" to add all the disabled dtbs. On arm64, I would have to do that for each sub-dir Makefile as well as make sure any new sub-dirs have this line. In the end, I also prefer to build everything in the tree and not rely on the dtbs to be explicitly listed. Rob
diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile index d9f8833..b01ec43 100644 --- a/arch/arm64/boot/dts/Makefile +++ b/arch/arm64/boot/dts/Makefile @@ -14,3 +14,9 @@ dts-dirs += sprd dts-dirs += xilinx subdir-y := $(dts-dirs) + +dtstree := $(srctree)/$(src) + +dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(foreach d,$(dts-dirs), $(wildcard $(dtstree)/$(d)/*.dts))) + +always := $(dtb-y)
Enable building all dtb files when CONFIG_OF_ALL_DTBS is enabled. The dtbs are not really dependent on a platform being enabled or any other kernel config, so for testing coverage it is convenient to build all of the dtbs. This builds all dts files in the tree, not just targets listed. This is simpler for arm64 which has a bunch of sub-dirs. Signed-off-by: Rob Herring <robh@kernel.org> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> Cc: linux-arm-kernel@lists.infradead.org --- arch/arm64/boot/dts/Makefile | 6 ++++++ 1 file changed, 6 insertions(+)