diff mbox

[RFC] PCI: spear: Fix definition of LTSSM_STATE_MASK

Message ID 1444015275-5668-1-git-send-email-festevam@gmail.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Fabio Estevam Oct. 5, 2015, 3:21 a.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

Designware PCI block uses 0x3f for the LTSSM_STATE_MASK.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Murali,

I am doing some consolidation on the PCI DW drivers and I noticed that
keystone uses a different LTSSM_STATE_MASK definition.

Could you please double check it?

 drivers/pci/host/pci-keystone-dw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Oct. 9, 2015, 1:20 a.m. UTC | #1 
On Mon, Oct 5, 2015 at 12:21 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Designware PCI block uses 0x3f for the LTSSM_STATE_MASK.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Murali,
>
> I am doing some consolidation on the PCI DW drivers and I noticed that
> keystone uses a different LTSSM_STATE_MASK definition.
>
> Could you please double check it?

Ok, checked in http://www.ti.com/lit/ug/sprugs6d/sprugs6d.pdf and
LTSSM_STATE_MASK is only 5 bits, so the current code is correct.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c
index 3cf55cd..78320e4 100644
--- a/drivers/pci/host/pci-keystone-dw.c
+++ b/drivers/pci/host/pci-keystone-dw.c
@@ -25,7 +25,7 @@ 
 
 /* Application register defines */
 #define LTSSM_EN_VAL		        1
-#define LTSSM_STATE_MASK		0x1f
+#define LTSSM_STATE_MASK		0x3f
 #define LTSSM_STATE_L0			0x11
 #define DBI_CS2_EN_VAL			0x20
 #define OB_XLAT_EN_VAL		        2