[v3,4/9] clk: qcom: create virtual child device for TSENS

Commit Message

Stephen Boyd Oct. 8, 2015, 11:21 p.m. UTC

On 10/08, Rajendra Nayak wrote:
> 8960 family of devices have TSENS as part of GCC in hardware.
> Hence DT would represent a GCC node with GCC properties as well
> as TSENS. Create a virtual platform child device here for TSENS
> so the driver can probe it and use the parent (GCC) to extract DT
> properties.
> 
> Suggested-by: Stephen Boyd <[e-mail]>
> Signed-off-by: Rajendra Nayak <[e-mail]>
> ---

Applied to clk-next with some massaging. Is there going to be an
update to the gcc binding too?

---8<----
From: Rajendra Nayak <[e-mail]>
Subject: [PATCH] clk: qcom: create virtual child device for TSENS

8960 family of devices have TSENS as part of GCC in hardware.
Hence DT would represent a GCC node with GCC properties as well
as TSENS. Create a virtual platform child device here for TSENS
so the driver can probe it and use the parent (GCC) to extract DT
properties.

Suggested-by: Stephen Boyd <[e-mail]>
Signed-off-by: Rajendra Nayak <[e-mail]>
[[e-mail]: Massaged to work with devm friendly
qcom_cc_probe()]
Signed-off-by: Stephen Boyd <[e-mail]>
---
 drivers/clk/qcom/gcc-msm8960.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

Comments

Rajendra Nayak Oct. 9, 2015, 3:14 a.m. UTC | #1

On 10/09/2015 04:51 AM, Stephen Boyd wrote:
> On 10/08, Rajendra Nayak wrote:
>> 8960 family of devices have TSENS as part of GCC in hardware.
>> Hence DT would represent a GCC node with GCC properties as well
>> as TSENS. Create a virtual platform child device here for TSENS
>> so the driver can probe it and use the parent (GCC) to extract DT
>> properties.
>>
>> Suggested-by: Stephen Boyd <[e-mail]>
>> Signed-off-by: Rajendra Nayak <[e-mail]>
>> ---
> 
> Applied to clk-next with some massaging. Is there going to be an
> update to the gcc binding too?

Thanks, I will update the gcc bindings as part of the patch which
adds support for 8960 tsens.

Patch

diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c
index b52153903893..66c18bc97857 100644
--- a/drivers/clk/qcom/gcc-msm8960.c
+++ b/drivers/clk/qcom/gcc-msm8960.c
@@ -3506,6 +3506,8 @@  static int gcc_msm8960_probe(struct platform_device *pdev)
 	struct clk *clk;
 	struct device *dev = &pdev->dev;
 	const struct of_device_id *match;
+	struct platform_device *tsens;
+	int ret;
 
 	match = of_match_device(gcc_msm8960_match_table, &pdev->dev);
 	if (!match)
@@ -3520,11 +3522,26 @@  static int gcc_msm8960_probe(struct platform_device *pdev)
 	if (IS_ERR(clk))
 		return PTR_ERR(clk);
 
-	return qcom_cc_probe(pdev, match->data);
+	ret = qcom_cc_probe(pdev, match->data);
+	if (ret)
+		return ret;
+
+	tsens = platform_device_register_data(&pdev->dev, "qcom-tsens", -1,
+					      NULL, 0);
+	if (IS_ERR(tsens))
+		return PTR_ERR(tsens);
+
+	platform_set_drvdata(pdev, tsens);
+
+	return 0;
 }
 
 static int gcc_msm8960_remove(struct platform_device *pdev)
 {
+	struct platform_device *tsens = platform_get_drvdata(pdev);
+
+	platform_device_unregister(tsens);
+
 	return 0;
 }