| Message ID | 1444388979-12072-2-git-send-email-siarhei.siamashka@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Oct 09, 2015 at 02:09:37PM +0300, Siarhei Siamashka wrote: > The pcDuino1 board does not use any power switches at all for its > two USB host ports and the VBUS pins are always connected to 5V. > > The pcDuino2 board uses the RT9701GB power switch for its single > USB host port, but the USB_EN pin (PD2) is pulled up with a 10K > resistor. So that the USB power is still enabled by default, > resulting in the same behaviour as pcDuino1 if nobody touches > the PD2 pin. This minor difference is going to be handled in a > follow-up patch, introducing a separate dts file for pcDuino2. > > The primary reason for this fix is that the current dts file > unnecessarily meddles with the PH3 and PH6 pins. But the PH6 pin > is available on the Arduino-compatible expansion header and may > have a better use for other purposes. This patch fixes the > problem and now the PH6 pin can be used with the GPIO sysfs > interface. Tested on a pcDuino2 board with a multimeter: > > echo 230 > /sys/class/gpio/export > echo "out" > /sys/class/gpio/gpio230/direction > echo 0 > /sys/class/gpio/gpio230/value > echo 1 > /sys/class/gpio/gpio230/value > > USB still works as expected too. > > Signed-off-by: Siarhei Siamashka <siarhei.siamashka@gmail.com> Applied, thanks! Maxime
diff --git a/arch/arm/boot/dts/sun4i-a10-pcduino.dts b/arch/arm/boot/dts/sun4i-a10-pcduino.dts index c882421..0b45d27 100644 --- a/arch/arm/boot/dts/sun4i-a10-pcduino.dts +++ b/arch/arm/boot/dts/sun4i-a10-pcduino.dts @@ -180,14 +180,6 @@ }; }; -®_usb1_vbus { - status = "okay"; -}; - -®_usb2_vbus { - status = "okay"; -}; - #include "axp209.dtsi" ®_dcdc2 { @@ -222,7 +214,7 @@ }; &usbphy { - usb1_vbus-supply = <®_usb1_vbus>; - usb2_vbus-supply = <®_usb2_vbus>; + usb1_vbus-supply = <®_vcc5v0>; /* USB1 VBUS is always on */ + usb2_vbus-supply = <®_vcc5v0>; /* USB2 VBUS is always on */ status = "okay"; };
The pcDuino1 board does not use any power switches at all for its two USB host ports and the VBUS pins are always connected to 5V. The pcDuino2 board uses the RT9701GB power switch for its single USB host port, but the USB_EN pin (PD2) is pulled up with a 10K resistor. So that the USB power is still enabled by default, resulting in the same behaviour as pcDuino1 if nobody touches the PD2 pin. This minor difference is going to be handled in a follow-up patch, introducing a separate dts file for pcDuino2. The primary reason for this fix is that the current dts file unnecessarily meddles with the PH3 and PH6 pins. But the PH6 pin is available on the Arduino-compatible expansion header and may have a better use for other purposes. This patch fixes the problem and now the PH6 pin can be used with the GPIO sysfs interface. Tested on a pcDuino2 board with a multimeter: echo 230 > /sys/class/gpio/export echo "out" > /sys/class/gpio/gpio230/direction echo 0 > /sys/class/gpio/gpio230/value echo 1 > /sys/class/gpio/gpio230/value USB still works as expected too. Signed-off-by: Siarhei Siamashka <siarhei.siamashka@gmail.com> --- arch/arm/boot/dts/sun4i-a10-pcduino.dts | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)