| Message ID | 1444480914-20269-1-git-send-email-kholmanskikh.s.s@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
On Sat, Oct 10, 2015 at 03:41:54PM +0300, Stanislav Kholmanskikh wrote: > The config option in the subject may be removed, because, > indeed, it only serves as the 'n' value for > CONFIG_WILC1000_PREALLOCATE_AT_LOADING_DRIVER > > Signed-off-by: Stanislav Kholmanskikh <kholmanskikh.s.s@gmail.com> > --- > drivers/staging/wilc1000/Kconfig | 15 ++------------- > drivers/staging/wilc1000/Makefile | 3 --- > 2 files changed, 2 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/wilc1000/Kconfig b/drivers/staging/wilc1000/Kconfig > index 59ccecc..2701a01 100644 > --- a/drivers/staging/wilc1000/Kconfig > +++ b/drivers/staging/wilc1000/Kconfig > @@ -6,27 +6,16 @@ config WILC1000 > ---help--- > This module only support IEEE 802.11n WiFi. > > -choice > - prompt "Memory Allocation" > - depends on WILC1000 > - default WILC1000_PREALLOCATE_AT_LOADING_DRIVER > - > config WILC1000_PREALLOCATE_AT_LOADING_DRIVER > bool "Preallocate memory at loading driver" > + depends on WILC1000 > + default y Hm, why have this now? Both of these options should go away, please work on fixing up the code to not need them and then delete the options, right now you are just deleting config options which doesn't seem wise. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/wilc1000/Kconfig b/drivers/staging/wilc1000/Kconfig index 59ccecc..2701a01 100644 --- a/drivers/staging/wilc1000/Kconfig +++ b/drivers/staging/wilc1000/Kconfig @@ -6,27 +6,16 @@ config WILC1000 ---help--- This module only support IEEE 802.11n WiFi. -choice - prompt "Memory Allocation" - depends on WILC1000 - default WILC1000_PREALLOCATE_AT_LOADING_DRIVER - config WILC1000_PREALLOCATE_AT_LOADING_DRIVER bool "Preallocate memory at loading driver" + depends on WILC1000 + default y ---help--- This choice supports static allocation of the memory for the receive buffer. The driver will allocate the RX buffer during initial time. The driver will also free the buffer by calling network device stop. -config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY - bool "Dynamically allocate memory in real time" - ---help--- - This choice supports dynamic allocation of the memory - for the receive buffer. The driver will allocate the RX buffer - when it is required. -endchoice - choice prompt "Bus Type" depends on WILC1000 diff --git a/drivers/staging/wilc1000/Makefile b/drivers/staging/wilc1000/Makefile index f495061..eb8f51d 100644 --- a/drivers/staging/wilc1000/Makefile +++ b/drivers/staging/wilc1000/Makefile @@ -15,9 +15,6 @@ ccflags-y += -I$(src)/ -D__CHECK_ENDIAN__ -DWILC_ASIC_A0 \ ccflags-$(CONFIG_WILC1000_PREALLOCATE_AT_LOADING_DRIVER) += -DMEMORY_STATIC \ -DWILC_PREALLOC_AT_INSMOD -ccflags-$(CONFIG_WILC1000_DYNAMICALLY_ALLOCATE_MEMROY) += -DWILC_NORMAL_ALLOC - - wilc1000-objs := wilc_wfi_cfgoperations.o linux_wlan.o linux_mon.o \ wilc_msgqueue.o \ coreconfigurator.o host_interface.o \
The config option in the subject may be removed, because, indeed, it only serves as the 'n' value for CONFIG_WILC1000_PREALLOCATE_AT_LOADING_DRIVER Signed-off-by: Stanislav Kholmanskikh <kholmanskikh.s.s@gmail.com> --- drivers/staging/wilc1000/Kconfig | 15 ++------------- drivers/staging/wilc1000/Makefile | 3 --- 2 files changed, 2 insertions(+), 16 deletions(-)