diff mbox

thermal: kconfig: When possible, compile drivers with COMPILE_TEST

Message ID 1444839380-29236-1-git-send-email-luisbg@osg.samsung.com (mailing list archive)
State Superseded, archived
Delegated to: Zhang Rui
Headers show

Commit Message

Luis de Bethencourt Oct. 14, 2015, 4:16 p.m. UTC
These drivers only have runtime but no build time dependencies, so they can
be built for testing purposes if the Kconfig COMPILE_TEST option is enabled.

This is useful to have more build coverage and make sure that drivers are
not affected by changes that could cause build regressions.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
 drivers/thermal/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

kernel test robot Oct. 14, 2015, 6:29 p.m. UTC | #1
Hi Luis,

[auto build test ERROR on thermal/next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Luis-de-Bethencourt/thermal-kconfig-When-possible-compile-drivers-with-COMPILE_TEST/20151015-001830
config: arm64-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

>> drivers/thermal/intel_quark_dts_thermal.c:64:31: fatal error: asm/cpu_device_id.h: No such file or directory
    #include <asm/cpu_device_id.h>
                                  ^
   compilation terminated.

vim +64 drivers/thermal/intel_quark_dts_thermal.c

8c187693 Ong, Boon Leong 2015-04-15  48   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
8c187693 Ong, Boon Leong 2015-04-15  49   * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
8c187693 Ong, Boon Leong 2015-04-15  50   * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
8c187693 Ong, Boon Leong 2015-04-15  51   * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
8c187693 Ong, Boon Leong 2015-04-15  52   * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
8c187693 Ong, Boon Leong 2015-04-15  53   *
8c187693 Ong, Boon Leong 2015-04-15  54   * Quark DTS thermal driver is implemented by referencing
8c187693 Ong, Boon Leong 2015-04-15  55   * intel_soc_dts_thermal.c.
8c187693 Ong, Boon Leong 2015-04-15  56   */
8c187693 Ong, Boon Leong 2015-04-15  57  
8c187693 Ong, Boon Leong 2015-04-15  58  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
8c187693 Ong, Boon Leong 2015-04-15  59  
8c187693 Ong, Boon Leong 2015-04-15  60  #include <linux/module.h>
8c187693 Ong, Boon Leong 2015-04-15  61  #include <linux/slab.h>
8c187693 Ong, Boon Leong 2015-04-15  62  #include <linux/interrupt.h>
8c187693 Ong, Boon Leong 2015-04-15  63  #include <linux/thermal.h>
8c187693 Ong, Boon Leong 2015-04-15 @64  #include <asm/cpu_device_id.h>
8c187693 Ong, Boon Leong 2015-04-15  65  #include <asm/iosf_mbi.h>
8c187693 Ong, Boon Leong 2015-04-15  66  
8c187693 Ong, Boon Leong 2015-04-15  67  #define X86_FAMILY_QUARK	0x5
8c187693 Ong, Boon Leong 2015-04-15  68  #define X86_MODEL_QUARK_X1000	0x9
8c187693 Ong, Boon Leong 2015-04-15  69  
8c187693 Ong, Boon Leong 2015-04-15  70  /* DTS reset is programmed via QRK_MBI_UNIT_SOC */
8c187693 Ong, Boon Leong 2015-04-15  71  #define QRK_DTS_REG_OFFSET_RESET	0x34
8c187693 Ong, Boon Leong 2015-04-15  72  #define QRK_DTS_RESET_BIT		BIT(0)

:::::: The code at line 64 was first introduced by commit
:::::: 8c1876939663191b5044807230fa295f35462215 thermal: intel Quark SoC X1000 DTS thermal driver

:::::: TO: Ong, Boon Leong <boon.leong.ong@intel.com>
:::::: CC: Zhang Rui <rui.zhang@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
diff mbox

Patch

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index a94ebb5..844c219 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -252,7 +252,7 @@  config TEGRA_SOCTHERM
 
 config DB8500_CPUFREQ_COOLING
 	tristate "DB8500 cpufreq cooling"
-	depends on ARCH_U8500
+	depends on ARCH_U8500 || COMPILE_TEST
 	depends on CPU_THERMAL
 	default y
 	help
@@ -309,7 +309,7 @@  config INTEL_SOC_DTS_THERMAL
 
 config INTEL_QUARK_DTS_THERMAL
 	tristate "Intel Quark DTS thermal driver"
-	depends on X86_INTEL_QUARK
+	depends on X86_INTEL_QUARK || COMPILE_TEST
 	help
 	  Enable this to register Intel Quark SoC (e.g. X1000) platform digital
 	  temperature sensor (DTS). For X1000 SoC, it has one on-die DTS.