diff mbox

ARM: shmobile: porter: add HS-USB DT support

Message ID 80272771.MSjafmr6yE@wasted.cogentembedded.com (mailing list archive)
State Accepted
Commit c794f6a09a251e229b122082eff1f85b994d2bca
Headers show

Commit Message

Sergei Shtylyov Oct. 14, 2015, 7:35 p.m. UTC
Enable HS-USB device  for the Porter board, defining the GPIO that the
driver should check  when probing (which is the ID output from MAX3355
OTG chip).

Note that there  will be pinctrl-related error messages if both internal
PCI  and  HS-USB drivers are enabled but they should be just ignored.

This patch is  analogous  to the commit 6f4f7156e0e6 (ARM: shmobile:
henninger: enable HS-USB) as there  are no differences between the
boards in this respect.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is against 'renesas-devel-20151013v2-v4.3-rc5' tag of Simon Horman's
'renesas.git' repo.

 arch/arm/boot/dts/r8a7791-porter.dts |    8 ++++++++
 1 file changed, 8 insertions(+)


--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Simon Horman Oct. 15, 2015, 12:18 a.m. UTC | #1
On Wed, Oct 14, 2015 at 10:35:46PM +0300, Sergei Shtylyov wrote:
> Enable HS-USB device  for the Porter board, defining the GPIO that the
> driver should check  when probing (which is the ID output from MAX3355
> OTG chip).
> 
> Note that there  will be pinctrl-related error messages if both internal
> PCI  and  HS-USB drivers are enabled but they should be just ignored.
> 
> This patch is  analogous  to the commit 6f4f7156e0e6 (ARM: shmobile:
> henninger: enable HS-USB) as there  are no differences between the
> boards in this respect.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 

Thanks Sergei,

I have queued this up for v4.5.

I took the liberty of tweaking the changelog to address a complaint made
by Mr. Check Patch.

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6f4f7156e0e6 ("ARM: shmobile: henninger: enable HS-USB")'
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov Oct. 15, 2015, 10:27 a.m. UTC | #2
Hello.

On 10/15/2015 3:18 AM, Simon Horman wrote:

>> Enable HS-USB device  for the Porter board, defining the GPIO that the
>> driver should check  when probing (which is the ID output from MAX3355
>> OTG chip).
>>
>> Note that there  will be pinctrl-related error messages if both internal
>> PCI  and  HS-USB drivers are enabled but they should be just ignored.
>>
>> This patch is  analogous  to the commit 6f4f7156e0e6 (ARM: shmobile:
>> henninger: enable HS-USB) as there  are no differences between the
>> boards in this respect.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Thanks Sergei,
>
> I have queued this up for v4.5.
>
> I took the liberty of tweaking the changelog to address a complaint made
> by Mr. Check Patch.

    Which means I forgot to run it again. Sorry about that. :-<

> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6f4f7156e0e6 ("ARM: shmobile: henninger: enable HS-USB")'

    Keep forgetting about the now enforced quotes...

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

Index: renesas/arch/arm/boot/dts/r8a7791-porter.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7791-porter.dts
+++ renesas/arch/arm/boot/dts/r8a7791-porter.dts
@@ -269,6 +269,14 @@ 
 	status = "okay";
 };
 
+&hsusb {
+	pinctrl-0 = <&usb0_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+	renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>;
+};
+
 &usbphy {
 	status = "okay";
 };