| Message ID | 1441055010-25974-1-git-send-email-bob.j.paauwe@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Aug 31, 2015 at 02:03:30PM -0700, Bob Paauwe wrote: > Extend this to SKL and BXT as it's needed for these platforms as well. > > v2: Change if condition to HAS_DDI() instead of listing each platform > Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 88f9764..ba180f6 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -10001,7 +10001,7 @@ static void i9xx_update_cursor(struct drm_crtc *crtc, u32 base) > } > cntl |= pipe << 28; /* Connect to correct pipe */ > > - if (IS_HASWELL(dev) || IS_BROADWELL(dev)) > + if (HAS_DDI(dev)) Yeah, while cursors themselves don't change between non-DDI and DDI platforms, the reason for this stuff is the fact that that we use the pipe csc for HDMI color range mangling on DDI platforms, since they no longer have any other pipe/port controls for it. So makese sense to check for DDI here too I think: Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > cntl |= CURSOR_PIPE_CSC_ENABLE; > } > > -- > 2.1.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Oct 15, 2015 at 03:49:44PM +0300, Ville Syrjälä wrote: > On Mon, Aug 31, 2015 at 02:03:30PM -0700, Bob Paauwe wrote: > > Extend this to SKL and BXT as it's needed for these platforms as well. > > > > v2: Change if condition to HAS_DDI() instead of listing each platform > > Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com> > > --- > > drivers/gpu/drm/i915/intel_display.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > > index 88f9764..ba180f6 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -10001,7 +10001,7 @@ static void i9xx_update_cursor(struct drm_crtc *crtc, u32 base) > > } > > cntl |= pipe << 28; /* Connect to correct pipe */ > > > > - if (IS_HASWELL(dev) || IS_BROADWELL(dev)) > > + if (HAS_DDI(dev)) > > Yeah, while cursors themselves don't change between non-DDI and DDI > platforms, the reason for this stuff is the fact that that we use > the pipe csc for HDMI color range mangling on DDI platforms, since > they no longer have any other pipe/port controls for it. > > So makese sense to check for DDI here too I think: > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Both patches applied, thanks. -Daniel > > > cntl |= CURSOR_PIPE_CSC_ENABLE; > > } > > > > -- > > 2.1.0 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Ville Syrjälä > Intel OTC > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 88f9764..ba180f6 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -10001,7 +10001,7 @@ static void i9xx_update_cursor(struct drm_crtc *crtc, u32 base) } cntl |= pipe << 28; /* Connect to correct pipe */ - if (IS_HASWELL(dev) || IS_BROADWELL(dev)) + if (HAS_DDI(dev)) cntl |= CURSOR_PIPE_CSC_ENABLE; }
Extend this to SKL and BXT as it's needed for these platforms as well. v2: Change if condition to HAS_DDI() instead of listing each platform Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)