| Message ID | 1444919327-23747-1-git-send-email-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 15 October 2015 16:28:45 Hans de Goede wrote: > When the gpio interrupt bindings where changed to add a bank to the > specifier list, the r_pio nodes of A23/A31/A33 where not updated to > match and neither was the pio node of the A80, this fixes this. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > Is this safe to apply by itself? I don't see any interrupts references to these nodes, so I assume it's fine, but if there are any cross-dependencies we need more careful planning. Arnd
Hi, On 15-10-15 16:38, Arnd Bergmann wrote: > On Thursday 15 October 2015 16:28:45 Hans de Goede wrote: >> When the gpio interrupt bindings where changed to add a bank to the >> specifier list, the r_pio nodes of A23/A31/A33 where not updated to >> match and neither was the pio node of the A80, this fixes this. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> > > Is this safe to apply by itself? I don't see any interrupts references > to these nodes, so I assume it's fine, but if there are any cross-dependencies > we need more careful planning. Should be safe to apply by itself, later patches in this series introduce the first interrupt users of these nodes, which is what made me notice the mistake in them. Regards, Hans
diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi index 98359f3..a97274a8 100644 --- a/arch/arm/boot/dts/sun6i-a31.dtsi +++ b/arch/arm/boot/dts/sun6i-a31.dtsi @@ -1102,7 +1102,7 @@ resets = <&apb0_rst 0>; gpio-controller; interrupt-controller; - #interrupt-cells = <2>; + #interrupt-cells = <3>; #size-cells = <0>; #gpio-cells = <3>; diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi index 828aaf5..ddb9890 100644 --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi @@ -647,6 +647,7 @@ resets = <&apb0_rst 0>; gpio-controller; interrupt-controller; + #interrupt-cells = <3>; #address-cells = <1>; #size-cells = <0>; #gpio-cells = <3>; diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi index 5908e3d..1118bf5 100644 --- a/arch/arm/boot/dts/sun9i-a80.dtsi +++ b/arch/arm/boot/dts/sun9i-a80.dtsi @@ -594,7 +594,7 @@ clocks = <&apb0_gates 5>; gpio-controller; interrupt-controller; - #interrupt-cells = <2>; + #interrupt-cells = <3>; #size-cells = <0>; #gpio-cells = <3>;
When the gpio interrupt bindings where changed to add a bank to the specifier list, the r_pio nodes of A23/A31/A33 where not updated to match and neither was the pio node of the A80, this fixes this. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- arch/arm/boot/dts/sun6i-a31.dtsi | 2 +- arch/arm/boot/dts/sun8i-a23-a33.dtsi | 1 + arch/arm/boot/dts/sun9i-a80.dtsi | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-)