diff mbox

[v2,1/2] dt-bindings: Add new boards to bcm4708 DT bindings

Message ID 1444860890-28649-2-git-send-email-jonmason@broadcom.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jon Mason Oct. 14, 2015, 10:14 p.m. UTC
Add the 4708, 4709, and 953012k SVKs to the the documentation for the
Broadcom Northstar device tree bindings.

Signed-off-by: Jon Mason <jonmason@broadcom.com>
---
 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Hauke Mehrtens Oct. 15, 2015, 8:52 p.m. UTC | #1
On 10/15/2015 12:14 AM, Jon Mason wrote:
> Add the 4708, 4709, and 953012k SVKs to the the documentation for the
> Broadcom Northstar device tree bindings.
> 
> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> ---
>  Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> index 6b0f49f..b9cc308 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties:
>  
>  Required root node property:
>  
> +bcm94708

I thought we wanted to add the SoC names here, isn't bcm94708 a board
the bcm4708, the SoC ion this board? I do not really care about this
file, has anyone found the documentation what should be listed here?

Hauke

>  compatible = "brcm,bcm4708";
> +
> +bcm94709
> +compatible = "brcm,bcm4709";
> +
> +bcm953012
> +compatible = "brcm,bcm53012";
>
Scott Branden Oct. 15, 2015, 8:59 p.m. UTC | #2
On 15-10-15 01:52 PM, Hauke Mehrtens wrote:
> On 10/15/2015 12:14 AM, Jon Mason wrote:
>> Add the 4708, 4709, and 953012k SVKs to the the documentation for the
>> Broadcom Northstar device tree bindings.
>>
>> Signed-off-by: Jon Mason <jonmason@broadcom.com>
>> ---
>>   Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>> index 6b0f49f..b9cc308 100644
>> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>> @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties:
>>
>>   Required root node property:
>>
>> +bcm94708
this should be bcm4708
>
> I thought we wanted to add the SoC names here, isn't bcm94708 a board
> the bcm4708, the SoC ion this board? I do not really care about this
> file, has anyone found the documentation what should be listed here?

Yes - the 9 infront indicates its some type of board.  The SoC part 
numbers should be listed here.  The SoCs are all variants of 
Northstar/Northstar plus family.  Some have different io, packaging, 
speed grades, etc.

>
> Hauke
>
>>   compatible = "brcm,bcm4708";
>> +
>> +bcm94709
This should be bcm4709
>> +compatible = "brcm,bcm4709";
>> +
>> +bcm953012
This should be bcm53012
>> +compatible = "brcm,bcm53012";
>>
>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
index 6b0f49f..b9cc308 100644
--- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
@@ -5,4 +5,11 @@  Boards with the BCM4708 SoC shall have the following properties:
 
 Required root node property:
 
+bcm94708
 compatible = "brcm,bcm4708";
+
+bcm94709
+compatible = "brcm,bcm4709";
+
+bcm953012
+compatible = "brcm,bcm53012";