| Message ID | 1445234635-3950-3-git-send-email-alim.akhtar@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 19 October 2015 11:33 AM, Alim Akhtar wrote: > This patch adds syscon-{reboot, poweroff} nodes to allow the > generic syscon-{reboot, poweroff} driver to reset/poweroff exynos4 SoC. > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > > --- > arch/arm/boot/dts/exynos4.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com> Thanks, Pankaj Dubey
Hello Alim, On 10/19/2015 08:03 AM, Alim Akhtar wrote: > This patch adds syscon-{reboot, poweroff} nodes to allow the > generic syscon-{reboot, poweroff} driver to reset/poweroff exynos4 SoC. > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > arch/arm/boot/dts/exynos4.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index 98c0a368b777..79015320cdb6 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -158,6 +158,20 @@ > interrupt-parent = <&gic>; > }; > > + poweroff: syscon-poweroff { > + compatible = "syscon-poweroff"; > + regmap = <&pmu_system_controller>; > + offset = <0x330C>; > + mask = <0x5200>; > + }; > + > + reboot: syscon-reboot { > + compatible = "syscon-reboot"; > + regmap = <&pmu_system_controller>; > + offset = <0x0400>; > + mask = <0x1>; > + }; > + The same comment of patch 1/7 applies to the other DTS changes. I would prefer if the the offset value is documented but as I said it could be a follow up. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 98c0a368b777..79015320cdb6 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -158,6 +158,20 @@ interrupt-parent = <&gic>; }; + poweroff: syscon-poweroff { + compatible = "syscon-poweroff"; + regmap = <&pmu_system_controller>; + offset = <0x330C>; + mask = <0x5200>; + }; + + reboot: syscon-reboot { + compatible = "syscon-reboot"; + regmap = <&pmu_system_controller>; + offset = <0x0400>; + mask = <0x1>; + }; + dsi_0: dsi@11C80000 { compatible = "samsung,exynos4210-mipi-dsi"; reg = <0x11C80000 0x10000>;
This patch adds syscon-{reboot, poweroff} nodes to allow the generic syscon-{reboot, poweroff} driver to reset/poweroff exynos4 SoC. Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- arch/arm/boot/dts/exynos4.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+)