| Message ID | 1445332995-11212-2-git-send-email-Liviu.Dudau@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Liviu, On 20 October 2015 at 10:23, Liviu Dudau <Liviu.Dudau@arm.com> wrote: > A lot of component based DRM drivers use a variant of the same code > as the probe function. They bind the crtc ports in the first iteration > and then scan through the child nodes and bind the encoders attached > to the remote endpoints. Factor the common code into a separate > function called drm_of_component_probe() in order to increase code > reuse. > > Cc: David Airlie <airlied@linux.ie> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk> > --- > drivers/gpu/drm/drm_of.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++ > include/drm/drm_of.h | 13 +++++++ > 2 files changed, 101 insertions(+) > > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c > index be38840..493c05c 100644 > --- a/drivers/gpu/drm/drm_of.c > +++ b/drivers/gpu/drm/drm_of.c > @@ -1,3 +1,4 @@ > +#include <linux/component.h> > #include <linux/export.h> > #include <linux/list.h> > #include <linux/of_graph.h> > @@ -61,3 +62,90 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev, > return possible_crtcs; > } > EXPORT_SYMBOL(drm_of_find_possible_crtcs); > + > +/** > + * drm_of_component_probe - Generic probe function for a component based master > + * @dev: master device containing the OF node > + * @compare_of: compare function used for matching components > + * @master_ops: component master ops to be used > + * > + * Parse the platform device OF node and bind all the components associated > + * with the master. Interface ports are added before the encoders in order to > + * satisfy their .bind requirements > + * See Documentation/devicetree/bindings/graph.txt for the bindings. > + * > + * Returns zero if successful, or one of the standard error codes if it fails. > + */ > +int drm_of_component_probe(struct device *dev, > + int (*compare_of)(struct device *, void *), > + const struct component_master_ops *m_ops) > +{ > + struct device_node *ep, *port, *remote; > + struct component_match *match = NULL; > + int i; > + > + if (!dev->of_node) > + return -EINVAL; > + > + /* > + * Bind the crtc's ports first, so that drm_of_find_possible_crtcs() > + * called from encoder's .bind callbacks works as expected > + */ > + for (i = 0; ; i++) { > + port = of_parse_phandle(dev->of_node, "ports", i); > + if (!port) > + break; > + > + if (!of_device_is_available(port->parent)) { > + of_node_put(port); > + continue; > + } > + > + component_match_add(dev, &match, compare_of, port); > + of_node_put(port); > + } > + > + if (i == 0) { > + dev_err(dev, "missing 'ports' property\n"); > + return -ENODEV; > + } > + > + if (!match) { > + dev_err(dev, "no available port\n"); > + return -ENODEV; > + } > + > + /* > + * For bound crtcs, bind the encoders attached to their remote endpoint > + */ > + for (i = 0; ; i++) { > + port = of_parse_phandle(dev->of_node, "ports", i); > + if (!port) > + break; > + > + if (!of_device_is_available(port->parent)) { > + of_node_put(port); > + continue; > + } > + Of the three drivers converted only the rockchip one has the above of_device_is_available() hunk. Based on the handling in previous loop I'm not entirely sure if it's needed, but if so shouldn't one mention the difference when converting the respective drivers ? I'm not working on/familiar with either of these drivers so this is just a fly-by comment. Cheers, Emil
On Tue, Oct 20, 2015 at 11:00:55AM +0100, Emil Velikov wrote: > Hi Liviu, > > On 20 October 2015 at 10:23, Liviu Dudau <Liviu.Dudau@arm.com> wrote: > > A lot of component based DRM drivers use a variant of the same code > > as the probe function. They bind the crtc ports in the first iteration > > and then scan through the child nodes and bind the encoders attached > > to the remote endpoints. Factor the common code into a separate > > function called drm_of_component_probe() in order to increase code > > reuse. > > > > Cc: David Airlie <airlied@linux.ie> > > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> > > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk> > > --- > > drivers/gpu/drm/drm_of.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++ > > include/drm/drm_of.h | 13 +++++++ > > 2 files changed, 101 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c > > index be38840..493c05c 100644 > > --- a/drivers/gpu/drm/drm_of.c > > +++ b/drivers/gpu/drm/drm_of.c > > @@ -1,3 +1,4 @@ > > +#include <linux/component.h> > > #include <linux/export.h> > > #include <linux/list.h> > > #include <linux/of_graph.h> > > @@ -61,3 +62,90 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev, > > return possible_crtcs; > > } > > EXPORT_SYMBOL(drm_of_find_possible_crtcs); > > + > > +/** > > + * drm_of_component_probe - Generic probe function for a component based master > > + * @dev: master device containing the OF node > > + * @compare_of: compare function used for matching components > > + * @master_ops: component master ops to be used > > + * > > + * Parse the platform device OF node and bind all the components associated > > + * with the master. Interface ports are added before the encoders in order to > > + * satisfy their .bind requirements > > + * See Documentation/devicetree/bindings/graph.txt for the bindings. > > + * > > + * Returns zero if successful, or one of the standard error codes if it fails. > > + */ > > +int drm_of_component_probe(struct device *dev, > > + int (*compare_of)(struct device *, void *), > > + const struct component_master_ops *m_ops) > > +{ > > + struct device_node *ep, *port, *remote; > > + struct component_match *match = NULL; > > + int i; > > + > > + if (!dev->of_node) > > + return -EINVAL; > > + > > + /* > > + * Bind the crtc's ports first, so that drm_of_find_possible_crtcs() > > + * called from encoder's .bind callbacks works as expected > > + */ > > + for (i = 0; ; i++) { > > + port = of_parse_phandle(dev->of_node, "ports", i); > > + if (!port) > > + break; > > + > > + if (!of_device_is_available(port->parent)) { > > + of_node_put(port); > > + continue; > > + } > > + > > + component_match_add(dev, &match, compare_of, port); > > + of_node_put(port); > > + } > > + > > + if (i == 0) { > > + dev_err(dev, "missing 'ports' property\n"); > > + return -ENODEV; > > + } > > + > > + if (!match) { > > + dev_err(dev, "no available port\n"); > > + return -ENODEV; > > + } > > + > > + /* > > + * For bound crtcs, bind the encoders attached to their remote endpoint > > + */ > > + for (i = 0; ; i++) { > > + port = of_parse_phandle(dev->of_node, "ports", i); > > + if (!port) > > + break; > > + > > + if (!of_device_is_available(port->parent)) { > > + of_node_put(port); > > + continue; > > + } > > + > Of the three drivers converted only the rockchip one has the above > of_device_is_available() hunk. Based on the handling in previous loop > I'm not entirely sure if it's needed, but if so shouldn't one mention > the difference when converting the respective drivers ? Yes, it should've been there, otherwise we'll end up binding encoders which are connected to a CRTC which has been disabled - and that means the DRM driver won't come up.
On Tue, Oct 20, 2015 at 11:09:09AM +0100, Russell King - ARM Linux wrote: > On Tue, Oct 20, 2015 at 11:00:55AM +0100, Emil Velikov wrote: > > Hi Liviu, > > > > On 20 October 2015 at 10:23, Liviu Dudau <Liviu.Dudau@arm.com> wrote: > > > A lot of component based DRM drivers use a variant of the same code > > > as the probe function. They bind the crtc ports in the first iteration > > > and then scan through the child nodes and bind the encoders attached > > > to the remote endpoints. Factor the common code into a separate > > > function called drm_of_component_probe() in order to increase code > > > reuse. > > > > > > Cc: David Airlie <airlied@linux.ie> > > > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> > > > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk> > > > --- > > > drivers/gpu/drm/drm_of.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++ > > > include/drm/drm_of.h | 13 +++++++ > > > 2 files changed, 101 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c > > > index be38840..493c05c 100644 > > > --- a/drivers/gpu/drm/drm_of.c > > > +++ b/drivers/gpu/drm/drm_of.c > > > @@ -1,3 +1,4 @@ > > > +#include <linux/component.h> > > > #include <linux/export.h> > > > #include <linux/list.h> > > > #include <linux/of_graph.h> > > > @@ -61,3 +62,90 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev, > > > return possible_crtcs; > > > } > > > EXPORT_SYMBOL(drm_of_find_possible_crtcs); > > > + > > > +/** > > > + * drm_of_component_probe - Generic probe function for a component based master > > > + * @dev: master device containing the OF node > > > + * @compare_of: compare function used for matching components > > > + * @master_ops: component master ops to be used > > > + * > > > + * Parse the platform device OF node and bind all the components associated > > > + * with the master. Interface ports are added before the encoders in order to > > > + * satisfy their .bind requirements > > > + * See Documentation/devicetree/bindings/graph.txt for the bindings. > > > + * > > > + * Returns zero if successful, or one of the standard error codes if it fails. > > > + */ > > > +int drm_of_component_probe(struct device *dev, > > > + int (*compare_of)(struct device *, void *), > > > + const struct component_master_ops *m_ops) > > > +{ > > > + struct device_node *ep, *port, *remote; > > > + struct component_match *match = NULL; > > > + int i; > > > + > > > + if (!dev->of_node) > > > + return -EINVAL; > > > + > > > + /* > > > + * Bind the crtc's ports first, so that drm_of_find_possible_crtcs() > > > + * called from encoder's .bind callbacks works as expected > > > + */ > > > + for (i = 0; ; i++) { > > > + port = of_parse_phandle(dev->of_node, "ports", i); > > > + if (!port) > > > + break; > > > + > > > + if (!of_device_is_available(port->parent)) { > > > + of_node_put(port); > > > + continue; > > > + } > > > + > > > + component_match_add(dev, &match, compare_of, port); > > > + of_node_put(port); > > > + } > > > + > > > + if (i == 0) { > > > + dev_err(dev, "missing 'ports' property\n"); > > > + return -ENODEV; > > > + } > > > + > > > + if (!match) { > > > + dev_err(dev, "no available port\n"); > > > + return -ENODEV; > > > + } > > > + > > > + /* > > > + * For bound crtcs, bind the encoders attached to their remote endpoint > > > + */ > > > + for (i = 0; ; i++) { > > > + port = of_parse_phandle(dev->of_node, "ports", i); > > > + if (!port) > > > + break; > > > + > > > + if (!of_device_is_available(port->parent)) { > > > + of_node_put(port); > > > + continue; > > > + } > > > + > > Of the three drivers converted only the rockchip one has the above > > of_device_is_available() hunk. Based on the handling in previous loop > > I'm not entirely sure if it's needed, but if so shouldn't one mention > > the difference when converting the respective drivers ? > > Yes, it should've been there, otherwise we'll end up binding encoders > which are connected to a CRTC which has been disabled - and that means > the DRM driver won't come up. That's my understanding as well. As mentioned in the cover letter, the generic function tries to gather together the best practice and be more complete than the individual versions found in the drivers. So you get additional checks that should've been in there in the first place if it were not for the code being spread out. Best regards, Liviu > > -- > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. >
diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index be38840..493c05c 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -1,3 +1,4 @@ +#include <linux/component.h> #include <linux/export.h> #include <linux/list.h> #include <linux/of_graph.h> @@ -61,3 +62,90 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev, return possible_crtcs; } EXPORT_SYMBOL(drm_of_find_possible_crtcs); + +/** + * drm_of_component_probe - Generic probe function for a component based master + * @dev: master device containing the OF node + * @compare_of: compare function used for matching components + * @master_ops: component master ops to be used + * + * Parse the platform device OF node and bind all the components associated + * with the master. Interface ports are added before the encoders in order to + * satisfy their .bind requirements + * See Documentation/devicetree/bindings/graph.txt for the bindings. + * + * Returns zero if successful, or one of the standard error codes if it fails. + */ +int drm_of_component_probe(struct device *dev, + int (*compare_of)(struct device *, void *), + const struct component_master_ops *m_ops) +{ + struct device_node *ep, *port, *remote; + struct component_match *match = NULL; + int i; + + if (!dev->of_node) + return -EINVAL; + + /* + * Bind the crtc's ports first, so that drm_of_find_possible_crtcs() + * called from encoder's .bind callbacks works as expected + */ + for (i = 0; ; i++) { + port = of_parse_phandle(dev->of_node, "ports", i); + if (!port) + break; + + if (!of_device_is_available(port->parent)) { + of_node_put(port); + continue; + } + + component_match_add(dev, &match, compare_of, port); + of_node_put(port); + } + + if (i == 0) { + dev_err(dev, "missing 'ports' property\n"); + return -ENODEV; + } + + if (!match) { + dev_err(dev, "no available port\n"); + return -ENODEV; + } + + /* + * For bound crtcs, bind the encoders attached to their remote endpoint + */ + for (i = 0; ; i++) { + port = of_parse_phandle(dev->of_node, "ports", i); + if (!port) + break; + + if (!of_device_is_available(port->parent)) { + of_node_put(port); + continue; + } + + for_each_child_of_node(port, ep) { + remote = of_graph_get_remote_port_parent(ep); + if (!remote || !of_device_is_available(remote)) { + of_node_put(remote); + continue; + } else if (!of_device_is_available(remote->parent)) { + dev_warn(dev, "parent device of %s is not available\n", + remote->full_name); + of_node_put(remote); + continue; + } + + component_match_add(dev, &match, compare_of, remote); + of_node_put(remote); + } + of_node_put(port); + } + + return component_master_add_with_match(dev, m_ops, match); +} +EXPORT_SYMBOL(drm_of_component_probe); diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h index 2441f71..8544665 100644 --- a/include/drm/drm_of.h +++ b/include/drm/drm_of.h @@ -1,18 +1,31 @@ #ifndef __DRM_OF_H__ #define __DRM_OF_H__ +struct component_master_ops; +struct device; struct drm_device; struct device_node; #ifdef CONFIG_OF extern uint32_t drm_of_find_possible_crtcs(struct drm_device *dev, struct device_node *port); +extern int drm_of_component_probe(struct device *dev, + int (*compare_of)(struct device *, void *), + const struct component_master_ops *m_ops); #else static inline uint32_t drm_of_find_possible_crtcs(struct drm_device *dev, struct device_node *port) { return 0; } + +static inline int +drm_of_component_probe(struct device *dev, + int (*compare_of)(struct device *, void *), + const struct component_master_ops *m_ops) +{ + return -EINVAL; +} #endif #endif /* __DRM_OF_H__ */