| Message ID | 1445332961-25419-5-git-send-email-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
W dniu 20.10.2015 o 18:22, Andrzej Hajda pisze: > DECON IP requires this clock to access configuration registers. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > Documentation/devicetree/bindings/video/exynos5433-decon.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/video/exynos5433-decon.txt b/Documentation/devicetree/bindings/video/exynos5433-decon.txt > index 377afbf..3dff78b 100644 > --- a/Documentation/devicetree/bindings/video/exynos5433-decon.txt > +++ b/Documentation/devicetree/bindings/video/exynos5433-decon.txt > @@ -16,7 +16,7 @@ Required properties: > - clocks: must include clock specifiers corresponding to entries in the > clock-names property. > - clock-names: list of clock names sorted in the same order as the clocks > - property. Must contain "aclk_decon", "aclk_smmu_decon0x", > + property. Must contain "pclk", "aclk_decon", "aclk_smmu_decon0x", I assume that old DTB wouldn't work at all, so there is no point in maintaining ABI compatibility? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/20/2015 02:24 PM, Krzysztof Kozlowski wrote: > W dniu 20.10.2015 o 18:22, Andrzej Hajda pisze: >> DECON IP requires this clock to access configuration registers. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> --- >> Documentation/devicetree/bindings/video/exynos5433-decon.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/video/exynos5433-decon.txt b/Documentation/devicetree/bindings/video/exynos5433-decon.txt >> index 377afbf..3dff78b 100644 >> --- a/Documentation/devicetree/bindings/video/exynos5433-decon.txt >> +++ b/Documentation/devicetree/bindings/video/exynos5433-decon.txt >> @@ -16,7 +16,7 @@ Required properties: >> - clocks: must include clock specifiers corresponding to entries in the >> clock-names property. >> - clock-names: list of clock names sorted in the same order as the clocks >> - property. Must contain "aclk_decon", "aclk_smmu_decon0x", >> + property. Must contain "pclk", "aclk_decon", "aclk_smmu_decon0x", > I assume that old DTB wouldn't work at all, so there is no point in > maintaining ABI compatibility? Yes, Exynos 5433 has not yet landed in mainline. Regards Andrzej > > Best regards, > Krzysztof > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-10-20 21:41 GMT+09:00 Andrzej Hajda <a.hajda@samsung.com>: > On 10/20/2015 02:24 PM, Krzysztof Kozlowski wrote: >> W dniu 20.10.2015 o 18:22, Andrzej Hajda pisze: >>> DECON IP requires this clock to access configuration registers. >>> >>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >>> --- >>> Documentation/devicetree/bindings/video/exynos5433-decon.txt | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/video/exynos5433-decon.txt b/Documentation/devicetree/bindings/video/exynos5433-decon.txt >>> index 377afbf..3dff78b 100644 >>> --- a/Documentation/devicetree/bindings/video/exynos5433-decon.txt >>> +++ b/Documentation/devicetree/bindings/video/exynos5433-decon.txt >>> @@ -16,7 +16,7 @@ Required properties: >>> - clocks: must include clock specifiers corresponding to entries in the >>> clock-names property. >>> - clock-names: list of clock names sorted in the same order as the clocks >>> - property. Must contain "aclk_decon", "aclk_smmu_decon0x", >>> + property. Must contain "pclk", "aclk_decon", "aclk_smmu_decon0x", >> I assume that old DTB wouldn't work at all, so there is no point in >> maintaining ABI compatibility? > > Yes, Exynos 5433 has not yet landed in mainline. No, no. I was asking if something using these compatibles would work previously or not? The driver provided a compatible, an ABI. Now you require additional field for the same compatible, so the ABI changes. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 20/10/15 14:24, Krzysztof Kozlowski wrote: > W dniu 20.10.2015 o 18:22, Andrzej Hajda pisze: >> > DECON IP requires this clock to access configuration registers. >> > >> > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> > --- >> > Documentation/devicetree/bindings/video/exynos5433-decon.txt | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/Documentation/devicetree/bindings/video/exynos5433-decon.txt b/Documentation/devicetree/bindings/video/exynos5433-decon.txt >> > index 377afbf..3dff78b 100644 >> > --- a/Documentation/devicetree/bindings/video/exynos5433-decon.txt >> > +++ b/Documentation/devicetree/bindings/video/exynos5433-decon.txt >> > @@ -16,7 +16,7 @@ Required properties: >> > - clocks: must include clock specifiers corresponding to entries in the >> > clock-names property. >> > - clock-names: list of clock names sorted in the same order as the clocks >> > - property. Must contain "aclk_decon", "aclk_smmu_decon0x", >> > + property. Must contain "pclk", "aclk_decon", "aclk_smmu_decon0x", > > I assume that old DTB wouldn't work at all, so there is no point in > maintaining ABI compatibility? As you know there is no single exynos5433 board dts that would use the DECON IP block in mainline yet. I doubt anyone at this point in mainline cares whether we require this additional clock or not.
diff --git a/Documentation/devicetree/bindings/video/exynos5433-decon.txt b/Documentation/devicetree/bindings/video/exynos5433-decon.txt index 377afbf..3dff78b 100644 --- a/Documentation/devicetree/bindings/video/exynos5433-decon.txt +++ b/Documentation/devicetree/bindings/video/exynos5433-decon.txt @@ -16,7 +16,7 @@ Required properties: - clocks: must include clock specifiers corresponding to entries in the clock-names property. - clock-names: list of clock names sorted in the same order as the clocks - property. Must contain "aclk_decon", "aclk_smmu_decon0x", + property. Must contain "pclk", "aclk_decon", "aclk_smmu_decon0x", "aclk_xiu_decon0x", "pclk_smmu_decon0x", clk_decon_vclk", "sclk_decon_eclk" - ports: contains a port which is connected to mic node. address-cells and
DECON IP requires this clock to access configuration registers. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- Documentation/devicetree/bindings/video/exynos5433-decon.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)