| Message ID | 1445803567-8511-1-git-send-email-moritz.fischer@ettus.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
Hi Moritz, On Sun, Oct 25, 2015 at 01:06:06PM -0700, Moritz Fischer wrote: > The produced module will be called e3x0-button, not > e3x0_button. This is not entirely correct. The file name is e3x0-button.ko, but the module name is e3x0_button: when we construct KBUILD_MODNAME we substitute commas and dashes for underscores - see scripts/Makefile.lib > > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> > --- > drivers/input/misc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig > index 906dd1b..7ac277c7 100644 > --- a/drivers/input/misc/Kconfig > +++ b/drivers/input/misc/Kconfig > @@ -101,7 +101,7 @@ config INPUT_E3X0_BUTTON > USRP E3x0 Button. > > To compile this driver as a module, choose M here: the > - module will be called e3x0_button. > + module will be called e3x0-button. > > config INPUT_PCSPKR > tristate "PC Speaker support" > -- > 2.6.2 > Thanks.
On Sun, Oct 25, 2015 at 1:49 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > Hi Moritz, > > On Sun, Oct 25, 2015 at 01:06:06PM -0700, Moritz Fischer wrote: >> The produced module will be called e3x0-button, not >> e3x0_button. > > This is not entirely correct. The file name is e3x0-button.ko, but the > module name is e3x0_button: when we construct KBUILD_MODNAME we > substitute commas and dashes for underscores - see scripts/Makefile.lib Thanks for the clarification. Good to know it wasn't broken in the first place. Cheers, Moritz -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig index 906dd1b..7ac277c7 100644 --- a/drivers/input/misc/Kconfig +++ b/drivers/input/misc/Kconfig @@ -101,7 +101,7 @@ config INPUT_E3X0_BUTTON USRP E3x0 Button. To compile this driver as a module, choose M here: the - module will be called e3x0_button. + module will be called e3x0-button. config INPUT_PCSPKR tristate "PC Speaker support"
The produced module will be called e3x0-button, not e3x0_button. Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> --- drivers/input/misc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)