| Message ID | 1445900510-1398-5-git-send-email-sakari.ailus@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Em Tue, 27 Oct 2015 01:01:35 +0200 Sakari Ailus <sakari.ailus@iki.fi> escreveu: > It will be needed in struct media_pipeline shortly. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> (but see below) > --- > include/media/media-entity.h | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > index fc54192..dde9a5f 100644 > --- a/include/media/media-entity.h > +++ b/include/media/media-entity.h > @@ -87,6 +87,16 @@ struct media_entity_enum { > int idx_max; > }; > > +struct media_entity_graph { Not a problem on this patch itself, but since you're touching this struct, it would be nice to take the opportunity and document it ;) Regards, Mauro > + struct { > + struct media_entity *entity; > + struct list_head *link; > + } stack[MEDIA_ENTITY_ENUM_MAX_DEPTH]; > + > + DECLARE_BITMAP(entities, MEDIA_ENTITY_ENUM_MAX_ID); > + int top; > +}; > + > struct media_pipeline { > }; > > @@ -429,16 +439,6 @@ static inline bool media_entity_enum_intersects(struct media_entity_enum *e, > return bitmap_intersects(e->e, f->e, min(e->idx_max, f->idx_max)); > } > > -struct media_entity_graph { > - struct { > - struct media_entity *entity; > - struct list_head *link; > - } stack[MEDIA_ENTITY_ENUM_MAX_DEPTH]; > - > - DECLARE_BITMAP(entities, MEDIA_ENTITY_ENUM_MAX_ID); > - int top; > -}; > - > #define gobj_to_entity(gobj) \ > container_of(gobj, struct media_entity, graph_obj) >
Hi Mauro, On Wed, Oct 28, 2015 at 09:36:50AM +0900, Mauro Carvalho Chehab wrote: > Em Tue, 27 Oct 2015 01:01:35 +0200 > Sakari Ailus <sakari.ailus@iki.fi> escreveu: > > > It will be needed in struct media_pipeline shortly. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > Reviewed-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > (but see below) > > > --- > > include/media/media-entity.h | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > > index fc54192..dde9a5f 100644 > > --- a/include/media/media-entity.h > > +++ b/include/media/media-entity.h > > @@ -87,6 +87,16 @@ struct media_entity_enum { > > int idx_max; > > }; > > > > +struct media_entity_graph { > > Not a problem on this patch itself, but since you're touching this > struct, it would be nice to take the opportunity and document it ;) I'll document it in a separate patch on top of the set. Would you be fine with that?
On Wed, Nov 04, 2015 at 12:22:38AM +0200, Sakari Ailus wrote: > Hi Mauro, > > On Wed, Oct 28, 2015 at 09:36:50AM +0900, Mauro Carvalho Chehab wrote: > > Em Tue, 27 Oct 2015 01:01:35 +0200 > > Sakari Ailus <sakari.ailus@iki.fi> escreveu: > > > > > It will be needed in struct media_pipeline shortly. > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > > > Reviewed-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > (but see below) > > > > > --- > > > include/media/media-entity.h | 20 ++++++++++---------- > > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > > > index fc54192..dde9a5f 100644 > > > --- a/include/media/media-entity.h > > > +++ b/include/media/media-entity.h > > > @@ -87,6 +87,16 @@ struct media_entity_enum { > > > int idx_max; > > > }; > > > > > > +struct media_entity_graph { > > > > Not a problem on this patch itself, but since you're touching this > > struct, it would be nice to take the opportunity and document it ;) > > I'll document it in a separate patch on top of the set. Would you be fine > with that? Thinking about this, I'll change the patches to include the documentation. It's better that way, I agree.
diff --git a/include/media/media-entity.h b/include/media/media-entity.h index fc54192..dde9a5f 100644 --- a/include/media/media-entity.h +++ b/include/media/media-entity.h @@ -87,6 +87,16 @@ struct media_entity_enum { int idx_max; }; +struct media_entity_graph { + struct { + struct media_entity *entity; + struct list_head *link; + } stack[MEDIA_ENTITY_ENUM_MAX_DEPTH]; + + DECLARE_BITMAP(entities, MEDIA_ENTITY_ENUM_MAX_ID); + int top; +}; + struct media_pipeline { }; @@ -429,16 +439,6 @@ static inline bool media_entity_enum_intersects(struct media_entity_enum *e, return bitmap_intersects(e->e, f->e, min(e->idx_max, f->idx_max)); } -struct media_entity_graph { - struct { - struct media_entity *entity; - struct list_head *link; - } stack[MEDIA_ENTITY_ENUM_MAX_DEPTH]; - - DECLARE_BITMAP(entities, MEDIA_ENTITY_ENUM_MAX_ID); - int top; -}; - #define gobj_to_entity(gobj) \ container_of(gobj, struct media_entity, graph_obj)
It will be needed in struct media_pipeline shortly. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- include/media/media-entity.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)