| Message ID | 1444401430-4396-2-git-send-email-edward.cragg@codethink.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Oct 9, 2015 at 4:37 PM, Edward Cragg <edward.cragg@codethink.co.uk> wrote: > Add the blue status LED to the Hardkernel Odroid C1 board DTS. > This is the only programmable LED on the board. > > Signed-off-by: Edward Cragg <edward.cragg@codethink.co.uk> > --- > arch/arm/boot/dts/meson8b-odroidc1.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts > index a8e2911..3b03523 100644 > --- a/arch/arm/boot/dts/meson8b-odroidc1.dts > +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts > @@ -1,6 +1,8 @@ > /* > * Copyright 2015 Endless Mobile, Inc. > * Author: Carlo Caione <carlo@endlessm.com> > + * Copyright 2015 Codethink Ltd. > + * Author: Edward Cragg <edward.cragg@codethink.co.uk> Usually we do not add a copyright line for each small addition to the DTS. > * > * This file is dual-licensed: you can use it either under the terms > * of the GPL or the X11 license, at your option. Note that this dual > @@ -46,6 +48,7 @@ > > /dts-v1/; > #include "meson8b.dtsi" > +#include <dt-bindings/gpio/gpio.h> > > / { > model = "Hardkernel ODROID-C1"; > @@ -58,6 +61,16 @@ > memory { > reg = <0x40000000 0x40000000>; > }; > + > + leds { > + compatible = "gpio-leds"; > + blue { > + label = "c1:blue:alive"; > + gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "heartbeat"; > + default-state = "off"; > + }; > + }; > }; otherwise Acked-by: Carlo Caione <carlo@endlessm.com>
On Fri, Oct 09, 2015 at 03:37:10PM +0100, Edward Cragg wrote: > Add the blue status LED to the Hardkernel Odroid C1 board DTS. > This is the only programmable LED on the board. > > Signed-off-by: Edward Cragg <edward.cragg@codethink.co.uk> > --- > arch/arm/boot/dts/meson8b-odroidc1.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > Hi, has anyone had a chance to have a look at this yet? I originally forgot to add that this patch is dependent on: [PATCH v2 0/4] Add support for Amlogic Meson8b and couple of boards which has already been accepted. Ed
On Fri, Oct 30, 2015 at 6:55 PM, Edward Cragg <edward.cragg@codethink.co.uk> wrote: > On Fri, Oct 09, 2015 at 03:37:10PM +0100, Edward Cragg wrote: >> Add the blue status LED to the Hardkernel Odroid C1 board DTS. >> This is the only programmable LED on the board. >> >> Signed-off-by: Edward Cragg <edward.cragg@codethink.co.uk> >> --- >> arch/arm/boot/dts/meson8b-odroidc1.dts | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> > > Hi, has anyone had a chance to have a look at this yet? Yes, I already replied to you on Oct 12. I was waiting for a resubmission without the added copyright but I'll modify it myself and I'll push a PR. Cheers,
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index a8e2911..3b03523 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -1,6 +1,8 @@ /* * Copyright 2015 Endless Mobile, Inc. * Author: Carlo Caione <carlo@endlessm.com> + * Copyright 2015 Codethink Ltd. + * Author: Edward Cragg <edward.cragg@codethink.co.uk> * * This file is dual-licensed: you can use it either under the terms * of the GPL or the X11 license, at your option. Note that this dual @@ -46,6 +48,7 @@ /dts-v1/; #include "meson8b.dtsi" +#include <dt-bindings/gpio/gpio.h> / { model = "Hardkernel ODROID-C1"; @@ -58,6 +61,16 @@ memory { reg = <0x40000000 0x40000000>; }; + + leds { + compatible = "gpio-leds"; + blue { + label = "c1:blue:alive"; + gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>; + linux,default-trigger = "heartbeat"; + default-state = "off"; + }; + }; }; &uart_AO {
Add the blue status LED to the Hardkernel Odroid C1 board DTS. This is the only programmable LED on the board. Signed-off-by: Edward Cragg <edward.cragg@codethink.co.uk> --- arch/arm/boot/dts/meson8b-odroidc1.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)