| Message ID | 1447084107-8521-10-git-send-email-patrik.jakobsson@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On ma, 2015-11-09 at 16:48 +0100, Patrik Jakobsson wrote: > Signed-off-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_reg.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h > b/drivers/gpu/drm/i915/i915_reg.h > index e6d88f5..31b3a84 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -621,6 +621,7 @@ enum punit_power_well { > PUNIT_POWER_WELL_DPIO_RX1 = 11, > PUNIT_POWER_WELL_DPIO_CMN_D = 12, > > + /* Not actual bit groups. Used as IDs for > lookup_power_well() */ > PUNIT_POWER_WELL_ALWAYS_ON, > }; > > @@ -633,6 +634,7 @@ enum skl_disp_power_wells { > SKL_DISP_PW_1 = 14, > SKL_DISP_PW_2, > > + /* Not actual bit groups. Used as IDs for > lookup_power_well() */ It would be good to mention that these IDs are fixed since they are also used to index HW flags. With that fixed: Reviewed-by: Imre Deak <imre.deak@intel.com> > > SKL_DISP_PW_ALWAYS_ON, > }; >
On Wed, Nov 11, 2015 at 09:13:27PM +0200, Imre Deak wrote: > On ma, 2015-11-09 at 16:48 +0100, Patrik Jakobsson wrote: > > Signed-off-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com> > > --- > > drivers/gpu/drm/i915/i915_reg.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_reg.h > > b/drivers/gpu/drm/i915/i915_reg.h > > index e6d88f5..31b3a84 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > @@ -621,6 +621,7 @@ enum punit_power_well { > > PUNIT_POWER_WELL_DPIO_RX1 = 11, > > PUNIT_POWER_WELL_DPIO_CMN_D = 12, > > > > + /* Not actual bit groups. Used as IDs for > > lookup_power_well() */ > > PUNIT_POWER_WELL_ALWAYS_ON, > > }; > > > > @@ -633,6 +634,7 @@ enum skl_disp_power_wells { > > SKL_DISP_PW_1 = 14, > > SKL_DISP_PW_2, > > > > + /* Not actual bit groups. Used as IDs for > > lookup_power_well() */ > > It would be good to mention that these IDs are fixed since they are > also used to index HW flags. With that fixed: > Reviewed-by: Imre Deak <imre.deak@intel.com> Good point, will add that. > > > > > > SKL_DISP_PW_ALWAYS_ON, > > }; > >
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index e6d88f5..31b3a84 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -621,6 +621,7 @@ enum punit_power_well { PUNIT_POWER_WELL_DPIO_RX1 = 11, PUNIT_POWER_WELL_DPIO_CMN_D = 12, + /* Not actual bit groups. Used as IDs for lookup_power_well() */ PUNIT_POWER_WELL_ALWAYS_ON, }; @@ -633,6 +634,7 @@ enum skl_disp_power_wells { SKL_DISP_PW_1 = 14, SKL_DISP_PW_2, + /* Not actual bit groups. Used as IDs for lookup_power_well() */ SKL_DISP_PW_ALWAYS_ON, };
Signed-off-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ 1 file changed, 2 insertions(+)