| Message ID | 155366ac799345f42c8c342609ffa11b2df529b0.1447773299.git.stillcompiling@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 17, 2015 at 07:24:27AM -0800, Joshua Clayton wrote: > Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> > --- > tools/Makefile | 37 ++++++++++++++++++++++++++++++------- > 1 file changed, 30 insertions(+), 7 deletions(-) > > diff --git a/tools/Makefile b/tools/Makefile > index 9a617ad..428fb4d 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -80,10 +80,21 @@ turbostat_install x86_energy_perf_policy_install: > tmon_install: > $(call descend,thermal/$(@:_install=),install) > > -install: acpi_install cgroup_install cpupower_install hv_install firewire_install lguest_install \ > - perf_install selftests_install turbostat_install usb_install \ > - virtio_install vm_install net_install x86_energy_perf_policy_install \ > - tmon > +install: acpi_install \ > + cgroup_install \ > + cpupower_install \ > + hv_install \ > + firewire_install \ > + lguest_install \ > + perf_install \ > + selftests_install \ > + tmon \ > + turbostat_install \ > + usb_install \ > + virtio_install \ > + vm_install \ > + net_install \ > + x86_energy_perf_policy_install This isn't a whitespace cleanup, this is a substantial reindentation of the file :( Please ensure your changelogs are accurate and in general try to avoid mixing this sort of invasive stylistic change in with other patch serieses, it reduces the potential for conflicts.
On Tuesday, November 17, 2015 06:09:24 PM Mark Brown wrote: > On Tue, Nov 17, 2015 at 07:24:27AM -0800, Joshua Clayton wrote: > > Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> > > --- > > tools/Makefile | 37 ++++++++++++++++++++++++++++++------- > > 1 file changed, 30 insertions(+), 7 deletions(-) > > > > diff --git a/tools/Makefile b/tools/Makefile > > index 9a617ad..428fb4d 100644 > > --- a/tools/Makefile > > +++ b/tools/Makefile > > @@ -80,10 +80,21 @@ turbostat_install x86_energy_perf_policy_install: > > tmon_install: > > $(call descend,thermal/$(@:_install=),install) > > > > -install: acpi_install cgroup_install cpupower_install hv_install firewire_install lguest_install \ > > - perf_install selftests_install turbostat_install usb_install \ > > - virtio_install vm_install net_install x86_energy_perf_policy_install \ > > - tmon > > +install: acpi_install \ > > + cgroup_install \ > > + cpupower_install \ > > + hv_install \ > > + firewire_install \ > > + lguest_install \ > > + perf_install \ > > + selftests_install \ > > + tmon \ > > + turbostat_install \ > > + usb_install \ > > + virtio_install \ > > + vm_install \ > > + net_install \ > > + x86_energy_perf_policy_install > > This isn't a whitespace cleanup, this is a substantial reindentation of > the file :( Please ensure your changelogs are accurate and in general > try to avoid mixing this sort of invasive stylistic change in with other > patch serieses, it reduces the potential for conflicts. Um. Inability to resist Makefile cleanup is a weakness of mine. It is a tangent from the rest of the series so I'll drop it.
diff --git a/tools/Makefile b/tools/Makefile index 9a617ad..428fb4d 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -80,10 +80,21 @@ turbostat_install x86_energy_perf_policy_install: tmon_install: $(call descend,thermal/$(@:_install=),install) -install: acpi_install cgroup_install cpupower_install hv_install firewire_install lguest_install \ - perf_install selftests_install turbostat_install usb_install \ - virtio_install vm_install net_install x86_energy_perf_policy_install \ - tmon +install: acpi_install \ + cgroup_install \ + cpupower_install \ + hv_install \ + firewire_install \ + lguest_install \ + perf_install \ + selftests_install \ + tmon \ + turbostat_install \ + usb_install \ + virtio_install \ + vm_install \ + net_install \ + x86_energy_perf_policy_install acpi_clean: $(call descend,power/acpi,clean) @@ -112,8 +123,20 @@ turbostat_clean x86_energy_perf_policy_clean: tmon_clean: $(call descend,thermal/tmon,clean) -clean: acpi_clean cgroup_clean cpupower_clean hv_clean firewire_clean lguest_clean \ - perf_clean selftests_clean turbostat_clean usb_clean virtio_clean \ - vm_clean net_clean x86_energy_perf_policy_clean tmon_clean +clean: acpi_clean \ + cgroup_clean \ + cpupower_clean \ + hv_clean \ + firewire_clean \ + lguest_clean \ + perf_clean \ + selftests_clean \ + tmon_clean \ + turbostat_clean \ + usb_clean \ + virtio_clean \ + vm_clean \ + net_clean \ + x86_energy_perf_policy_clean .PHONY: FORCE
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com> --- tools/Makefile | 37 ++++++++++++++++++++++++++++++------- 1 file changed, 30 insertions(+), 7 deletions(-)