| Message ID | 1447898761-6938-1-git-send-email-glen.lee@atmel.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
On Thu, Nov 19, 2015 at 11:05:58AM +0900, Glen Lee wrote: > This patch removes define COMPLEMENT_BOOT in Makefile. The feature was removed > by the following commit but the define was not removed. So remove completely. > > b46d68825c2d3af70ad18b53dfed6516e393b7fa Put some human readable text next to the hash. The standard thing is to include only the first 12 characters of the hash. If there are fewer than 12 characters then we could get collisions but including the whole hash is excessive. This patch removes define COMPLEMENT_BOOT in Makefile. The feature was removed by commit b46d68825c2d ('staging: wilc1000: remove COMPLEMENT_BOOT') but the define was not removed. So remove completely. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2015? 11? 19? 15:19, Dan Carpenter wrote: > On Thu, Nov 19, 2015 at 11:05:58AM +0900, Glen Lee wrote: >> This patch removes define COMPLEMENT_BOOT in Makefile. The feature was removed >> by the following commit but the define was not removed. So remove completely. >> >> b46d68825c2d3af70ad18b53dfed6516e393b7fa > Put some human readable text next to the hash. The standard thing is to > include only the first 12 characters of the hash. If there are fewer > than 12 characters then we could get collisions but including the whole > hash is excessive. Ok, I understand. Thank you for your advise. regards, glen lee > > This patch removes define COMPLEMENT_BOOT in Makefile. The feature was > removed by commit b46d68825c2d ('staging: wilc1000: remove > COMPLEMENT_BOOT') but the define was not removed. So remove completely. > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 19, 2015 at 11:05:58AM +0900, Glen Lee wrote: > This patch removes define COMPLEMENT_BOOT in Makefile. The feature was removed > by the following commit but the define was not removed. So remove completely. > > b46d68825c2d3af70ad18b53dfed6516e393b7fa Please fix this up and resend the whole series. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/wilc1000/Makefile b/drivers/staging/wilc1000/Makefile index 198d536..c55fdd2 100644 --- a/drivers/staging/wilc1000/Makefile +++ b/drivers/staging/wilc1000/Makefile @@ -1,7 +1,5 @@ obj-$(CONFIG_WILC1000) += wilc1000.o -ccflags-$(CONFIG_WILC1000_SDIO) += -DCOMPLEMENT_BOOT - ccflags-y += -DSTA_FIRMWARE=\"atmel/wilc1000_fw.bin\" \ -DAP_FIRMWARE=\"atmel/wilc1000_ap_fw.bin\" \ -DP2P_CONCURRENCY_FIRMWARE=\"atmel/wilc1000_p2p_fw.bin\"
This patch removes define COMPLEMENT_BOOT in Makefile. The feature was removed by the following commit but the define was not removed. So remove completely. b46d68825c2d3af70ad18b53dfed6516e393b7fa Signed-off-by: Glen Lee <glen.lee@atmel.com> --- drivers/staging/wilc1000/Makefile | 2 -- 1 file changed, 2 deletions(-)