| Message ID | 1447411835-19035-1-git-send-email-eddie.huang@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Eddie Huang <eddie.huang@mediatek.com> writes: > If enable Mediatek 8173 SoC, it should also enable power domain > driver. Otherwise access clk subsystem register will fail. > > Signed-off-by: Eddie Huang <eddie.huang@mediatek.com> Tested-by: Kevin Hilman <khilman@linaro.org> This gets the mt8173-evb booting again with arm-soc/for-next and mainline for me. I'll let Matthias queue this up and send it with any other fixes for v4.4-rc1. Thanks for the fix, Kevin P.S. it's curious that nobody caught this basic boot failure before. Is nobody else testing mainline on this board? or maybe not using the upstream defconfig?
On Fri, Nov 13, 2015 at 7:59 AM, Kevin Hilman <khilman@kernel.org> wrote: > Eddie Huang <eddie.huang@mediatek.com> writes: > >> If enable Mediatek 8173 SoC, it should also enable power domain >> driver. Otherwise access clk subsystem register will fail. >> >> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com> > > Tested-by: Kevin Hilman <khilman@linaro.org> > > This gets the mt8173-evb booting again with arm-soc/for-next and > mainline for me. > > I'll let Matthias queue this up and send it with any other fixes for > v4.4-rc1. Matthias, this is still broken in arm-soc. Curious if your planning on sending a fix? If you prefer, with your ack, we can apply directly to arm-soc/fixes. Kevin
On 19/11/15 21:05, Kevin Hilman wrote: > On Fri, Nov 13, 2015 at 7:59 AM, Kevin Hilman <khilman@kernel.org> wrote: >> Eddie Huang <eddie.huang@mediatek.com> writes: >> >>> If enable Mediatek 8173 SoC, it should also enable power domain >>> driver. Otherwise access clk subsystem register will fail. >>> >>> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com> >> >> Tested-by: Kevin Hilman <khilman@linaro.org> >> >> This gets the mt8173-evb booting again with arm-soc/for-next and >> mainline for me. >> >> I'll let Matthias queue this up and send it with any other fixes for >> v4.4-rc1. > > Matthias, this is still broken in arm-soc. Curious if your planning > on sending a fix? If you prefer, with your ack, we can apply directly > to arm-soc/fixes. > Sorry for the delay. Please apply it directly. Acked-by: Matthias Brugger <matthias.bgg@gmail.com> Thanks a lot, Matthias
Matthias Brugger <matthias.bgg@gmail.com> writes: > On 19/11/15 21:05, Kevin Hilman wrote: >> On Fri, Nov 13, 2015 at 7:59 AM, Kevin Hilman <khilman@kernel.org> wrote: >>> Eddie Huang <eddie.huang@mediatek.com> writes: >>> >>>> If enable Mediatek 8173 SoC, it should also enable power domain >>>> driver. Otherwise access clk subsystem register will fail. >>>> >>>> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com> >>> >>> Tested-by: Kevin Hilman <khilman@linaro.org> >>> >>> This gets the mt8173-evb booting again with arm-soc/for-next and >>> mainline for me. >>> >>> I'll let Matthias queue this up and send it with any other fixes for >>> v4.4-rc1. >> >> Matthias, this is still broken in arm-soc. Curious if your planning >> on sending a fix? If you prefer, with your ack, we can apply directly >> to arm-soc/fixes. >> > > Sorry for the delay. Please apply it directly. > > Acked-by: Matthias Brugger <matthias.bgg@gmail.com> > Thanks, applied to arm-soc/fixes. Kevin
diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig index 9d50682..0a4ea80 100644 --- a/drivers/soc/mediatek/Kconfig +++ b/drivers/soc/mediatek/Kconfig @@ -23,6 +23,7 @@ config MTK_PMIC_WRAP config MTK_SCPSYS bool "MediaTek SCPSYS Support" depends on ARCH_MEDIATEK || COMPILE_TEST + default ARM64 && ARCH_MEDIATEK select REGMAP select MTK_INFRACFG select PM_GENERIC_DOMAINS if PM
If enable Mediatek 8173 SoC, it should also enable power domain driver. Otherwise access clk subsystem register will fail. Signed-off-by: Eddie Huang <eddie.huang@mediatek.com> --- MT8173 clk driver is enabled by default, but power domain driver is not. If MM subsystem power on, mm_sel topckgen mux is off, then access any MM subsystem register will cause system hang. Enable SCPSYS driver to make sure both MM subsystem power and mm_sel to on/off together to avoid system hang. This patch fix current linux-next mt8173-evb boot to shell fail problem. --- drivers/soc/mediatek/Kconfig | 1 + 1 file changed, 1 insertion(+)