Message ID | 1448061641-31672-1-git-send-email-tim.bird@sonymobile.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers | show |
On 11/20/2015 03:20 PM, Tim Bird wrote: > Add optional async_irq to msm_hsusb binding doc. > > Signed-off-by: Tim Bird <tim.bird@sonymobile.com> > Acked-by: Rob Herring <robh@kernel.org> I probably should have taken this Acked-by by Rob off. Sorry about that. -- Tim > --- > Documentation/devicetree/bindings/usb/msm-hsusb.txt | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree/bindings/usb/msm-hsusb.txt > index 8654a3e..bb2b304 100644 > --- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt > +++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt > @@ -23,7 +23,12 @@ Required properties: > "qcom,usb-otg-snps" for chipsets with Synopsys 28nm PHY > > - regs: Offset and length of the register set in the memory map > -- interrupts: interrupt-specifier for the OTG interrupt. > +- interrupts: interrupt-specifier for the OTG interrupts > + > +- interrupt-names: Should contain the following: > + "core" USB core interrupt > + "async" Asynchronous interrupt to wake up from low power mode > + (optional) > > - clocks: A list of phandle + clock-specifier pairs for the > clocks listed in clock-names > @@ -89,7 +94,8 @@ Example HSUSB OTG controller device node: > usb@f9a55000 { > compatible = "qcom,usb-otg-snps"; > reg = <0xf9a55000 0x400>; > - interrupts = <0 134 0>; > + interrupts = <0 134 0>, <0 140 0>; > + interrupt-names = "core_irq", "async_irq"; > dr_mode = "peripheral"; > > clocks = <&gcc GCC_XO_CLK>, <&gcc GCC_USB_HS_SYSTEM_CLK>, > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 20 November 2015 15:20:39 Tim Bird wrote: > +- interrupt-names: Should contain the following: > + "core" USB core interrupt > + "async" Asynchronous interrupt to wake up from low power mode > + (optional) > > - clocks: A list of phandle + clock-specifier pairs for the > clocks listed in clock-names > @@ -89,7 +94,8 @@ Example HSUSB OTG controller device node: > usb@f9a55000 { > compatible = "qcom,usb-otg-snps"; > reg = <0xf9a55000 0x400>; > - interrupts = <0 134 0>; > + interrupts = <0 134 0>, <0 140 0>; > + interrupt-names = "core_irq", "async_irq"; > dr_mode = "peripheral"; > > Now the example doesn't match the documentation any more. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/20/2015 03:22 PM, Arnd Bergmann wrote: > On Friday 20 November 2015 15:20:39 Tim Bird wrote: >> +- interrupt-names: Should contain the following: >> + "core" USB core interrupt >> + "async" Asynchronous interrupt to wake up from low power mode >> + (optional) >> >> - clocks: A list of phandle + clock-specifier pairs for the >> clocks listed in clock-names >> @@ -89,7 +94,8 @@ Example HSUSB OTG controller device node: >> usb@f9a55000 { >> compatible = "qcom,usb-otg-snps"; >> reg = <0xf9a55000 0x400>; >> - interrupts = <0 134 0>; >> + interrupts = <0 134 0>, <0 140 0>; >> + interrupt-names = "core_irq", "async_irq"; >> dr_mode = "peripheral"; >> >> > > Now the example doesn't match the documentation any more. Arrgh. I'm an idiot. V4 coming RSN. -- Tim -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree/bindings/usb/msm-hsusb.txt index 8654a3e..bb2b304 100644 --- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt +++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt @@ -23,7 +23,12 @@ Required properties: "qcom,usb-otg-snps" for chipsets with Synopsys 28nm PHY - regs: Offset and length of the register set in the memory map -- interrupts: interrupt-specifier for the OTG interrupt. +- interrupts: interrupt-specifier for the OTG interrupts + +- interrupt-names: Should contain the following: + "core" USB core interrupt + "async" Asynchronous interrupt to wake up from low power mode + (optional) - clocks: A list of phandle + clock-specifier pairs for the clocks listed in clock-names @@ -89,7 +94,8 @@ Example HSUSB OTG controller device node: usb@f9a55000 { compatible = "qcom,usb-otg-snps"; reg = <0xf9a55000 0x400>; - interrupts = <0 134 0>; + interrupts = <0 134 0>, <0 140 0>; + interrupt-names = "core_irq", "async_irq"; dr_mode = "peripheral"; clocks = <&gcc GCC_XO_CLK>, <&gcc GCC_USB_HS_SYSTEM_CLK>,